Skip to content

require +python for esmf#1560

Merged
climbfuji merged 1 commit intodevelopfrom
AlexanderRichert-NOAA-patch-1
Mar 14, 2025
Merged

require +python for esmf#1560
climbfuji merged 1 commit intodevelopfrom
AlexanderRichert-NOAA-patch-1

Conversation

@AlexanderRichert-NOAA
Copy link
Copy Markdown
Collaborator

Summary

This PR changes the +python setting from a 'prefer' to a 'require' in common/packages.yaml (discussed in #1485)

Testing

Tested on Acorn

Applications affected

Most/all

Systems affected

All

Dependencies

none

Issue(s) addressed

none

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@AlexanderRichert-NOAA AlexanderRichert-NOAA marked this pull request as ready for review March 12, 2025 22:52
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll wait for the CI tests

@climbfuji
Copy link
Copy Markdown
Collaborator

Still working on the macOS CI runner after clearing the buildcache yesterday ...

@climbfuji
Copy link
Copy Markdown
Collaborator

Still working on the macOS CI runner after clearing the buildcache yesterday ...

My manualy build on macOS worked, and the rerun is still going (something is off on that machine - may need a reboot @eap?)

@climbfuji climbfuji merged commit 84ac341 into develop Mar 14, 2025
9 of 10 checks passed
@climbfuji climbfuji deleted the AlexanderRichert-NOAA-patch-1 branch March 14, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants