Update NRL batch_install.sh: exclude crtm-fix from duplicate check list#1497
Merged
Update NRL batch_install.sh: exclude crtm-fix from duplicate check list#1497
Conversation
AlexanderRichert-NOAA
approved these changes
Feb 6, 2025
areinecke
approved these changes
Feb 6, 2025
Collaborator
Author
|
Thanks for your instantaneous reviews! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In spack-stack 1.9.0 and develop, crtm-fix must be excluded when checking for duplicates in the unified environment. That's because there are two versions of crtm included that come with fix files, v2.4 and 3.1.
Testing
Tested manually on NRL machines
Applications affected
None
Systems affected
NRL systems
Dependencies
None
Issue(s) addressed
None
Checklist
All dependency PRs/issues have been resolved and this PR can be merged.