Container image: specify gcc version for gnu toolchain.#1496
Merged
climbfuji merged 4 commits intoJCSDA:developfrom Feb 6, 2025
Merged
Container image: specify gcc version for gnu toolchain.#1496climbfuji merged 4 commits intoJCSDA:developfrom
climbfuji merged 4 commits intoJCSDA:developfrom
Conversation
climbfuji
approved these changes
Feb 6, 2025
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Looks good to me, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change uses Ubuntu's
update-alternativesutility to specify the correct GNU compilers for the gcc container. While spack-stack can build without this due to the compiler config, these definitions assists downstream builders like jedi-bundle.Once submitted to develop, I'll make a PR to cherry pick this into 1.9
Systems affected
JEDI-CI
Testing
The image was rebuilt with this change and jedi-bundle was built successfully.
Checklist