Skip to content

release/1.9.0: Update s4 to use intel oneapi 2024#1475

Merged
climbfuji merged 3 commits intoJCSDA:release/1.9.0from
InnocentSouopgui-NOAA:feature/s4-oneapi2024
Feb 11, 2025
Merged

release/1.9.0: Update s4 to use intel oneapi 2024#1475
climbfuji merged 3 commits intoJCSDA:release/1.9.0from
InnocentSouopgui-NOAA:feature/s4-oneapi2024

Conversation

@InnocentSouopgui-NOAA
Copy link
Copy Markdown
Contributor

Summary

Update S4 configs to use Intel OneApi 2024

Testing

Describe the testing done for this PR.

Applications affected

List all known applications (UFS WM, JEDI, SRW, etc.) intentionally or unintentionally affected by this PR.

Systems affected

S4

Dependencies

If there are PRs that need to be merged before or along with this one, please add "- [ ] waiting on LINK_TO_PR" for each of them

Issue(s) addressed

Link the issues addressed or resolved by this PR (use Fixes #??? for fully resolved issues)

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a sneak peek. If you want to be able to use both, the current Intel Classic and the new oneAPI, split packages.yaml into three files (see, for example, the Nautilus site config): packages.yaml (common stuff), packages_intel.yaml, packages_oneapi.yaml.

@InnocentSouopgui-NOAA
Copy link
Copy Markdown
Contributor Author

Took a sneak peek. If you want to be able to use both, the current Intel Classic and the new oneAPI, split packages.yaml into three files (see, for example, the Nautilus site config): packages.yaml (common stuff), packages_intel.yaml, packages_oneapi.yaml.

Thank you, I will look into Nautilus config and follow it.

@InnocentSouopgui-NOAA
Copy link
Copy Markdown
Contributor Author

What tests should I run to check if the modifications don't break anything?

I installed the unified environment with the change and everything went smoothly.

@climbfuji
Copy link
Copy Markdown
Collaborator

What tests should I run to check if the modifications don't break anything?

I installed the unified environment with the change and everything went smoothly.

JCSDA and EMC are using S4, they should be able to help

@climbfuji climbfuji changed the base branch from develop to release/1.9.0 January 30, 2025 12:26
@climbfuji climbfuji changed the title Update s4 to use intel oneapi 2024 release/1.9.0: Update s4 to use intel oneapi 2024 Jan 30, 2025
@climbfuji
Copy link
Copy Markdown
Collaborator

@InnocentSouopgui-NOAA Since you are only updating the S4 site config, please make sure to run this before pushing branch updates to github.com:

git commit --allow-empty -m "[skip ci]"

Thanks!

@InnocentSouopgui-NOAA
Copy link
Copy Markdown
Contributor Author

@InnocentSouopgui-NOAA Since you are only updating the S4 site config, please make sure to run this before pushing branch updates to github.com:

git commit --allow-empty -m "[skip ci]"

Thanks!

I will make sure of that the next time.

@InnocentSouopgui-NOAA InnocentSouopgui-NOAA marked this pull request as ready for review February 6, 2025 22:41
@climbfuji climbfuji merged commit cd3b472 into JCSDA:release/1.9.0 Feb 11, 2025
@InnocentSouopgui-NOAA InnocentSouopgui-NOAA deleted the feature/s4-oneapi2024 branch March 13, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants