Add new template cylc-dev (and test building in GitHub actions)#1410
Conversation
…e-configs' of https://github.com/climbfuji/spack-stack into feature/unpin_update_common_packages
…eature/unpin_update_common_packages
…eature/unpin_update_common_packages
…eature/unpin_update_common_packages
…eature/unpin_update_common_packages
…eature/unpin_update_common_packages
…template, disable cycl variant in skylab-dev template
…eature/unpin_update_common_packages_PLUS_cylc
…nal curl/openssl, use external qt
…shes with the 'require' block below
…eature/unpin_update_common_packages
…l and pin zstd to 1.5.6
….com/climbfuji/spack-stack into feature/unpin_update_common_packages_PLUS_cylc
…eature/unpin_update_common_packages_PLUS_cylc
|
Note. For ede071b, GitHub actions reports that the tests succeeded, but in fact the build of |
…u self-hosted runner
…eature/unpin_update_common_packages_PLUS_cylc
…ve to spack.yaml directory
080d852 to
3f79cfc
Compare
eap
left a comment
There was a problem hiding this comment.
Thanks for this, based on description I'm still a little puzzled, I thought we were also intending to have a cylc meta module that could be loaded along side of other modules as in our unified dev environment.
I'm approving because this code looks fine and I assume you'll have a good response to my question above.
| spack mirror add local-binary file:///Users/ec2-user/spack-stack/build-cache/ | ||
| spack buildcache update-index local-binary || (echo "No valid binary cache found, proceed without" && spack mirror rm local-binary) | ||
| set +e | ||
| set -e |
There was a problem hiding this comment.
Good catch here and elsewhere.
| require: '@1.7.1 +mpi' | ||
| py-pandas: | ||
| require: '+excel' | ||
| # To avoid duplicate packages |
There was a problem hiding this comment.
Wouldn't the concretizer unify: true prevent duplication?
There was a problem hiding this comment.
It will lead to concretization errors if unify: true is set. Unfortunately, the concretizer isn't perfect, it still has its bugs. But I am happy to move this (numpy and cython) into the cylc-dev template instead of applying it to all environments for now (but new packages that are coming down the road will want the same settings for unified-env/neptune-env, too).
Initially, the idea was to add cylc to the unified-env and other larger environments. But, as we are expanding the use of Python in our environments (more and more packages with complicated dependencies), this is getting harder and harder. Especially |
…ent to use compilers without Cray wrappers for building cylc-env
This is a follow-up for #1410 and provides the necessary information for building and using cylc environments.
Summary
This PR adds a new template
cylc-devto build a special environment for runningcylc. Because of the waycylcworks, this is best accomplished by creating an environment view and then acylcwrapper that contains the minimum settings necessary to usecylcfrom the view'sbindirectory. See cylc/cylc-flow#6532 for more information. Note that the creation of thecylcwrapper is not part of this PR.Associated changes:
cylc-devon the Ubuntu self-hosted runner, excludemesonfrom thespack external findcall. Spack found a deprecated version[email protected]and despite it being deprecated it tried to use it - with the result that theharfbuzzbuild failed (needed forcylc-dev). Letting spack buildmeson(it picks[email protected]) solved the problem.+excelvariant frompy-pandas, which was something thejedi-tools-envused, but that is no longer needed and that caused build errors (and added several more dependencies).set +ewithset -e).py-cython@3and[email protected]qtwithgcc(has no effect on pre-configured sites, whereqtis configured as an external package)Testing
cylc-devtemplate withgccon Ubuntu)cylc-devwithgcc, createdcylcwrapper, tested flow, gui and NEPTUNE workflow)cylc-devwithgcc, createdcylcwrapper, tested flow, gui)cylc-devwithgcc, createdcylcwrapper, tested flow, gui)Applications affected
None
Systems affected
None
Dependencies
Issue(s) addressed
Resolves #1413
Resolves #1444
Checklist