install_test.py: append to install-time test log for multiple test phases (#50477)#569
Merged
climbfuji merged 1 commit intoJCSDA:feature/update_to_spack_v1from Oct 24, 2025
Conversation
…ases (spack#50477) * Append to install-time test log for multiple test phases Signed-off-by: Alex Richert <[email protected]> * log.py: fix tmp dir arg Signed-off-by: Alex Richert <[email protected]> * log.py: fix typo (:) Signed-off-by: Alex Richert <[email protected]> * use existing tests/pkg Signed-off-by: Alex Richert <[email protected]> * remove new test file/pkg Signed-off-by: Alex Richert <[email protected]> * test/cmd/install.py: skip log append check for win32 Signed-off-by: Alex Richert <[email protected]> * test/cmd/install.py: skip install 'tests' for win32 Signed-off-by: Alex Richert <[email protected]> * test/cmd/install.py: fix install test-skip logic (win32) Signed-off-by: Alex Richert <[email protected]> * test/cmd/install.py: skip test_package_output for windows Signed-off-by: Alex Richert <[email protected]> * Revert "test/cmd/install.py: skip test_package_output for windows" This reverts commit f14beed. Signed-off-by: Alex Richert <[email protected]> --------- Signed-off-by: Alex Richert <[email protected]>
climbfuji
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks spack@cdb2edf, which fixes the problem of install-time test logs getting overwritten for MakefilePackage's (so now we can retain 'make test' output for, e.g.,
spack install --test root esmf).