Manual update of ESMF from spack develop 2025/05/07#538
Merged
climbfuji merged 2 commits intoJCSDA:spack-stack-devfrom May 7, 2025
Merged
Conversation
6 tasks
climbfuji
force-pushed
the
feature/manual_update_esmf_from_spack_dev_20250507
branch
from
f84f346 to
2c87f43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To address build errors for the latest ESMF beta snapshot (see, for example, https://github.com/JCSDA/spack-stack/actions/runs/14887254221/job/41810037631?pr=1632), we need to pull in updates from spack develop. Unfortunately, there's been a fair bit of reorganization and PRs that touch many more packages than just ESMF that makes it impossible to do this by cherry-picking.
I therefore hand-picked all applicable differences for the ESMF package. With the exception of the beta snapshots and the new Fortran compiler identification code (requires spack code we do not have yet), the
esmf/package.pyhere is identical to the version in spack develop as of 2025/05/07.This is needed for JCSDA/spack-stack#1632 as a follow-up to #537.