Skip to content

release/1.9.0: Fix bug in awcli-v2, add upper bound for py-cryptography#511

Merged
climbfuji merged 1 commit intoJCSDA:release/1.9.0from
climbfuji:bugfix/awscliv2_crytography
Jan 31, 2025
Merged

release/1.9.0: Fix bug in awcli-v2, add upper bound for py-cryptography#511
climbfuji merged 1 commit intoJCSDA:release/1.9.0from
climbfuji:bugfix/awscliv2_crytography

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented Jan 31, 2025 •
edited
Loading

In var/spack/repos/builtin/packages/awscli-v2/package.py, add back in upper bound for py-cryptography. This matches the logic of awscli-v2 in spack develop, see: https://github.com/spack/spack/blame/e1b579a8b491b01579a24e18e520c27e7089f24f/var/spack/repos/builtin/packages/awscli-v2/package.py#L29C9-L29C66.

We don't need to worry about Python 3.12 for this version 2.15 of awscli-v2 anyway, NS newer versions of awscli-v2 will be available in the next release when we pull in spack develop, opening the door to move to Python 3.12 if we want to.

This fixes the following bug reported by @xian22:

(venv) christian@boxie:~$ create_experiment.py skylab/experiments/gfs-3dfgat-c12.yaml --no-submit
/home/christian/skylab/skylabCDA/venv/bin/create_experiment.py:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
  __import__('pkg_resources').require('ewok==0.8.0')
Traceback (most recent call last):
  File "/home/christian/spack-stack-1.9.0/envs/unified-env.mylinux/install/gcc/12.2.0/py-setuptools-69.2.0-rv2nvbs/lib/python3.11/site-packages/pkg_resources/__init__.py", line 600, in _build_master
    ws.require(__requires__)
  File "/home/christian/spack-stack-1.9.0/envs/unified-env.mylinux/install/gcc/12.2.0/py-setuptools-69.2.0-rv2nvbs/lib/python3.11/site-packages/pkg_resources/__init__.py", line 937, in require
    needed = self.resolve(parse_requirements(requirements))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/christian/spack-stack-1.9.0/envs/unified-env.mylinux/install/gcc/12.2.0/py-setuptools-69.2.0-rv2nvbs/lib/python3.11/site-packages/pkg_resources/__init__.py", line 798, in resolve
    dist = self._resolve_dist(
           ^^^^^^^^^^^^^^^^^^^
  File "/home/christian/spack-stack-1.9.0/envs/unified-env.mylinux/install/gcc/12.2.0/py-setuptools-69.2.0-rv2nvbs/lib/python3.11/site-packages/pkg_resources/__init__.py", line 844, in _resolve_dist
    raise VersionConflict(dist, req).with_context(dependent_req)
pkg_resources.ContextualVersionConflict: (cryptography 42.0.8 (/home/christian/spack-stack-1.9.0/envs/unified-env.mylinux/install/gcc/12.2.0/py-cryptography-42.0.8-7s5dqkl/lib/python3.11/site-packages), Requirement.parse('cryptography<40.0.2,>=3.3.2'), {'awscli'})

@climbfuji climbfuji self-assigned this Jan 31, 2025
@climbfuji climbfuji mentioned this pull request Jan 31, 2025
Merged
6 tasks
xian22
xian22 approved these changes Jan 31, 2025
View reviewed changes
Copy link
Copy Markdown

@xian22 xian22 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built spack-stack with this change and tested with local a skylab and all seems to work. Thanks!

@climbfuji climbfuji mentioned this pull request Jan 31, 2025
Closed
@climbfuji climbfuji merged commit d042c2e into JCSDA:release/1.9.0 Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderRichert-NOAA AlexanderRichert-NOAA AlexanderRichert-NOAA approved these changes

+1 more reviewer

@xian22 xian22 xian22 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@climbfuji climbfuji

Labels

None yet

Projects

No open projects
spack-stack-1.9.x (2024 Q4 - 2025 Q3)
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@climbfuji @xian22 @AlexanderRichert-NOAA