Skip to content

mapl: add v2.53.0 (#48712)#507

Merged
climbfuji merged 7 commits intoJCSDA:spack-stack-devfrom
climbfuji:feature/mapl2503_spstdev
Jan 27, 2025
Merged

mapl: add v2.53.0 (#48712)#507
climbfuji merged 7 commits intoJCSDA:spack-stack-devfrom
climbfuji:feature/mapl2503_spstdev

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented Jan 24, 2025

Add [email protected] through 2.53.0 (cherry-picked from spack develop). For testing, see JCSDA/spack-stack#1470

@climbfuji climbfuji requested a review from mathomp4 January 24, 2025 20:41
@climbfuji climbfuji marked this pull request as ready for review January 24, 2025 20:41
@mathomp4
Copy link
Copy Markdown
Collaborator

mathomp4 commented Jan 24, 2025

Oh wait. Unapprove! I think you are missing some updates later down in the package. Like:

    resource(
        name="esma_cmake",
        git="https://github.com/GEOS-ESM/ESMA_cmake.git",
        tag="v3.55.0",
        when="@2.51:",
    )
    resource(
        name="esma_cmake",
        git="https://github.com/GEOS-ESM/ESMA_cmake.git",
        tag="v3.51.0",
        when="@2.48:2.50",
    )
...

    depends_on("[email protected]:", type="build", when="@2.51:")
    depends_on("[email protected]:", type="build", when="@2.50")

You might want to compare the whole file.

@climbfuji
Copy link
Copy Markdown
Collaborator Author

ok, thanks. I will add the missing commits

@climbfuji climbfuji requested a review from mathomp4 January 24, 2025 23:08
@climbfuji climbfuji merged commit c17cb31 into JCSDA:spack-stack-dev Jan 27, 2025
@climbfuji climbfuji deleted the feature/mapl2503_spstdev branch January 27, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

2 participants