Merge py-pandas, py-awscrt, texinfo, and ectrans bug fixes from release/1.5.1 (with mods from spack develop)#346
Merged
climbfuji merged 17 commits intoJCSDA:jcsda_emc_spack_stackfrom Oct 18, 2023
Conversation
Co-authored-by: Adam J. Stewart <[email protected]>
…into feature/merge_openpyxl_etc_from_release_151
6 tasks
climbfuji
requested review from
AlexanderRichert-NOAA,
natalie-perlin,
srherbener and
ulmononian
…into feature/merge_openpyxl_etc_from_release_151
srherbener
approved these changes
Oct 18, 2023
Collaborator
srherbener
left a comment
srherbener
left a comment
There was a problem hiding this comment.
Thanks for bringing these in to the jcsda_emc_spack_stack (development) branch!
AlexanderRichert-NOAA
approved these changes
Oct 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cherry-picks bug fixes from the
release/1.5.1branch (PRs #342 and #339). On top of these are rather extensive changes for thepy-pandas/py-openpyxlbug fix that come from spackdevelop.(Background: I created PRs for spack
developbased on the commits forrelease/1.5.1, these received feedback and got updated - improved! - rather significantly: spack#40469, spack#40470, spack#40472). I pulled in the original commits forrelease/1.5.1first, then added the spack develop PRs on top (cherry-picking made sure there were no merge conflicts), and that's what you are seeing here.Issue(s) addressed
All issues were resolved when merging the updates into
release/1.5.1, this is just bringing the improved and spack-sanctioned versions intojcsda_emc_spack_stack.The changes in this PR are tested with JCSDA/spack-stack#831
Dependencies
n/a
Impact
n/a
Checklist
I have made corresponding changes to the documentation