Bug fix for py-awscrt on Linux (use spack openssl/libcrypto)#339
Merged
climbfuji merged 1 commit intoJCSDA:jcsda_emc_spack_stackfrom Oct 6, 2023
Merged
Conversation
…Linux, tell aws-crt-python to use libcrypto from spack (openssl)
5 tasks
srherbener
approved these changes
Oct 6, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a tiny bug fix for
py-awscrton Linux. We need to tell the pip builder to use use libcrypto from spack (art of openssl, whether that is an internal or external package doesn't matter). This doesn't apply to macOS or Windows, see https://github.com/awslabs/aws-crt-python/blob/main/README.md.Issue(s) addressed
Currently,
awscli-v2doesn't build on Linux due to missing symbols fromlibcryptoinpy-awscrt's Python extension.Dependencies
n/a
Impact
n/a
Checklist
py-awscrtandawscli-v2on the Ubuntu CI system, no build errors forpy-awscli-v2. Ranaws s3 lsto make sure the utility works.