Add/use BUILD_TESTING and FIX_FILE_PATH to CMake config#213
Merged
chengdang merged 3 commits intoJCSDA:developfrom Mar 16, 2025
Merged
Add/use BUILD_TESTING and FIX_FILE_PATH to CMake config#213chengdang merged 3 commits intoJCSDA:developfrom
chengdang merged 3 commits intoJCSDA:developfrom
Conversation
00ba877 to
2ed2a05
Compare
Contributor
Author
|
@BenjaminTJohnson I can't add reviewers but this is good to go. If you're into it, I also added a CMake option for specifying an existing fix dir, and resurrected what appears to be some defunct logic for setting it through an environment variable. |
BenjaminTJohnson
approved these changes
Mar 15, 2025
chengdang
approved these changes
Mar 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Issue(s) addressed
Fixes #211
Dependencies
none
Impact
No expected impact to current CMake behavior. Will facilitate customizing CMake behavior in spack-stack.
Checklist