Skip to content

Add/use BUILD_TESTING and FIX_FILE_PATH to CMake config#213

Merged
chengdang merged 3 commits intoJCSDA:developfrom
AlexanderRichert-NOAA:cmake_updates_mar25
Mar 16, 2025
Merged

Add/use BUILD_TESTING and FIX_FILE_PATH to CMake config#213
chengdang merged 3 commits intoJCSDA:developfrom
AlexanderRichert-NOAA:cmake_updates_mar25

Conversation

@AlexanderRichert-NOAA
Copy link
Copy Markdown
Contributor

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented Mar 13, 2025

Description

This PR:

  • makes build testing optional using the CTest standard BUILD_TESTING variable, and
  • adds an option to point to an existing fix files installation (default is current behavior).

Issue(s) addressed

Fixes #211

Dependencies

none

Impact

No expected impact to current CMake behavior. Will facilitate customizing CMake behavior in spack-stack.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have run the unit tests before creating the PR (186/186 tests passing)

@AlexanderRichert-NOAA AlexanderRichert-NOAA changed the title Cmake updates mar25 Add/use BUILD_TESTING and FIX_FILE_PATH to CMake config Mar 13, 2025
@AlexanderRichert-NOAA AlexanderRichert-NOAA marked this pull request as draft March 13, 2025 18:09
@AlexanderRichert-NOAA AlexanderRichert-NOAA marked this pull request as ready for review March 13, 2025 18:41
@AlexanderRichert-NOAA
Copy link
Copy Markdown
Contributor Author

@BenjaminTJohnson I can't add reviewers but this is good to go. If you're into it, I also added a CMake option for specifying an existing fix dir, and resurrected what appears to be some defunct logic for setting it through an environment variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use BUILD_TESTING to switch testing on/off?

3 participants