Replace system tar command with cmake built-in tar function#196
Merged
BenjaminTJohnson merged 2 commits intodevelopfrom Jan 23, 2025
Merged
Replace system tar command with cmake built-in tar function#196BenjaminTJohnson merged 2 commits intodevelopfrom
BenjaminTJohnson merged 2 commits intodevelopfrom
Conversation
climbfuji
approved these changes
Jan 15, 2025
| if(NOT EXISTS ${UNTAR_DEST}/${CRTM_COEFFS_BRANCH}/) | ||
| message(STATUS "Untarring the downloaded file (~2 minutes) to ${UNTAR_DEST}") | ||
| execute_process(COMMAND tar -xzf ${DOWNLOAD_DEST} -C ${UNTAR_DEST} | ||
| execute_process(COMMAND ${CMAKE_COMMAND} -E chdir ${UNTAR_DEST} |
Contributor
There was a problem hiding this comment.
I would add at comment there, at least a line pointing to the issue
# https://....
Contributor
Author
There was a problem hiding this comment.
I've added a comment that includes the URL to the spack-stack issue.
BenjaminTJohnson
approved these changes
Jan 16, 2025
fmahebert
approved these changes
Jan 22, 2025
Contributor
fmahebert
left a comment
fmahebert
left a comment
There was a problem hiding this comment.
I did not go test this, but this looks reasonable. Thanks for this workaround!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the CRTM test CMake configuration to use the builtin cmake tar feature instead of the system tar command to unpack the downloaded test files. This change is desired to work around an issue with the latest spack-stack Intel build on Orion as described in: JCSDA/spack-stack/issues/1355.
Issue(s) addressed
Resolves JCSDA/spack-stack/issues/1355
Dependencies
List the other PRs that this PR is dependent on:
None
Impact
Expected impact on downstream repositories:
None - this is a cmake configuration only change which uses a different means for upacking a downloaded tar file.
Checklist