Date picker and time picker color by theme by oguzsout · Pull Request #3558 · Ivy-Apps/ivy-wallet

oguzsout · 2024-09-23T17:20:27Z

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

I've read the Contribution Guidelines and my PR doesn't break the rules.
I've read and understand the Developer Guidelines.
I confirm that I've run the code locally and everything works as expected.
My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Description

Opened this pr on this issue, which is related to the theme problem of date and time pickers.

What's changed?

I've fixed colors of dialogs
I have wrapped it with the proper theme for these colours to work properly

Before	After

Risk factors

...

Does this PR close any GitHub issues? (do not delete)

Closes [BUG] Date & Time are white in dark team #3465

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

ILIYANGERMANOV

Fix the CI and I'll review, in the meantime let our contributors review 🙏

ILIYANGERMANOV

Left some comments above

oguzsout · 2024-09-24T08:30:16Z

Fix the CI and I'll review, in the meantime let our contributors review 🙏

you want me to do a reformat for detekt? When I do this, more than 200 files appear :) Even if I edit where I made the changes it still gives error.

ILIYANGERMANOV · 2024-09-24T08:32:59Z

Fix the CI and I'll review, in the meantime let our contributors review 🙏

you want me to do a reformat for detekt? When I do this, more than 200 files appear :) Even if I edit where I made the changes it still gives error.

Read this https://github.com/Ivy-Apps/ivy-wallet/blob/main/docs/CI-Troubleshooting.md
It shouldn't be 200 errors, only errors in the files that you've changed. You can suppress them or if that's too hard add a baseline (the Gradle task might be broken)

shamim-emon · 2024-09-24T09:51:41Z

Fix the CI and I'll review, in the meantime let our contributors review 🙏

you want me to do a reformat for detekt? When I do this, more than 200 files appear :) Even if I edit where I made the changes it still gives error.

@oguzsout I can fix the detekt issues if you want.

oguzsout · 2024-09-24T10:52:01Z

Fix the CI and I'll review, in the meantime let our contributors review 🙏

you want me to do a reformat for detekt? When I do this, more than 200 files appear :) Even if I edit where I made the changes it still gives error.

Read this https://github.com/Ivy-Apps/ivy-wallet/blob/main/docs/CI-Troubleshooting.md It shouldn't be 200 errors, only errors in the files that you've changed. You can suppress them or if that's too hard add a baseline (the Gradle task might be broken)

Yes, I forgot to check here, I will review it again and make the change 🙏

oguzsout · 2024-09-24T10:53:26Z

Fix the CI and I'll review, in the meantime let our contributors review 🙏

you want me to do a reformat for detekt? When I do this, more than 200 files appear :) Even if I edit where I made the changes it still gives error.

@oguzsout I can fix the detekt issues if you want.

Thank you very much @shamim-emon , I'm on it now. I'll write to you if I get stuck 🙃

ivywallet · 2024-09-24T10:54:16Z

⚠️ Hey @oguzsout, this issue is not approved, yet.
@ILIYANGERMANOV must approve it first.

Also, make sure to read our Contribution Guidelines.

oguzsout · 2024-09-24T11:36:07Z

Since the number of lines of the onCreate method exceeds the restriction specified in rule Detekt, I created the setupApp function. I opened and tested the App and it did not cause any problems. @ILIYANGERMANOV @shamim-emon

ILIYANGERMANOV · 2024-09-24T11:50:06Z

Since the number of lines of the onCreate method exceeds the restriction specified in rule Detekt, I created the setupApp function. I opened and tested the App and it did not cause any problems. @ILIYANGERMANOV @shamim-emon

Sounds good. If the Detekt error is in legacy code, feel free to suppres using an annotation

shamim-emon

@oguzsout your PR description is missing the section where you have to mention which issue is this PR closing. For reference adding a screenshot below

oguzsout · 2024-09-25T09:16:37Z

@oguzsout your PR description is missing the section where you have to mention which issue is this PR closing. For reference adding a screenshot below

Actually, I opened this pr for the following issue

shamim-emon · 2024-09-25T09:31:31Z

@oguzsout your PR description is missing the section where you have to mention which issue is this PR closing. For reference adding a screenshot below

Actually, I opened this pr for the following issue

Yeah and you have to add the issue in PR description like how I had added in provided screenshot.

ILIYANGERMANOV · 2024-09-25T09:53:59Z

@oguzsout the issue that you're working on isn't assigned to you. Did you read the contributor guidelines? Lucky for you the assignee haven't completed it in 3 weeks

ILIYANGERMANOV · 2024-09-25T09:54:40Z

@oguzsout read the Contribution Guidelines and assign it to yourself

ILIYANGERMANOV · 2024-09-25T09:55:06Z

To fix the PR description check you need to push a commit unfortunately

ILIYANGERMANOV

Found an issue with edge-to-edge

oguzsout · 2024-09-25T10:01:55Z

@oguzsout the issue that you're working on isn't assigned to you. Did you read the contributor guidelines? Lucky for you the assignee haven't completed it in 3 weeks

Since that person didn't do it, I wanted to do it, but I couldn't take it upon myself.

ILIYANGERMANOV · 2024-09-25T10:03:24Z

@oguzsout the issue that you're working on isn't assigned to you. Did you read the contributor guidelines? Lucky for you the assignee haven't completed it in 3 weeks

Since that person didn't do it, I wanted to do it, but I couldn't take it upon myself.

In that case, you need to ping me to unassign and then you can take it. We should probably add CI automation for unassigning, as well

ILIYANGERMANOV

LGTM! Ping me to merge it after the CI pass 🚀

oguzsout added 2 commits September 23, 2024 20:14

Fix legacy and m3 theme arrangement for pickers

5c45f05

Add new color for pickers with the theme

cddf554

oguzsout requested a review from ILIYANGERMANOV as a code owner September 23, 2024 17:20

Fix condition of theme value

2c5bda2

ILIYANGERMANOV requested a review from a team September 23, 2024 19:05

ILIYANGERMANOV reviewed Sep 23, 2024

View reviewed changes

Comment thread app/src/main/java/com/ivy/wallet/RootActivity.kt Outdated

ILIYANGERMANOV suggested changes Sep 23, 2024

View reviewed changes

ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Sep 23, 2024

ILIYANGERMANOV reviewed Sep 23, 2024

View reviewed changes

Comment thread app/src/main/java/com/ivy/wallet/RootActivity.kt Outdated

Fix theme wrapper

64874fe

ILIYANGERMANOV requested review from paulolima18 and shamim-emon September 24, 2024 11:50

shamim-emon reviewed Sep 25, 2024

View reviewed changes

ILIYANGERMANOV suggested changes Sep 25, 2024

View reviewed changes

Comment thread app/src/main/java/com/ivy/wallet/RootActivity.kt Outdated

Comment thread shared/ui/core/src/main/java/com/ivy/ui/time/impl/AndroidDateTimePicker.kt Outdated

Fix issue of edge to edge

8ce8559

Fix scrolling down color line

0cc6bfa

ILIYANGERMANOV approved these changes Sep 25, 2024

View reviewed changes

ILIYANGERMANOV added ready to merge 🚀 PR can be merged after the CI pass and removed requested changes Changes are needed. Please, apply them labels Sep 25, 2024

ILIYANGERMANOV merged commit 4aec53f into Ivy-Apps:main Sep 25, 2024

Conversation

oguzsout commented Sep 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request (PR) checklist

Description

What's changed?

Risk factors

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Uh oh!

ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

oguzsout commented Sep 24, 2024

Uh oh!

ILIYANGERMANOV commented Sep 24, 2024

Uh oh!

shamim-emon commented Sep 24, 2024

Uh oh!

oguzsout commented Sep 24, 2024

Uh oh!

oguzsout commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ivywallet commented Sep 24, 2024

Uh oh!

oguzsout commented Sep 24, 2024

Uh oh!

ILIYANGERMANOV commented Sep 24, 2024

Uh oh!

shamim-emon left a comment

Choose a reason for hiding this comment

Uh oh!

oguzsout commented Sep 25, 2024

Uh oh!

shamim-emon commented Sep 25, 2024

Uh oh!

ILIYANGERMANOV commented Sep 25, 2024

Uh oh!

ILIYANGERMANOV commented Sep 25, 2024

Uh oh!

ILIYANGERMANOV commented Sep 25, 2024

Uh oh!

ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

oguzsout commented Sep 25, 2024

Uh oh!

ILIYANGERMANOV commented Sep 25, 2024

Uh oh!

ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oguzsout commented Sep 23, 2024 •

edited

Loading

oguzsout commented Sep 24, 2024 •

edited

Loading