This repository was archived by the owner on Apr 11, 2026. It is now read-only.
Tabular Loan UI added#3539
Merged
ILIYANGERMANOV merged 15 commits intoIvy-Apps:mainfrom Sep 18, 2024
Merged
Conversation
Member
|
@shamim-emon replace the red color with purple. Red means error. I'll review the code later today or tmrw |
ILIYANGERMANOV
suggested changes
Sep 17, 2024
Member
ILIYANGERMANOV
left a comment
ILIYANGERMANOV
left a comment
There was a problem hiding this comment.
Didn't review much in detail but overall LGTM! Left some comments
ILIYANGERMANOV
added
the
requested changes
ILIYANGERMANOV
requested review from
a team,
Vishwa-Raghavendra,
akashs056 and
code-a1
suyash01
reviewed
Sep 17, 2024
Member
@suyash01 thank you for reviewing! I'm planning to delegate reviewers to contributors so our project is even more community-driven |
shamim-emon
force-pushed
the
fix-issue-3490
branch
from
1f1528b to
bbcb263
Compare
ILIYANGERMANOV
approved these changes
Sep 18, 2024
1 task
nvllz
reviewed
Sep 20, 2024
| } | ||
|
|
||
| private fun loadCompletedLoans() { | ||
| completedLoans = allLoans.filter { loan -> loan.percentPaid == 1.0 }.toImmutableList() |
Contributor
There was a problem hiding this comment.
@shamim-emon could you replace == with >= to patch #3546?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request (PR) checklist
Please check if your pull request fulfills the following requirements:
Screen recording of your changes (if applicable):
video.mp4
What's changed?
Describe with a few bullets what's new:
Risk factors
What may go wrong if we merge your PR?
In what cases won't your code work?
Does this PR close any GitHub issues? (do not delete)
Troubleshooting GitHub Actions (CI) failures ❌
Pull request checks failing? Read our CI Troubleshooting guide.