Skip to content
This repository was archived by the owner on Apr 11, 2026. It is now read-only.

BottomBar added on Exchange Rates Screen#3508

Merged
ILIYANGERMANOV merged 2 commits intoIvy-Apps:mainfrom
shamim-emon:fix-issue-3504
Sep 15, 2024
Merged

BottomBar added on Exchange Rates Screen#3508
ILIYANGERMANOV merged 2 commits intoIvy-Apps:mainfrom
shamim-emon:fix-issue-3504

Conversation

@shamim-emon
Copy link
Copy Markdown
Contributor

@shamim-emon shamim-emon commented Sep 14, 2024

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

What's changed?

  • I've added Bottom bar (having navigation back button) on Exchange Rates screen

Before(Left) | After(Right)

Dark
light

What may go wrong if we merge your PR?

  • N/A

In what cases won't your code work?

  • N/A

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

Comment thread shared/ui/core/src/main/res/values-bg/strings.xml Outdated
@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Sep 14, 2024
@ILIYANGERMANOV ILIYANGERMANOV merged commit 16bd614 into Ivy-Apps:main Sep 15, 2024
@shamim-emon shamim-emon deleted the fix-issue-3504 branch September 16, 2024 01:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

requested changes Changes are needed. Please, apply them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Navigation Back Button In Exchange Rates

2 participants