This repository was archived by the owner on Apr 11, 2026. It is now read-only.
[Domain] Build AccountBalanceUseCase#3418
Merged
ILIYANGERMANOV merged 29 commits intoIvy-Apps:mainfrom Aug 26, 2024
Merged
Conversation
rodrigoliveirac
changed the title
ILIYANGERMANOV
suggested changes
Aug 21, 2024
Member
ILIYANGERMANOV
left a comment
ILIYANGERMANOV
left a comment
There was a problem hiding this comment.
Found some issues with the logic + crashes. The code can be also be simplified a bit
ILIYANGERMANOV
added
the
requested changes
Member
|
Hey @rodrigoliveirac sorry for all the comments and nitpicking! It's just a core API that we'll use a lot and I want us to make it as simple and elegant as possible 🙌 Btw, great progress - I like the new builder + naming! |
Contributor
Author
No need to apologize! I definitely understand the importance of that. I'm enjoying the opportunity to grow with this. Thank you for all! |
…comes and transfersIn
…comes and one transfersIn
rodrigoliveirac
force-pushed
the
fix-issue-3143
branch
from
109f614 to
8153110
Compare
ILIYANGERMANOV
approved these changes
Aug 26, 2024
Member
ILIYANGERMANOV
left a comment
ILIYANGERMANOV
left a comment
There was a problem hiding this comment.
@rodrigoliveirac let's merge this one and you can build on top of it in a follow-up PR 🚀
Contributor
Author
Ok, I'll still be working in the same branch for that 👊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request (PR) checklist
Please check if your pull request fulfills the following requirements:
What's changed?
Describe with a few bullets what's new:
Does this PR close any GitHub issues? (do not delete)
AccountBalanceUseCase#3143Troubleshooting GitHub Actions (CI) failures ❌
Pull request checks failing? Read our CI Troubleshooting guide.