Supporting SF Symbols identifiers for script icons#273
Merged
IvanMathy merged 1 commit intoIvanMathy:mainfrom Aug 10, 2021
Merged
Supporting SF Symbols identifiers for script icons#273IvanMathy merged 1 commit intoIvanMathy:mainfrom
IvanMathy merged 1 commit intoIvanMathy:mainfrom
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Author
|
The automatic build on bitrise fails because it's using Xcode 11.7; the |
Owner
|
Well, this is ridiculously cool. Thanks for the PR! I updated the CI system's Xcode version so it'll build okay now 👍 |
|
Dlaczego to jest tylko do Apple App Store? Ja chcę do Microsoft Lumia lub Surface. Nigdy mnie nikt nie namówi do przesiadki na Android lub Apple. Mam wiarygodne informacje których nie mogę publicznie udostępnić. Android i Apple działają wspólnie na nie korzyść dla firmy Microsoft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a small change that also supports SF Symbols identifiers as script icon names:
NSImage(systemSymbolName:accessibilityDescription:)(only on macOS 11+).nilicons8-unknown, just as it does previouslyI did not change the
.lowercased()in the initialisation of Script since SF Symbols also uses lowercase-only identifiers.The documentation has been updated appropriately.
Overview of the new functionality
Specifiying an SF Symbol name in a script
Selection