Skip to content

Comments

Add Auto-Connect and Hide on-startup feature#167

Merged
InvisibleManVPN merged 13 commits intodevelopfrom
feature/auto-connect-and-hide-on-startup
Jan 4, 2025
Merged

Add Auto-Connect and Hide on-startup feature#167
InvisibleManVPN merged 13 commits intodevelopfrom
feature/auto-connect-and-hide-on-startup

Conversation

@InvisibleManVPN
Copy link
Owner

No description provided.

@InvisibleManVPN InvisibleManVPN force-pushed the feature/auto-connect-and-hide-on-startup branch from 54c7ddb to 4749916 Compare January 4, 2025 11:15
@InvisibleManVPN InvisibleManVPN merged commit b5eba70 into develop Jan 4, 2025
@InvisibleManVPN InvisibleManVPN deleted the feature/auto-connect-and-hide-on-startup branch January 4, 2025 11:19
@InvisibleManVPN
Copy link
Owner Author

Many thanks @Lurker00 for contributing. This PR will resolves #121 and #122

@Lurker00
Copy link
Contributor

Lurker00 commented Jan 4, 2025

@InvisibleManVPN It seems your refactoring has lost the intentional behavior: don't hide the window if the auto-connection failed. I can be mistaken but I'm far from my home now, can't build and test myself. In the tests of my code, I found it useful to avoid message boxes during auto-connect, but keep the window visible to bring the attention that auto-start failed.

@InvisibleManVPN
Copy link
Owner Author

@Lurker00 Good idea. Let me check. Thanks for mentioning

@InvisibleManVPN
Copy link
Owner Author

@Lurker00 Fixed right now (commit: 460ae4a)
I prefer to also show the error message. In this case, users will notified why the app isn't hidden on startup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants