You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 6b81a83
Browse filesBrowse the repository at this point in the historyBrowse files
fix(client): web runs skwasm single-threaded until Flutter fixes its FreeType race (Refs #808, #910)
Multi-threaded skwasm on Flutter 3.47.0 makes its FreeType lock a no-op, so
text layout on the main thread races glyph drawing on the raster worker
(flutter/flutter#193439; fix PR flutter/flutter#193801 unmerged). Fast Field
zoom froze 7 of 8 local runs multi-threaded and 0 of 3 single-threaded.
The build hook now passes forceSingleThreadedSkwasm:true in the loader
config (kForceSingleThreadedSkwasm). COOP/COEP stay on, so going back is a
one-line change. scripts/check_skwasm_single_thread.sh (run by client-gates,
never failing) warns when the pinned Flutter version moves past 3.47.0 or the
upstream fix merges; AGENTS.md, the Flutter version pins, the Caddyfile and
the zoom-path code point at it so the next Flutter upgrade re-tests
multi-threaded skwasm. Client 7.60.11.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Copy file name to clipboardExpand all lines: AGENTS.md
+1Lines changed: 1 addition & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -36,6 +36,7 @@ plugin). See `DEVELOPMENT.md` and `DEV_GUIDELINES.md`.
36
36
-**No golden tests.** Golden/pixel-comparison tests are disabled project-wide — never write, update or restore them, even if a bead's acceptance criteria ask; use structural widget tests instead. See `.cursor/rules/no-golden-tests.mdc`.
37
37
-**Rooms are General-only — there are no item threads, with one named exception: Request Questions.** Code mentioning `thread_item_id` / `threadItemId` / `_canAccessThread` / item participants is dormant machinery kept on purpose (marked `DORMANT(item-threads)`); the DB guard `beacon_room_message_general_only_guard` rejects every non-General row except a Request's own **Questions** scope (internally the lobby: `coordination_item` kind 7, D1/#526). Questions access is the one server policy `questions_access_levels` (m0254) — never re-implement it, and never let a General-only feature reference a Questions message (DB guard `reject_questions_message_reference`). Never design other features, access rules or reviews around item threads. See #192 and `docs/features/beacon_questions.md`.
38
38
-**Web cache-buster must ship with every client version bump:**`packages/client/web/index.html`'s `flutter_bootstrap.js?v=<version>` query is a real, git-tracked source file (unlike `web/manifest.json`, which is deliberately `skip-worktree` and never needs committing) — it only gets rewritten to match `pubspec.yaml` when you actually run/build the app locally (`flutter run`/`flutter build web`; the `hook/build.dart` build hook does it, not `build_runner`). Before committing a version bump, run the app once and check `git status` for a resulting `web/index.html` diff, or hand-verify the `?v=` matches. A missed bump here means browsers keep serving a cached pre-fix JS bundle after a real fix ships — this has happened before (`git log -- packages/client/web/index.html` shows recurring catch-up `chore: sync web cache-buster` commits) and once made a landed bug fix look like it "didn't work."
39
+
-**Upgrading Flutter re-opens #808:** the web build forces single-threaded skwasm (`kForceSingleThreadedSkwasm`, `packages/client/hook/build/versioned_web_assets.dart`) to dodge an upstream FreeType race on 3.47.0. After any Flutter version change, run `bash scripts/check_skwasm_single_thread.sh` and follow the comment on that constant to re-test multi-threaded skwasm.
0 commit comments