Skip to content

Comments

Label bracketsio for replacing adobebrackets#906

Merged
scriptingosx merged 5 commits intoInstallomator:mainfrom
wakco:Label-bracketsio-replacing-adobebrackets
May 26, 2023
Merged

Label bracketsio for replacing adobebrackets#906
scriptingosx merged 5 commits intoInstallomator:mainfrom
wakco:Label-bracketsio-replacing-adobebrackets

Conversation

@wakco
Copy link
Contributor

@wakco wakco commented Feb 22, 2023

Adobe stopped developing Brackets a year or two ago, brackets.io has continued development.

wakco added 2 commits February 17, 2023 16:31
@wakco
Create brackets.sh
3e26e94 
Adobe Brackets has been discontinued, however brackets.io has continued its development.
@wakco
Update and rename brackets.sh to bracketsio.sh
ec1f535 
Fixed filename to reflect new developer
@scriptingosx scriptingosx added the application adds or improves an application label label Feb 22, 2023
@scriptingosx scriptingosx added this to the v10.4 milestone Feb 22, 2023
@scriptingosx scriptingosx added bug Something isn't working waiting for response labels Feb 22, 2023
@scriptingosx scriptingosx removed this from the v10.4 milestone Feb 22, 2023
@scriptingosx
Copy link
Collaborator

scriptingosx commented Feb 22, 2023

The change like this will break any Installomator workflows that use the existing brackets label.

Is there a reason for this?

@wakco
Copy link
Contributor Author

wakco commented Feb 22, 2023

I don't see how, the existing label for the discontinued Adobe version of Brackets is adobebrackets (in adobebrackets.sh), I checked that before I created this. And the only reason I didn't leave my file called brackets.sh was because the Adobe one wasn't (which you will note is what I originally called it), the current name reflects the website brackets.io.

@scriptingosx
Copy link
Collaborator

scriptingosx commented Feb 23, 2023

ah, it was that renaming of the file that confused me. The misunderstanding was all mine. All good!

@scriptingosx scriptingosx added this to the v10.4 milestone Feb 23, 2023
@Theile
Copy link
Collaborator

Theile commented Feb 23, 2023

Should we include the name of the old label in this label, then?

@scriptingosx
Copy link
Collaborator

scriptingosx commented Feb 23, 2023

should we remove adobebrackets or redirect adobebrackets to be the same as bracketsio?

Is that what you are asking @Theile ?

@Theile
Copy link
Collaborator

Theile commented Feb 24, 2023

Redirect adobebrackets, but I have no clue if we break something, but if the old software is not updated, we wouldn't need it in our list either, I guess.

@scriptingosx scriptingosx removed waiting for response bug Something isn't working labels Feb 24, 2023
wakco added 2 commits March 3, 2023 00:00
@wakco
Update bracketsio.sh
2fcfab2 
Redirecting adobebrackets, per @Theile
@wakco
Disabling adobebrackets.sh
3cfb277 
Disabling the original file to allow adobebrackets to be redirected in bracketsio.sh
@wakco
Copy link
Contributor Author

wakco commented Mar 2, 2023

Redirect adobebrackets, but I have no clue if we break something, but if the old software is not updated, we wouldn't need it in our list either, I guess.

Done as requested.

scriptingosx
scriptingosx reviewed Apr 12, 2023
View reviewed changes
fragments/labels/bracketsio.sh Outdated
@@ -0,0 +1,7 @@
adobebrackets|bracketsio)
Copy link
Collaborator

@scriptingosx scriptingosx Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change this to be in two lines:

adobebrackets|
bracketsio)

the other format breaks the algorithm to list the labels...

Copy link
Contributor Author

@wakco wakco Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, any suggestions on how to resolve the windows only update issue?

@scriptingosx
Copy link
Collaborator

scriptingosx commented Apr 12, 2023

running it right now returns an error:

2023-04-12 09:00:35 : REQ   : bracketsio : ################## Start Installomator v. 10.4beta, date 2023-04-12
2023-04-12 09:00:35 : INFO  : bracketsio : ################## Version: 10.4beta
2023-04-12 09:00:35 : INFO  : bracketsio : ################## Date: 2023-04-12
2023-04-12 09:00:35 : INFO  : bracketsio : ################## bracketsio
2023-04-12 09:00:35 : DEBUG : bracketsio : DEBUG mode 1 enabled.
2023-04-12 09:00:38 : DEBUG : bracketsio : name=Brackets
2023-04-12 09:00:38 : DEBUG : bracketsio : appName=
2023-04-12 09:00:38 : DEBUG : bracketsio : type=dmg
2023-04-12 09:00:38 : DEBUG : bracketsio : archiveName=
2023-04-12 09:00:38 : DEBUG : bracketsio : downloadURL=2023-04-12 09:00:36 : INFO  : bracketsio : GitHub API not returning URL, trying https://github.com/brackets-cont/brackets/releases/latest.
2023-04-12 09:00:38 : DEBUG : bracketsio : https://github.com
2023-04-12 09:00:38 : DEBUG : bracketsio : curlOptions=
2023-04-12 09:00:38 : DEBUG : bracketsio : appNewVersion=2.2.1
2023-04-12 09:00:38 : DEBUG : bracketsio : appCustomVersion function: Not defined
2023-04-12 09:00:38 : DEBUG : bracketsio : versionKey=CFBundleShortVersionString
2023-04-12 09:00:38 : DEBUG : bracketsio : packageID=
2023-04-12 09:00:38 : DEBUG : bracketsio : pkgName=
2023-04-12 09:00:38 : DEBUG : bracketsio : choiceChangesXML=
2023-04-12 09:00:38 : DEBUG : bracketsio : expectedTeamID=8F632A866K
2023-04-12 09:00:38 : DEBUG : bracketsio : blockingProcesses=
2023-04-12 09:00:38 : DEBUG : bracketsio : installerTool=
2023-04-12 09:00:38 : DEBUG : bracketsio : CLIInstaller=
2023-04-12 09:00:38 : DEBUG : bracketsio : CLIArguments=
2023-04-12 09:00:38 : DEBUG : bracketsio : updateTool=
2023-04-12 09:00:38 : DEBUG : bracketsio : updateToolArguments=
2023-04-12 09:00:38 : DEBUG : bracketsio : updateToolRunAsCurrentUser=
2023-04-12 09:00:38 : INFO  : bracketsio : BLOCKING_PROCESS_ACTION=tell_user
2023-04-12 09:00:38 : INFO  : bracketsio : NOTIFY=success
2023-04-12 09:00:38 : INFO  : bracketsio : LOGGING=DEBUG
2023-04-12 09:00:38 : INFO  : bracketsio : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2023-04-12 09:00:38 : INFO  : bracketsio : Label type: dmg
2023-04-12 09:00:38 : INFO  : bracketsio : archiveName: Brackets.dmg
2023-04-12 09:00:38 : INFO  : bracketsio : no blocking processes defined, using Brackets as default
2023-04-12 09:00:38 : DEBUG : bracketsio : Changing directory to /Users/armin/BTSync/Work/Projects/Installomator/build
2023-04-12 09:00:38 : INFO  : bracketsio : name: Brackets, appName: Brackets.app
2023-04-12 09:00:38.405 mdfind[88403:5147039] [UserQueryParser] Loading keywords and predicates for locale "en_US"
2023-04-12 09:00:38.405 mdfind[88403:5147039] [UserQueryParser] Loading keywords and predicates for locale "en"
2023-04-12 09:00:38.443 mdfind[88403:5147039] Couldn't determine the mapping between prefab keywords and predicates.
2023-04-12 09:00:38 : WARN  : bracketsio : No previous app found
2023-04-12 09:00:38 : WARN  : bracketsio : could not find Brackets.app
2023-04-12 09:00:38 : INFO  : bracketsio : appversion: 
2023-04-12 09:00:38 : INFO  : bracketsio : Latest version of Brackets is 2.2.1
2023-04-12 09:00:38 : REQ   : bracketsio : Downloading 2023-04-12 09:00:36 : INFO  : bracketsio : GitHub API not returning URL, trying https://github.com/brackets-cont/brackets/releases/latest.
2023-04-12 09:00:38 : REQ   : bracketsio : https://github.com to Brackets.dmg
2023-04-12 09:00:38 : DEBUG : bracketsio : No Dialog connection, just download
2023-04-12 09:00:38 : ERROR : bracketsio : error downloading 2023-04-12 09:00:36 : INFO  : bracketsio : GitHub API not returning URL, trying https://github.com/brackets-cont/brackets/releases/latest.
2023-04-12 09:00:38 : ERROR : bracketsio : https://github.com
ls: Brackets.dmg: No such file or directory
2023-04-12 09:00:38 : ERROR : bracketsio : File list: 
2023-04-12 09:00:38 : ERROR : bracketsio : File type: Brackets.dmg: cannot open `Brackets.dmg' (No such file or directory)
2023-04-12 09:00:38 : DEBUG : bracketsio : DEBUG mode 1, not reopening anything
2023-04-12 09:00:38 : ERROR : bracketsio : ERROR: Error downloading 2023-04-12 09:00:36 : INFO  : bracketsio : GitHub API not returning URL, trying https://github.com/brackets-cont/brackets/releases/latest.
2023-04-12 09:00:38 : ERROR : bracketsio : https://github.com error:
* Closing connection -1
curl: (3) URL using bad/illegal format or missing URL

2023-04-12 09:00:38 : REQ   : bracketsio : ################## End Installomator, exit code 2

The reason for this error is that the project's latest release is a "windows only patch" and does not have a dmg attached 🤦

@wakco
Update bracketsio.sh
df10cef 
Adjusted as requested.
@scriptingosx
Copy link
Collaborator

scriptingosx commented Apr 12, 2023

That would require replacing the downloadURLFromGit function with something custom (or better, fixing the downloadURLFromGit to be a bit resilient here...)

For now, I will keep this open until there is a new release and then hope that don't frequently do single platform patches...

@scriptingosx scriptingosx merged commit df10cef into Installomator:main May 26, 2023
@scriptingosx
Copy link
Collaborator

scriptingosx commented May 26, 2023

Download works again. Team ID changed in the interim. I fixed it in the merge. Thank you

@wakco wakco deleted the Label-bracketsio-replacing-adobebrackets branch April 1, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scriptingosx scriptingosx scriptingosx left review comments

Assignees

No one assigned

Labels

application adds or improves an application label

Projects

None yet

Milestone

v10.4

Development

Successfully merging this pull request may close these issues.

3 participants

@wakco @scriptingosx @Theile