appClosed being set prematurely#860
Merged
scriptingosx merged 4 commits intoInstallomator:devfrom Feb 24, 2023
Merged
Conversation
Collaborator
|
duplicate of #657 which is already merged into the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable
appClosedis being set to1if a blocking process is found, but before any processes are actually closed. This has unintended behavior in the case whereBLOCKING_PROCESS_ACTIONissilent_failsince nothing is actually closed in this case statement, only thecleanupAndExitfunction is called.This function calls
reopenClosedProcesswhich checks whetherappClosedis set and tries to reopen the app if so. Because the app was already open (which is why we entered this case statement in the first place) and the variable was set prematurely, all this does is instead pop the app into focus on the user's screen, interrupting whatever it was they were doing.This was noticed due to any app that we attempted to update with this method popping into focus one or more times a day.
I added an additional function to set this value in cases where Apple Script is being used to try and closed the app, so that this variable gets set correctly in each case. I also set the variable for the case where instead of Apple Script, the
pkillcommand is used.