Use Self Service icon as the 'overlayicon'#778
Merged
scriptingosx merged 2 commits intoInstallomator:mainfrom Dec 2, 2022
dan-snelson:main
Merged
Use Self Service icon as the 'overlayicon'#778scriptingosx merged 2 commits intoInstallomator:mainfrom dan-snelson:main
scriptingosx merged 2 commits intoInstallomator:mainfrom
dan-snelson:main
Conversation
Collaborator
|
Thank you, it looks great. It's only for Jamf, so think we need to consider if it's running in other MDM. We have tests for that, so maybe a test for that here as well. I can help, I'm just thinking loud here. |
scriptingosx
added
improvement
Collaborator
|
Oh, I realise you only changed the supporting files for Jamf. I will rest my rambling of other MDM solution, but probably copy your idea (again, again). Thank you, I put it on the milestone. |
Contributor
Author
|
Thanks, @Theile. |
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for all your work on
v10.This PR uses the Self Service icon as the 'overlayicon' in the
miniprogress dialog.