Version fix for the Skype label#762
Merged
scriptingosx merged 1 commit intoInstallomator:mainfrom Dec 2, 2022
Merged
Conversation
The current Skype label only checks for version x.xx (e.g. 8.90), which means it does not detect more minor version updates like the current latest version 8.90.0.407. I've changed the code in the appNewVersion variable and added a versionKey variable that fixes this problem. 2022-11-10 08:26:43 : REQ : skype : ################## Start Installomator v. 10.0beta3, date 2022-11-10 2022-11-10 08:26:43 : INFO : skype : ################## Version: 10.0beta3 2022-11-10 08:26:43 : INFO : skype : ################## Date: 2022-11-10 2022-11-10 08:26:43 : INFO : skype : ################## skype 2022-11-10 08:26:43 : INFO : skype : SwiftDialog is not installed, clear cmd file var 2022-11-10 08:26:43 : INFO : skype : BLOCKING_PROCESS_ACTION=tell_user 2022-11-10 08:26:43 : INFO : skype : NOTIFY=success 2022-11-10 08:26:43 : INFO : skype : LOGGING=INFO 2022-11-10 08:26:43 : INFO : skype : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns 2022-11-10 08:26:43 : INFO : skype : Label type: dmg 2022-11-10 08:26:43 : INFO : skype : archiveName: Skype.dmg 2022-11-10 08:26:43 : INFO : skype : no blocking processes defined, using Skype as default 2022-11-10 08:26:43 : INFO : skype : App(s) found: /Applications/Skype.app 2022-11-10 08:26:43 : INFO : skype : found app at /Applications/Skype.app, version 8.90.0.405, on versionKey CFBundleVersion 2022-11-10 08:26:43 : INFO : skype : appversion: 8.90.0.405 2022-11-10 08:26:43 : INFO : skype : Latest version of Skype is 8.90.0.407 2022-11-10 08:26:43 : REQ : skype : Downloading https://get.skype.com/go/getskype-skypeformac to Skype.dmg 2022-11-10 08:26:45 : REQ : skype : no more blocking processes, continue with update 2022-11-10 08:26:45 : REQ : skype : Installing Skype 2022-11-10 08:26:45 : INFO : skype : Mounting /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.C1ZzJtXF/Skype.dmg 2022-11-10 08:26:50 : INFO : skype : Mounted: /Volumes/Skype 2022-11-10 08:26:50 : INFO : skype : Verifying: /Volumes/Skype/Skype.app 2022-11-10 08:26:52 : INFO : skype : Team ID matching: AL798K98FX (expected: AL798K98FX ) 2022-11-10 08:26:52 : INFO : skype : Downloaded version of Skype is 8.90.0.407 on versionKey CFBundleVersion (replacing version 8.90.0.405). 2022-11-10 08:26:52 : INFO : skype : App has LSMinimumSystemVersion: 10.11 2022-11-10 08:26:52 : WARN : skype : Removing existing /Applications/Skype.app 2022-11-10 08:26:52 : INFO : skype : Copy /Volumes/Skype/Skype.app to /Applications 2022-11-10 08:26:53 : WARN : skype : Changing owner to frela447 2022-11-10 08:26:53 : INFO : skype : Finishing... 2022-11-10 08:26:56 : INFO : skype : App(s) found: /Applications/Skype.app 2022-11-10 08:26:56 : INFO : skype : found app at /Applications/Skype.app, version 8.90.0.407, on versionKey CFBundleVersion 2022-11-10 08:26:56 : REQ : skype : Installed Skype, version 8.90.0.407 2022-11-10 08:26:56 : INFO : skype : notifying 2022-11-10 08:26:57 : INFO : skype : App not closed, so no reopen. 2022-11-10 08:26:57 : REQ : skype : All done! 2022-11-10 08:26:57 : REQ : skype : ################## End Installomator, exit code 0
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current Skype label only checks for version x.xx (e.g. 8.90), which means it does not detect more minor version updates like the current latest version 8.90.0.407. I've changed the code in the appNewVersion variable and added a versionKey variable that fixes this problem.
2022-11-10 08:26:43 : REQ : skype : ################## Start Installomator v. 10.0beta3, date 2022-11-10
2022-11-10 08:26:43 : INFO : skype : ################## Version: 10.0beta3
2022-11-10 08:26:43 : INFO : skype : ################## Date: 2022-11-10
2022-11-10 08:26:43 : INFO : skype : ################## skype
2022-11-10 08:26:43 : INFO : skype : SwiftDialog is not installed, clear cmd file var
2022-11-10 08:26:43 : INFO : skype : BLOCKING_PROCESS_ACTION=tell_user
2022-11-10 08:26:43 : INFO : skype : NOTIFY=success
2022-11-10 08:26:43 : INFO : skype : LOGGING=INFO
2022-11-10 08:26:43 : INFO : skype : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2022-11-10 08:26:43 : INFO : skype : Label type: dmg
2022-11-10 08:26:43 : INFO : skype : archiveName: Skype.dmg
2022-11-10 08:26:43 : INFO : skype : no blocking processes defined, using Skype as default
2022-11-10 08:26:43 : INFO : skype : App(s) found: /Applications/Skype.app
2022-11-10 08:26:43 : INFO : skype : found app at /Applications/Skype.app, version 8.90.0.405, on versionKey CFBundleVersion
2022-11-10 08:26:43 : INFO : skype : appversion: 8.90.0.405
2022-11-10 08:26:43 : INFO : skype : Latest version of Skype is 8.90.0.407
2022-11-10 08:26:43 : REQ : skype : Downloading https://get.skype.com/go/getskype-skypeformac to Skype.dmg
2022-11-10 08:26:45 : REQ : skype : no more blocking processes, continue with update
2022-11-10 08:26:45 : REQ : skype : Installing Skype
2022-11-10 08:26:45 : INFO : skype : Mounting /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.C1ZzJtXF/Skype.dmg
2022-11-10 08:26:50 : INFO : skype : Mounted: /Volumes/Skype
2022-11-10 08:26:50 : INFO : skype : Verifying: /Volumes/Skype/Skype.app
2022-11-10 08:26:52 : INFO : skype : Team ID matching: AL798K98FX (expected: AL798K98FX )
2022-11-10 08:26:52 : INFO : skype : Downloaded version of Skype is 8.90.0.407 on versionKey CFBundleVersion (replacing version 8.90.0.405).
2022-11-10 08:26:52 : INFO : skype : App has LSMinimumSystemVersion: 10.11
2022-11-10 08:26:52 : WARN : skype : Removing existing /Applications/Skype.app
2022-11-10 08:26:52 : INFO : skype : Copy /Volumes/Skype/Skype.app to /Applications
2022-11-10 08:26:53 : WARN : skype : Changing owner to kryptonit
2022-11-10 08:26:53 : INFO : skype : Finishing...
2022-11-10 08:26:56 : INFO : skype : App(s) found: /Applications/Skype.app
2022-11-10 08:26:56 : INFO : skype : found app at /Applications/Skype.app, version 8.90.0.407, on versionKey CFBundleVersion
2022-11-10 08:26:56 : REQ : skype : Installed Skype, version 8.90.0.407
2022-11-10 08:26:56 : INFO : skype : notifying
2022-11-10 08:26:57 : INFO : skype : App not closed, so no reopen.
2022-11-10 08:26:57 : REQ : skype : All done!
2022-11-10 08:26:57 : REQ : skype : ################## End Installomator, exit code 0