Updated finishing function for better detection of new install versus an update.#756
Merged
scriptingosx merged 4 commits intoInstallomator:devfrom Jan 6, 2023
Conversation
Contributor
Author
|
This is related to issue: #518 |
Contributor
Author
|
Example of how the notifications look. From top to bottom, first three are what the new install looks like, last three are what an update looks like. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made some small changes to the finishing function that removes the
getAppVersioncall (this is what accidentally always sets theupdateDetectedvariable to "YES". By instead removing this call and also using theappNewVersionvariable we get better results on a new install versus an update.