Conversation
|
Thanks, but there are a few errors in this PR.
Have you seen my presentation from JNUC 2023, it will show more of this (hopefully it will be available for free, soon). |
|
Hi Theile, |
|
I understand! Please note that currently your label downloads a specific version, and you even have a version number in the name. We only wants labels that download the "latest" version. Latest version does not have a number. The number will be calculated/isolated somehow. That could be from an URL or something. And I don't think you need to use packageID, as the app has a version already, but I haven't checked this. Look at our wiki, specifically for which variables to include: Compare your work to other labels, and see if you think it looks right. And run your label with Installomator and the My presentation talks about how to locate and isolate URLs and version from homepages and so on, but try to see if you can figure it out on this label. You can also put a comment on what page you found the download link, I cannot find this, so do not know where to start. |
|
Hi Søren
I’ve amended the label with new changes suiting the appNewVersion variable to labels guidelines. Eager to receive your feedback.
Thanks
Br
Iñaky
From: Søren Theilgaard ***@***.***>
Date: Tuesday, 11 October 2022 at 10:48
To: Installomator/Installomator ***@***.***>
Cc: Inaky Martinez ***@***.***>, Author ***@***.***>
Subject: Re: [Installomator/Installomator] Create lucid.sh (PR #722)
You don't often get email from ***@***.*** Learn why this is important<https://aka.ms/LearnAboutSenderIdentification>
I understand!
Please note that currently your label downloads a specific version, and you even have a version number in the name.
We only wants labels that download the "latest" version. Latest version does not have a number. The number will be calculated/isolated somehow. That could be from an URL or something.
And I don't think you need to use packageID, as the app has a version already, but I haven't checked this.
Look at our wiki, specifically for which variables to include:
https://github.com/Installomator/Installomator/wiki/Labels-Reference-guide-to-fields<https://github.com/Installomator/Installomator/wiki/Labels-Reference-guide-to-fields>
Compare your work to other labels, and see if you think it looks right. And run your label with Installomator and the assemble.sh script so you can show a log of that.
My presentation talks about how to locate and isolate URLs and version from homepages and so on, but try to see if you can figure it out on this label. You can also put a comment on what page you found the download link, I cannot find this, so do not know where to start.
—
Reply to this email directly, view it on GitHub<#722 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC4JWJS3WMRUHOVNBSBRWI3WCUSTXANCNFSM6AAAAAARCAFUUY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
LEWIS
|
|
That looks great! Wouldn't a more correct label name be “lucidlink”. (I know that I use lucid.app myself, and even though they do not offer a macOS app, I was still thinking that this might be for that). And remember to have the Great, what a progress! |
Updated name :)
|
You were absolutely right! Just amended the name and seems to be working for me from assemble.
😊
Iñaky
From: Søren Theilgaard ***@***.***>
Date: Tuesday, 11 October 2022 at 13:24
To: Installomator/Installomator ***@***.***>
Cc: Inaky Martinez ***@***.***>, Author ***@***.***>
Subject: Re: [Installomator/Installomator] Create lucid.sh (PR #722)
That looks great!
Wouldn't a more correct label name be “lucidlink”. (I know that I use lucid.app myself, and even though they do not offer a macOS app, I was still thinking that this might be for that).
And remember to have the name-variable match case of the app.
Great, what a progress!
—
Reply to this email directly, view it on GitHub<#722 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC4JWJRZ5SV5UQ4KQC2S2ZTWCVE5FANCNFSM6AAAAAARCAFUUY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
LEWIS
|
`name` is now the name of the app. App has perfect values in it's version, so no need for `packageID`. Since `name` matches the name of the app, `blockingProcesses` comes for free.
|
Thank you, I just made som final touches, with these comments:
|
|
Morning Søren 😊
Oh right, Thanks for your adjustments and comment. What would be the next steps?
Br
Iñaky
From: Søren Theilgaard ***@***.***>
Date: Wednesday, 12 October 2022 at 08:41
To: Installomator/Installomator ***@***.***>
Cc: Inaky Martinez ***@***.***>, Author ***@***.***>
Subject: Re: [Installomator/Installomator] Create lucid.sh (PR #722)
Thank you, I just made som final touches, with these comments:
name is now the name of the app. App has perfect values in it’s version, so no need for packageID. Since name matches the name of the app, blockingProcesses comes for free.
—
Reply to this email directly, view it on GitHub<#722 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC4JWJUE5LLBNIUP3P5OEG3WCZMHNANCNFSM6AAAAAARCAFUUY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
LEWIS
|
|
Good morning! I have assigned a milestone to it, so next step is for us to merge this into "main", so it will be available in the next release. You are welcome to test this for a full |
|
Hi Theile, Hope you're doing great. Just to let you know I,ve been testing on debug 0 and works flawless for us. Do not hesitate to contact me if need any further test or change from my side. Thank you |
|
Thank you! |
3 participants
lucid)
name="lucid-2.1.4032"
type="pkg"
packageID="com.lucidlink
org.mantle.Mantle
Lucid.app/Contents/Frameworks/Mantle.framework
com.lucidlink.build.helper.Renderer
Lucid.app/Contents/Frameworks/Lucid
com.lucidlink.lucidfs
Lucid.app/Contents/Resources/lucidfs/lucidfs.fs
com.lucidlink.build.helper
Lucid.app/Contents/Frameworks/Lucid
com.lucidlink.lucidfs.frameworks.lucidfs
Lucid.app/Contents/Resources/lucidfs/lucidfs.fs/Contents/Frameworks/LucidFS.framework
com.github.Electron.framework
Lucid.app/Contents/Frameworks/Electron
com.lucidlink.build.helper.GPU
Lucid.app/Contents/Frameworks/Lucid
com.lucidlink.lucidfs.filesystems.lucidfs
Lucid.app/Contents/Resources/lucidfs/lucidfs.fs/Contents/Resources/mount_lucidfs.app/Contents/Extensions/10.12/lucidfs.kext
com.lucidlink.build
Lucid.app/Contents/Resources/ProxyResolver.app
com.lucidlink.build.helper.Plugin
Lucid.app/Contents/Frameworks/Lucid
com.lucidlink.LucidFinderExt
Lucid.app/Contents/PlugIns/LucidFinderExt.appex
com.lucidlink
Lucid.app
org.reactivecocoa.ReactiveCocoa
Lucid.app/Contents/Resources/ProxyResolver.app/Contents/Frameworks/ReactiveCocoa.framework
com.lucidlink.lucidfs.Mounter
Lucid.app/Contents/Resources/lucidfs/lucidfs.fs/Contents/Resources/mount_lucidfs.app
com.github.Squirrel
Lucid.app/Contents/Resources/ProxyResolver.app/Contents/Frameworks/Squirrel.framework"
downloadURL="https://d3il9duqikhdqy.cloudfront.net/latest/osx/lucid-2.1.4032.pkg"
appNewVersion=""
expectedTeamID="Y4KMJPU2B4"
blockingProcesses=( Lucid )
;;