Don't relaunch a program if user chooses "not now"#638
Merged
scriptingosx merged 4 commits intoInstallomator:devfrom Jan 6, 2023
dnikles:dont_reopen_not_now
Merged
Don't relaunch a program if user chooses "not now"#638scriptingosx merged 4 commits intoInstallomator:devfrom dnikles:dont_reopen_not_now
scriptingosx merged 4 commits intoInstallomator:devfrom
dnikles:dont_reopen_not_now
Conversation
Current behavior will "launch" a program when the user selects "not now", even though the program was never closed, which brings a program the user may not be working in to the front. This change checks for that error "10", and if so, it will not run the reopenCLosedProcess function. The end result is if a user selects not now, that program is not brought to the front.
This reverts commit c08a884.
This is cleaner than my earlier commit. appClosed is set to 1 before the app is actually closed. If we defer, set appClosed to something other than 1. The function that calls to reopen the app checks if it is set to 1, so setting it to 0 prevents the app from opening, and will appropriately log " App not closed, so no reopen."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior will "launch" a program when the user selects "not now", even though the program was never closed, which brings a program the user may not be working in to the front. This change sets appClosed to 0 if the user chooses not now, and therefore does not close the app. The end result is if a user selects not now, that program is not brought to the front.