Only prompt once on prompt_user_then_kill#603
Merged
scriptingosx merged 4 commits intoInstallomator:devfrom Jan 21, 2023
dnikles:prompt_once_then_kill
Merged
Only prompt once on prompt_user_then_kill#603scriptingosx merged 4 commits intoInstallomator:devfrom dnikles:prompt_once_then_kill
scriptingosx merged 4 commits intoInstallomator:devfrom
dnikles:prompt_once_then_kill
Conversation
prompt_user_then_kill prompts, then attempts to quit, then prompts, then attempts to quit, then prompts, then attempts to quit, then kills. And in my experience, it then doesn't even run the installation. This changes it to prompt, attempt to quit, then kill without all the the re-prompting. old experience: ``` 2022-06-30 10:59:35 : INFO : adobereaderdc-update : found blocking process AdobeReader 2022-06-30 10:59:37 : INFO : adobereaderdc-update : telling app AdobeReader to quit 2022-06-30 10:59:37 : INFO : adobereaderdc-update : waiting 30 seconds for processes to quit 2022-06-30 11:00:07 : INFO : adobereaderdc-update : found blocking process AdobeReader 2022-06-30 11:00:13 : INFO : adobereaderdc-update : telling app AdobeReader to quit 2022-06-30 11:00:14 : INFO : adobereaderdc-update : waiting 30 seconds for processes to quit 2022-06-30 11:00:44 : INFO : adobereaderdc-update : found blocking process AdobeReader 2022-06-30 11:00:46 : INFO : adobereaderdc-update : Changing BLOCKING_PROCESS_ACTION to kill 2022-06-30 11:00:46 : INFO : adobereaderdc-update : found blocking process AdobeReader 2022-06-30 11:00:46 : INFO : adobereaderdc-update : killing process AdobeReader 2022-06-30 11:00:51 : INFO : adobereaderdc-update : Telling app Adobe Acrobat Reader DC.app to open 2022-06-30 11:00:51 : INFO : adobereaderdc-update : Reopened Adobe Acrobat Reader DC.app as dnikles 2022-06-30 11:00:51 : INFO : adobereaderdc-update : dnikles 2022-06-30 11:00:51 : ERROR : adobereaderdc-update : ERROR: could not quit all processes, aborting... 2022-06-30 11:00:51 : REQ : adobereaderdc-update : ################## End Installomator, exit code 11 ``` new experience: ``` 2022-06-30 11:10:41 : INFO : adobereaderdc-update : found blocking process AdobeReader 2022-06-30 11:10:43 : INFO : adobereaderdc-update : telling app AdobeReader to quit 2022-06-30 11:10:44 : INFO : adobereaderdc-update : waiting 30 seconds for processes to quit 2022-06-30 11:11:14 : INFO : adobereaderdc-update : Changing BLOCKING_PROCESS_ACTION to kill 2022-06-30 11:11:14 : INFO : adobereaderdc-update : found blocking process AdobeReader 2022-06-30 11:11:14 : INFO : adobereaderdc-update : killing process AdobeReader 2022-06-30 11:11:19 : REQ : adobereaderdc-update : no more blocking processes, continue with update 2022-06-30 11:11:19 : REQ : adobereaderdc-update : Installing Adobe Acrobat Reader DC ```
This reverts commit 18e8def.
Making the change in the appropriate file instead of in the assembled script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prompt_user_then_kill prompts, then attempts to quit, then prompts, then attempts to quit, then prompts, then attempts to quit, then kills. And in my experience, it then doesn't even run the installation. This changes it to prompt, attempt to quit, then kill without all the the re-prompting.
old experience:
new experience: