Add appNewVersion to cloudflarewarp#2220
Merged
bartreardon merged 1 commit intoInstallomator:mainfrom Mar 24, 2025
Merged
Conversation
Collaborator
|
🤖 Validation robot 🤖 |
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have you confirmed this pull request is not a duplicate?
Yes
Is this pull request creating or modifying a label in the fragments/labels folder, and not Installomator.sh itself?
Yes
Did you use our editorconfig file?
Yes
Additional context
Label had an empty appNewVersion, causing it to reinstall even when not needed.
In this fixed label, the version pulled from the download url is cropped, since the pkg receipt version lacks the last part.
(Best would be to use customAppVersion, checking the installed app, so that it will work on installations without receipts. That just rendered a constant reinstallation, bringing me back to square one)
Installomator log
Without installed app:
After app is installed: