Skip to content

Comments

Update r.sh#2188

Merged
bartreardon merged 1 commit intoInstallomator:mainfrom
jvaglivelo:r-appCustomVersion
Mar 23, 2025
Merged

Update r.sh#2188
bartreardon merged 1 commit intoInstallomator:mainfrom
jvaglivelo:r-appCustomVersion

Conversation

@jvaglivelo
Copy link
Contributor

@jvaglivelo jvaglivelo commented Feb 13, 2025

All questions must be filled out or your Pull Request will be closed for lack of information. The first three questions should be answered Yes before submitting the pull request.

Have you confirmed this pull request is not a duplicate?
Yes

Is this pull request creating or modifying a label in the fragments/labels folder, and not Installomator.sh itself?
Yes

Did you use our editorconfig file?
Yes

Additional context Add any other context about the label or fix here.

Whenever an update check is run for the application R, it compares the full CFBundleShortVersionString (version R 4.4.2 GUI 1.81 Big Sur ARM build) to the latest version (4.4.2). This results in it re-downloading R every time Installomator is run.

2025-02-13 09:51:57 : INFO  : r : found app at /Applications/R.app, version R 4.4.2 GUI 1.81 Big Sur ARM build, on versionKey CFBundleShortVersionString
2025-02-13 09:51:57 : INFO  : r : appversion: R 4.4.2 GUI 1.81 Big Sur ARM build
2025-02-13 09:51:57 : INFO  : r : Latest version of R is 4.4.2
2025-02-13 09:51:57 : REQ   : r : Downloading https://cloud.r-project.org/bin/macosx/big-sur-arm64/base/R-4.4.2-arm64.pkg to R.pkg

The appCustomVersion returns the correct value, so R is not re-downloaded when checking for an update.

Installomator log

2025-02-13 09:55:09 : REQ   : r : ################## Start Installomator v. 10.7, date 2025-01-24
2025-02-13 09:55:09 : INFO  : r : ################## Version: 10.7
2025-02-13 09:55:09 : INFO  : r : ################## Date: 2025-01-24
2025-02-13 09:55:09 : INFO  : r : ################## r
2025-02-13 09:55:09 : INFO  : r : BLOCKING_PROCESS_ACTION=tell_user
2025-02-13 09:55:09 : INFO  : r : NOTIFY=success
2025-02-13 09:55:10 : INFO  : r : LOGGING=INFO
2025-02-13 09:55:10 : INFO  : r : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2025-02-13 09:55:10 : INFO  : r : Label type: pkg
2025-02-13 09:55:10 : INFO  : r : archiveName: R.pkg
2025-02-13 09:55:10 : INFO  : r : no blocking processes defined, using R as default
2025-02-13 09:55:10 : INFO  : r : Custom App Version detection is used, found 4.4.2
2025-02-13 09:55:10 : INFO  : r : appversion: 4.4.2
2025-02-13 09:55:10 : INFO  : r : Latest version of R is 4.4.2
2025-02-13 09:55:10 : INFO  : r : There is no newer version available.
2025-02-13 09:55:10 : INFO  : r : Installomator did not close any apps, so no need to reopen any apps.
2025-02-13 09:55:10 : REQ   : r : No newer version.
2025-02-13 09:55:10 : REQ   : r : ################## End Installomator, exit code 0

@bartreardon bartreardon added application adds or improves an application label validated App label that has been validated by the validation bot labels Feb 20, 2025
@bartreardon
Copy link
Collaborator

bartreardon commented Feb 20, 2025

🤖 Validation robot 🤖
File fragments/labels/r.sh
** Label info:
├ ✅ correct line ending
├ ✅ Name: R
├ ✅ Type: pkg
├ ✅ Expected Team: VZLD955F6P
├ ✅ App New Version: 4.4.2
└ Download URL: https://cloud.r-project.org/bin/macosx/big-sur-arm64/base/R-4.4.2-arm64.pkg
├ ✅ URL is reachable
└ ✅ Download Size: 93.4 MB
✅ All checks passed

@bartreardon bartreardon added this to the v10.8 milestone Mar 21, 2025
@bartreardon
Copy link
Collaborator

bartreardon commented Mar 23, 2025

Thank you!

@bartreardon bartreardon merged commit fb8bb90 into Installomator:main Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

application adds or improves an application label validated App label that has been validated by the validation bot

Projects

None yet

Milestone

v10.8

Development

Successfully merging this pull request may close these issues.

2 participants

@jvaglivelo @bartreardon