Skip to content

Comments

Update deepl.sh#2185

Merged
bartreardon merged 1 commit intoInstallomator:mainfrom
74k1:update-deepl
Mar 23, 2025
Merged

Update deepl.sh#2185
bartreardon merged 1 commit intoInstallomator:mainfrom
74k1:update-deepl

Conversation

@74k1
Copy link
Contributor

@74k1 74k1 commented Feb 11, 2025

All questions must be filled out or your Pull Request will be closed for lack of information. The first three questions should be answered Yes before submitting the pull request.

Have you confirmed this pull request is not a duplicate?
Yes

Is this pull request creating or modifying a label in the fragments/labels folder, and not Installomator.sh itself?
Yes

Did you use our editorconfig file?
Yes, didn't need it though

Additional context Add any other context about the label or fix here.
Adds appNewVersion and uses the same download URL specified in appNewVersion instead of an ambiguous link for what appears to be the latest version of Deepl.

Installomator log At the bottom of this pull request, provide a log of a label run by running Installomator in Terminal and saving the output. DEBUG=1 can be enabled but do not enable Debug logging level and please format the log using a code block!

Script exit code: 0
Script result: 2025-02-07 09:30:25 : REQ   :  : shifting arguments for Jamf
2025-02-07 09:30:25 : INFO  : deepl : setting variable from argument DEBUG=1
2025-02-07 09:30:25 : INFO  : deepl : setting variable from argument LOGGING=INFO
2025-02-07 09:30:25 : INFO  : deepl : Total items in argumentsArray: 2
2025-02-07 09:30:25 : INFO  : deepl : argumentsArray: DEBUG=1 LOGGING=INFO
2025-02-07 09:30:25 : REQ   : deepl : ################## Start Installomator v. 10.8beta, date 2025-02-01
2025-02-07 09:30:25 : INFO  : deepl : ################## Version: 10.8beta
2025-02-07 09:30:25 : INFO  : deepl : ################## Date: 2025-02-01
2025-02-07 09:30:25 : INFO  : deepl : ################## deepl
2025-02-07 09:30:25 : DEBUG : deepl : DEBUG mode 1 enabled.
2025-02-07 09:30:25 : INFO  : deepl : Reading arguments again: DEBUG=1 LOGGING=INFO
2025-02-07 09:30:25 : DEBUG : deepl : argument: DEBUG=1
2025-02-07 09:30:25 : DEBUG : deepl : argument: LOGGING=INFO
2025-02-07 09:30:25 : INFO  : deepl : BLOCKING_PROCESS_ACTION=tell_user
2025-02-07 09:30:26 : INFO  : deepl : NOTIFY=success
2025-02-07 09:30:26 : INFO  : deepl : LOGGING=INFO
2025-02-07 09:30:26 : INFO  : deepl : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2025-02-07 09:30:26 : INFO  : deepl : Label type: dmg
2025-02-07 09:30:26 : INFO  : deepl : archiveName: DeepL.dmg
2025-02-07 09:30:26 : INFO  : deepl : no blocking processes defined, using DeepL as default
2025-02-07 09:30:26 : INFO  : deepl : App(s) found: /Applications/DeepL.app
2025-02-07 09:30:26 : INFO  : deepl : found app at /Applications/DeepL.app, version 25.1.11615133, on versionKey CFBundleShortVersionString
2025-02-07 09:30:26 : INFO  : deepl : appversion: 25.1.11615133
2025-02-07 09:30:26 : INFO  : deepl : Latest version of DeepL is 25.1.11615133
2025-02-07 09:30:26 : WARN  : deepl : DEBUG mode 1 enabled, not exiting, but there is no new version of app.
2025-02-07 09:30:26 : INFO  : deepl : DeepL.dmg exists and DEBUG mode 1 enabled, skipping download
2025-02-07 09:30:26 : REQ   : deepl : Installing DeepL
2025-02-07 09:30:26 : INFO  : deepl : Mounting /Library/Application Support/JAMF/tmp/DeepL.dmg
2025-02-07 09:30:26 : INFO  : deepl : Mounted: /Volumes/DeepL
2025-02-07 09:30:26 : INFO  : deepl : Verifying: /Volumes/DeepL/DeepL.app
2025-02-07 09:30:27 : INFO  : deepl : Team ID matching: 4N8BGCG336 (expected: 4N8BGCG336 )
2025-02-07 09:30:27 : INFO  : deepl : Downloaded version of DeepL is 25.1.11615133 on versionKey CFBundleShortVersionString, same as installed.
2025-02-07 09:30:27 : REQ   : deepl : ################## End Installomator, exit code 0

Please identify any issues fixed by your pull request by including the issue number. (Example: "Fixes #XXXX")
Superseeds #2176
#1453 can already be closed, as Deepl has already been added with #1372

@bartreardon bartreardon added application adds or improves an application label validated App label that has been validated by the validation bot labels Feb 20, 2025
@bartreardon
Copy link
Collaborator

🤖 Validation robot 🤖
File fragments/labels/deepl.sh
** Label info:
├ ✅ correct line ending
├ ✅ Name: DeepL
├ ✅ Type: dmg
├ ✅ Expected Team: 4N8BGCG336
├ ✅ App New Version: 25.2.11705510
└ Download URL: https://appdownload.deepl.com/macos/25.2/11705510/DeepL.dmg
├ ✅ URL is reachable
└ ✅ Download Size: 97.6 MB
✅ All checks passed


@bartreardon bartreardon added this to the v10.8 milestone Mar 21, 2025
@bartreardon
Copy link
Collaborator

Thank you!

@bartreardon bartreardon merged commit f1e921e into Installomator:main Mar 23, 2025
1 check passed
@74k1 74k1 deleted the update-deepl branch March 24, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application adds or improves an application label validated App label that has been validated by the validation bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants