Skip to content

Comments

Update texshop.sh#2180

Merged
bartreardon merged 1 commit intoInstallomator:mainfrom
kryptonit1:texshop-label-fix
Mar 23, 2025
Merged

Update texshop.sh#2180
bartreardon merged 1 commit intoInstallomator:mainfrom
kryptonit1:texshop-label-fix

Conversation

@kryptonit1
Copy link
Contributor

All questions must be filled out or your Pull Request will be closed for lack of information. The first three questions should be answered Yes before submitting the pull request.

Have you confirmed this pull request is not a duplicate?
Yes

Is this pull request creating or modifying a label in the fragments/labels folder, and not Installomator.sh itself?
Yes

Did you use our editorconfig file?
Yes

Additional context Add any other context about the label or fix here.

The appNewVersion variable is broken in the current texshop label:

2025-02-10 12:53:18 : INFO  : texshop : setting variable from argument DEBUG=0
2025-02-10 12:53:18 : INFO  : texshop : Total items in argumentsArray: 1
2025-02-10 12:53:18 : INFO  : texshop : argumentsArray: DEBUG=0
2025-02-10 12:53:18 : REQ   : texshop : ################## Start Installomator v. 10.8beta, date 2025-02-10
2025-02-10 12:53:18 : INFO  : texshop : ################## Version: 10.8beta
2025-02-10 12:53:18 : INFO  : texshop : ################## Date: 2025-02-10
2025-02-10 12:53:18 : INFO  : texshop : ################## texshop
2025-02-10 12:53:18 : INFO  : texshop : SwiftDialog is not installed, clear cmd file var
2025-02-10 12:53:19 : INFO  : texshop : Reading arguments again: DEBUG=0
2025-02-10 12:53:19 : INFO  : texshop : BLOCKING_PROCESS_ACTION=tell_user
2025-02-10 12:53:19 : INFO  : texshop : NOTIFY=success
2025-02-10 12:53:19 : INFO  : texshop : LOGGING=INFO
2025-02-10 12:53:19 : INFO  : texshop : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2025-02-10 12:53:19 : INFO  : texshop : Label type: zip
2025-02-10 12:53:19 : INFO  : texshop : archiveName: TeXShop.zip
2025-02-10 12:53:19 : INFO  : texshop : no blocking processes defined, using TeXShop as default
2025-02-10 12:53:19 : INFO  : texshop : App(s) found: /Applications/TeXShop.app
2025-02-10 12:53:19 : INFO  : texshop : found app at /Applications/TeXShop.app, version 5.49, on versionKey CFBundleShortVersionString
2025-02-10 12:53:19 : INFO  : texshop : appversion: 5.49
2025-02-10 12:53:19 : INFO  : texshop : Latest version of TeXShop is <center> [ Direct Download: <a href="texshop-64/texshop.zip">Latest TeXShop</a> | <a href="texshop-64//texshopsource.zip">Latest TeXShop Source</a> ] [ <a href="mailto:[email protected]">Contact</a> ] </center>
2025-02-10 12:53:19 : INFO  : texshop : 5.49
2025-02-10 12:53:19 : REQ   : texshop : Downloading https://pages.uoregon.edu/koch/texshop/texshop-64/texshop.zip to TeXShop.zip

After change:

2025-02-10 12:54:43 : INFO  : texshop : setting variable from argument DEBUG=0
2025-02-10 12:54:43 : INFO  : texshop : Total items in argumentsArray: 1
2025-02-10 12:54:43 : INFO  : texshop : argumentsArray: DEBUG=0
2025-02-10 12:54:43 : REQ   : texshop : ################## Start Installomator v. 10.8beta, date 2025-02-10
2025-02-10 12:54:43 : INFO  : texshop : ################## Version: 10.8beta
2025-02-10 12:54:43 : INFO  : texshop : ################## Date: 2025-02-10
2025-02-10 12:54:43 : INFO  : texshop : ################## texshop
2025-02-10 12:54:43 : INFO  : texshop : SwiftDialog is not installed, clear cmd file var
2025-02-10 12:54:44 : INFO  : texshop : Reading arguments again: DEBUG=0
2025-02-10 12:54:44 : INFO  : texshop : BLOCKING_PROCESS_ACTION=tell_user
2025-02-10 12:54:44 : INFO  : texshop : NOTIFY=success
2025-02-10 12:54:44 : INFO  : texshop : LOGGING=INFO
2025-02-10 12:54:44 : INFO  : texshop : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2025-02-10 12:54:44 : INFO  : texshop : Label type: zip
2025-02-10 12:54:44 : INFO  : texshop : archiveName: TeXShop.zip
2025-02-10 12:54:44 : INFO  : texshop : no blocking processes defined, using TeXShop as default
2025-02-10 12:54:44 : INFO  : texshop : App(s) found: /Applications/TeXShop.app
2025-02-10 12:54:44 : INFO  : texshop : found app at /Applications/TeXShop.app, version 5.49, on versionKey CFBundleShortVersionString
2025-02-10 12:54:44 : INFO  : texshop : appversion: 5.49
2025-02-10 12:54:44 : INFO  : texshop : Latest version of TeXShop is 5.49
2025-02-10 12:54:44 : INFO  : texshop : There is no newer version available.
2025-02-10 12:54:44 : INFO  : texshop : Installomator did not close any apps, so no need to reopen any apps.
2025-02-10 12:54:44 : REQ   : texshop : No newer version.
2025-02-10 12:54:44 : REQ   : texshop : ################## End Installomator, exit code 0

Complete label log:

2025-02-10 13:07:19 : INFO  : texshop : Total items in argumentsArray: 0
2025-02-10 13:07:19 : INFO  : texshop : argumentsArray: 
2025-02-10 13:07:19 : REQ   : texshop : ################## Start Installomator v. 10.8beta, date 2025-02-10
2025-02-10 13:07:19 : INFO  : texshop : ################## Version: 10.8beta
2025-02-10 13:07:19 : INFO  : texshop : ################## Date: 2025-02-10
2025-02-10 13:07:19 : INFO  : texshop : ################## texshop
2025-02-10 13:07:19 : DEBUG : texshop : DEBUG mode 1 enabled.
2025-02-10 13:07:19 : INFO  : texshop : SwiftDialog is not installed, clear cmd file var
2025-02-10 13:07:20 : INFO  : texshop : Reading arguments again: 
2025-02-10 13:07:20 : DEBUG : texshop : name=TeXShop
2025-02-10 13:07:20 : DEBUG : texshop : appName=
2025-02-10 13:07:20 : DEBUG : texshop : type=zip
2025-02-10 13:07:20 : DEBUG : texshop : archiveName=
2025-02-10 13:07:20 : DEBUG : texshop : downloadURL=https://pages.uoregon.edu/koch/texshop/texshop-64/texshop.zip
2025-02-10 13:07:20 : DEBUG : texshop : curlOptions=
2025-02-10 13:07:20 : DEBUG : texshop : appNewVersion=5.49
2025-02-10 13:07:20 : DEBUG : texshop : appCustomVersion function: Not defined
2025-02-10 13:07:20 : DEBUG : texshop : versionKey=CFBundleShortVersionString
2025-02-10 13:07:20 : DEBUG : texshop : packageID=
2025-02-10 13:07:20 : DEBUG : texshop : pkgName=
2025-02-10 13:07:20 : DEBUG : texshop : choiceChangesXML=
2025-02-10 13:07:20 : DEBUG : texshop : expectedTeamID=RBGCY5RJWM
2025-02-10 13:07:20 : DEBUG : texshop : blockingProcesses=
2025-02-10 13:07:20 : DEBUG : texshop : installerTool=
2025-02-10 13:07:20 : DEBUG : texshop : CLIInstaller=
2025-02-10 13:07:20 : DEBUG : texshop : CLIArguments=
2025-02-10 13:07:20 : DEBUG : texshop : updateTool=
2025-02-10 13:07:20 : DEBUG : texshop : updateToolArguments=
2025-02-10 13:07:20 : DEBUG : texshop : updateToolRunAsCurrentUser=
2025-02-10 13:07:20 : INFO  : texshop : BLOCKING_PROCESS_ACTION=tell_user
2025-02-10 13:07:20 : INFO  : texshop : NOTIFY=success
2025-02-10 13:07:20 : INFO  : texshop : LOGGING=DEBUG
2025-02-10 13:07:20 : INFO  : texshop : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2025-02-10 13:07:20 : INFO  : texshop : Label type: zip
2025-02-10 13:07:20 : INFO  : texshop : archiveName: TeXShop.zip
2025-02-10 13:07:20 : INFO  : texshop : no blocking processes defined, using TeXShop as default
2025-02-10 13:07:20 : DEBUG : texshop : Changing directory to /Users/kryptonit/Documents/github/Installomator/build
2025-02-10 13:07:20 : INFO  : texshop : name: TeXShop, appName: TeXShop.app
2025-02-10 13:07:20 : WARN  : texshop : No previous app found
2025-02-10 13:07:20 : WARN  : texshop : could not find TeXShop.app
2025-02-10 13:07:20 : INFO  : texshop : appversion: 
2025-02-10 13:07:20 : INFO  : texshop : Latest version of TeXShop is 5.49
2025-02-10 13:07:20 : REQ   : texshop : Downloading https://pages.uoregon.edu/koch/texshop/texshop-64/texshop.zip to TeXShop.zip
2025-02-10 13:07:20 : DEBUG : texshop : No Dialog connection, just download
2025-02-10 13:10:30 : INFO  : texshop : Downloaded TeXShop.zip – Type is  Zip archive data, at least v2.0 to extract, compression method=store – SHA is 87686742407b2a8b9c6fdc7b764f88f2c2289b89 – Size is 81932 kB
2025-02-10 13:10:30 : DEBUG : texshop : DEBUG mode 1, not checking for blocking processes
2025-02-10 13:10:30 : REQ   : texshop : Installing TeXShop
2025-02-10 13:10:30 : INFO  : texshop : Unzipping TeXShop.zip
2025-02-10 13:10:31 : INFO  : texshop : Verifying: /Users/kryptonit/Documents/github/Installomator/build/TeXShop.app
2025-02-10 13:10:31 : DEBUG : texshop : App size:  92M	/Users/kryptonit/Documents/github/Installomator/build/TeXShop.app
2025-02-10 13:10:32 : DEBUG : texshop : Debugging enabled, App Verification output was:
/Users/kryptonit/Documents/github/Installomator/build/TeXShop.app: accepted
source=Notarized Developer ID
origin=Developer ID Application: Richard Koch (RBGCY5RJWM)

2025-02-10 13:10:32 : INFO  : texshop : Team ID matching: RBGCY5RJWM (expected: RBGCY5RJWM )
2025-02-10 13:10:32 : INFO  : texshop : Installing TeXShop version 5.49 on versionKey CFBundleShortVersionString.
2025-02-10 13:10:32 : INFO  : texshop : App has LSMinimumSystemVersion: 10.13.0
2025-02-10 13:10:32 : DEBUG : texshop : DEBUG mode 1 enabled, skipping remove, copy and chown steps
2025-02-10 13:10:32 : INFO  : texshop : Finishing...
2025-02-10 13:10:35 : INFO  : texshop : name: TeXShop, appName: TeXShop.app
2025-02-10 13:10:35 : INFO  : texshop : App(s) found: /Users/kryptonit/Documents/github/Installomator/build/TeXShop.app
2025-02-10 13:10:35 : WARN  : texshop : could not determine location of TeXShop.app
2025-02-10 13:10:35 : REQ   : texshop : Installed TeXShop, version 5.49
2025-02-10 13:10:35 : INFO  : texshop : notifying
displaynotification:7: no such file or directory: /usr/local/bin/dialog
2025-02-10 13:10:35 : DEBUG : texshop : DEBUG mode 1, not reopening anything
2025-02-10 13:10:35 : REQ   : texshop : All done!
2025-02-10 13:10:35 : REQ   : texshop : ################## End Installomator, exit code 0 

The ```appNewVersion``` variable is broken in the current texshop-label:

```
2025-02-10 12:53:18 : INFO  : texshop : setting variable from argument DEBUG=0
2025-02-10 12:53:18 : INFO  : texshop : Total items in argumentsArray: 1
2025-02-10 12:53:18 : INFO  : texshop : argumentsArray: DEBUG=0
2025-02-10 12:53:18 : REQ   : texshop : ################## Start Installomator v. 10.8beta, date 2025-02-10
2025-02-10 12:53:18 : INFO  : texshop : ################## Version: 10.8beta
2025-02-10 12:53:18 : INFO  : texshop : ################## Date: 2025-02-10
2025-02-10 12:53:18 : INFO  : texshop : ################## texshop
2025-02-10 12:53:18 : INFO  : texshop : SwiftDialog is not installed, clear cmd file var
2025-02-10 12:53:19 : INFO  : texshop : Reading arguments again: DEBUG=0
2025-02-10 12:53:19 : INFO  : texshop : BLOCKING_PROCESS_ACTION=tell_user
2025-02-10 12:53:19 : INFO  : texshop : NOTIFY=success
2025-02-10 12:53:19 : INFO  : texshop : LOGGING=INFO
2025-02-10 12:53:19 : INFO  : texshop : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2025-02-10 12:53:19 : INFO  : texshop : Label type: zip
2025-02-10 12:53:19 : INFO  : texshop : archiveName: TeXShop.zip
2025-02-10 12:53:19 : INFO  : texshop : no blocking processes defined, using TeXShop as default
2025-02-10 12:53:19 : INFO  : texshop : App(s) found: /Applications/TeXShop.app
2025-02-10 12:53:19 : INFO  : texshop : found app at /Applications/TeXShop.app, version 5.49, on versionKey CFBundleShortVersionString
2025-02-10 12:53:19 : INFO  : texshop : appversion: 5.49
2025-02-10 12:53:19 : INFO  : texshop : Latest version of TeXShop is <center> [ Direct Download: <a href="texshop-64/texshop.zip">Latest TeXShop</a> | <a href="texshop-64//texshopsource.zip">Latest TeXShop Source</a> ] [ <a href="mailto:[email protected]">Contact</a> ] </center>
2025-02-10 12:53:19 : INFO  : texshop : 5.49
2025-02-10 12:53:19 : REQ   : texshop : Downloading https://pages.uoregon.edu/koch/texshop/texshop-64/texshop.zip to TeXShop.zip
```

After change:

```
2025-02-10 12:54:43 : INFO  : texshop : setting variable from argument DEBUG=0
2025-02-10 12:54:43 : INFO  : texshop : Total items in argumentsArray: 1
2025-02-10 12:54:43 : INFO  : texshop : argumentsArray: DEBUG=0
2025-02-10 12:54:43 : REQ   : texshop : ################## Start Installomator v. 10.8beta, date 2025-02-10
2025-02-10 12:54:43 : INFO  : texshop : ################## Version: 10.8beta
2025-02-10 12:54:43 : INFO  : texshop : ################## Date: 2025-02-10
2025-02-10 12:54:43 : INFO  : texshop : ################## texshop
2025-02-10 12:54:43 : INFO  : texshop : SwiftDialog is not installed, clear cmd file var
2025-02-10 12:54:44 : INFO  : texshop : Reading arguments again: DEBUG=0
2025-02-10 12:54:44 : INFO  : texshop : BLOCKING_PROCESS_ACTION=tell_user
2025-02-10 12:54:44 : INFO  : texshop : NOTIFY=success
2025-02-10 12:54:44 : INFO  : texshop : LOGGING=INFO
2025-02-10 12:54:44 : INFO  : texshop : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2025-02-10 12:54:44 : INFO  : texshop : Label type: zip
2025-02-10 12:54:44 : INFO  : texshop : archiveName: TeXShop.zip
2025-02-10 12:54:44 : INFO  : texshop : no blocking processes defined, using TeXShop as default
2025-02-10 12:54:44 : INFO  : texshop : App(s) found: /Applications/TeXShop.app
2025-02-10 12:54:44 : INFO  : texshop : found app at /Applications/TeXShop.app, version 5.49, on versionKey CFBundleShortVersionString
2025-02-10 12:54:44 : INFO  : texshop : appversion: 5.49
2025-02-10 12:54:44 : INFO  : texshop : Latest version of TeXShop is 5.49
2025-02-10 12:54:44 : INFO  : texshop : There is no newer version available.
2025-02-10 12:54:44 : INFO  : texshop : Installomator did not close any apps, so no need to reopen any apps.
2025-02-10 12:54:44 : REQ   : texshop : No newer version.
2025-02-10 12:54:44 : REQ   : texshop : ################## End Installomator, exit code 0
```
@bartreardon bartreardon added application adds or improves an application label validated App label that has been validated by the validation bot labels Feb 11, 2025
@bartreardon
Copy link
Collaborator

🤖 Validation robot 🤖
File fragments/labels/texshop.sh
** Label info:
├ ✅ correct line ending
├ ✅ Name: TeXShop
├ ✅ Type: zip
├ ✅ Expected Team: RBGCY5RJWM
├ ✅ App New Version: 5.49
└ Download URL: https://pages.uoregon.edu/koch/texshop/texshop-64/texshop.zip
├ ✅ URL is reachable
└ ✅ Download Size: 66.6 MB
✅ All checks passed


@bartreardon bartreardon added this to the v10.8 milestone Mar 21, 2025
@bartreardon
Copy link
Collaborator

Thank you!

@bartreardon bartreardon merged commit 3e939ab into Installomator:main Mar 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application adds or improves an application label validated App label that has been validated by the validation bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants