Closed
Conversation
…ble-for-notifications-
Not enabled for dialogs as it does not look as native as AppleScript (osascript).
This was included too soon, as our variable needs to handle which notifier to use, and not only Swift Dialog.
…fications- `notifier app` variable for notifications
Update island.sh downloadURL
bartreardon
added
invalid
Collaborator
|
Hi @74k1, I switched the branch for this from dev to main and it's brought across a batch of other changes not related to this label. Are you able to pull a fresh copy of main into your fork and resubmit a clean PR? You might be able to clean this one up but could be easier doing a fresh pr from scratch. |
Contributor
Author
|
Oh yeah ofcourse, totally overlooked that. I'll submit a new PR in a little bit then. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All questions must be filled out or your Pull Request will be closed for lack of information. The first three questions should be answered
Yesbefore submitting the pull request.Have you confirmed this pull request is not a duplicate?
Yes
Is this pull request creating or modifying a label in the fragments/labels folder, and not Installomator.sh itself?
Yes
Did you use our editorconfig file?
Yes, didn't need it though
Additional context Add any other context about the label or fix here.
Adds appNewVersion and uses the same download URL specified in appNewVersion instead of an ambiguous link for what appears to be the latest version of Deepl.
Installomator log At the bottom of this pull request, provide a log of a label run by running Installomator in Terminal and saving the output.
DEBUG=1can be enabled but do not enable Debug logging level and please format the log using a code block!Please identify any issues fixed by your pull request by including the issue number. (Example: "Fixes #XXXX")
#1453 can already be closed, as Deepl has already been added with #1372