Update LaunchControl Label#2175
Merged
acodega merged 3 commits intoInstallomator:mainfrom Feb 7, 2025
Merged
Conversation
Output: ```sudo Installomator/utils/assemble.sh launchcontrol DEBUG=0 2025-02-06 08:50:02 : INFO : launchcontrol : setting variable from argument DEBUG=0 2025-02-06 08:50:02 : INFO : launchcontrol : Total items in argumentsArray: 1 2025-02-06 08:50:02 : INFO : launchcontrol : argumentsArray: DEBUG=0 2025-02-06 08:50:02 : REQ : launchcontrol : ################## Start Installomator v. 10.8beta, date 2025-02-06 2025-02-06 08:50:02 : INFO : launchcontrol : ################## Version: 10.8beta 2025-02-06 08:50:02 : INFO : launchcontrol : ################## Date: 2025-02-06 2025-02-06 08:50:02 : INFO : launchcontrol : ################## launchcontrol 2025-02-06 08:50:03 : INFO : launchcontrol : Reading arguments again: DEBUG=0 2025-02-06 08:50:04 : INFO : launchcontrol : BLOCKING_PROCESS_ACTION=tell_user 2025-02-06 08:50:04 : INFO : launchcontrol : NOTIFY=success 2025-02-06 08:50:04 : INFO : launchcontrol : LOGGING=INFO 2025-02-06 08:50:04 : INFO : launchcontrol : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns 2025-02-06 08:50:04 : INFO : launchcontrol : Label type: tbz 2025-02-06 08:50:04 : INFO : launchcontrol : archiveName: LaunchControl.tbz 2025-02-06 08:50:04 : INFO : launchcontrol : no blocking processes defined, using LaunchControl as default 2025-02-06 08:50:04 : INFO : launchcontrol : name: LaunchControl, appName: LaunchControl.app 2025-02-06 08:50:04 : INFO : launchcontrol : App(s) found: /Users/u0105821/git/github/Installomator/build/LaunchControl.app/Users/u0105821/LaunchControl.app/Applications/Utilities/Admin/LaunchControl.app 2025-02-06 08:50:04 : INFO : launchcontrol : found app at /Applications/Utilities/Admin/LaunchControl.app, version 2.6.4, on versionKey CFBundleShortVersionString 2025-02-06 08:50:04 : INFO : launchcontrol : appversion: 2.6.4 2025-02-06 08:50:04 : INFO : launchcontrol : Latest version of LaunchControl is 2.6.4 2025-02-06 08:50:04 : INFO : launchcontrol : There is no newer version available. 2025-02-06 08:50:04 : INFO : launchcontrol : Installomator did not close any apps, so no need to reopen any apps. 2025-02-06 08:50:04 : REQ : launchcontrol : No newer version. 2025-02-06 08:50:04 : REQ : launchcontrol : ################## End Installomator, exit code 0 root@r-glaser-mac-m2-laptop github # sudo Installomator/utils/assemble.sh launchcontrol DEBUG=0 2025-02-06 08:54:08 : INFO : launchcontrol : setting variable from argument DEBUG=0 2025-02-06 08:54:08 : INFO : launchcontrol : Total items in argumentsArray: 1 2025-02-06 08:54:08 : INFO : launchcontrol : argumentsArray: DEBUG=0 2025-02-06 08:54:08 : REQ : launchcontrol : ################## Start Installomator v. 10.8beta, date 2025-02-06 2025-02-06 08:54:08 : INFO : launchcontrol : ################## Version: 10.8beta 2025-02-06 08:54:08 : INFO : launchcontrol : ################## Date: 2025-02-06 2025-02-06 08:54:08 : INFO : launchcontrol : ################## launchcontrol 2025-02-06 08:54:09 : INFO : launchcontrol : Reading arguments again: DEBUG=0 2025-02-06 08:54:10 : INFO : launchcontrol : BLOCKING_PROCESS_ACTION=tell_user 2025-02-06 08:54:10 : INFO : launchcontrol : NOTIFY=success 2025-02-06 08:54:10 : INFO : launchcontrol : LOGGING=INFO 2025-02-06 08:54:10 : INFO : launchcontrol : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns 2025-02-06 08:54:10 : INFO : launchcontrol : Label type: tbz 2025-02-06 08:54:10 : INFO : launchcontrol : archiveName: LaunchControl.tbz 2025-02-06 08:54:10 : INFO : launchcontrol : no blocking processes defined, using LaunchControl as default 2025-02-06 08:54:10 : INFO : launchcontrol : name: LaunchControl, appName: LaunchControl.app 2025-02-06 08:54:10 : INFO : launchcontrol : App(s) found: /Users/u0105821/git/github/Installomator/build/LaunchControl.app/Users/u0105821/LaunchControl.app/Applications/Utilities/Admin/LaunchControl.app 2025-02-06 08:54:10 : INFO : launchcontrol : found app at /Applications/Utilities/Admin/LaunchControl.app, version 2.6.4, on versionKey CFBundleShortVersionString 2025-02-06 08:54:10 : INFO : launchcontrol : appversion: 2.6.4 2025-02-06 08:54:10 : INFO : launchcontrol : Latest version of LaunchControl is 2.8 2025-02-06 08:54:10 : REQ : launchcontrol : Downloading https://www.soma-zone.com/download/files/LaunchControl-2.8.tar.xz to LaunchControl.tbz 2025-02-06 08:54:17 : INFO : launchcontrol : Downloaded LaunchControl.tbz – Type is XZ compressed data, checksum CRC64 – SHA is fd0e33b6e5a9693e21d644e8a937ca3293d7a74c – Size is 6160 kB 2025-02-06 08:54:17 : REQ : launchcontrol : no more blocking processes, continue with update 2025-02-06 08:54:17 : REQ : launchcontrol : Installing LaunchControl 2025-02-06 08:54:17 : INFO : launchcontrol : Unzipping LaunchControl.tbz 2025-02-06 08:54:18 : INFO : launchcontrol : Verifying: /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.58TSQDyUAZ/LaunchControl.app 2025-02-06 08:54:18 : INFO : launchcontrol : Team ID matching: H665B6EEXC (expected: H665B6EEXC ) 2025-02-06 08:54:18 : INFO : launchcontrol : Downloaded version of LaunchControl is 2.8 on versionKey CFBundleShortVersionString (replacing version 2.6.4). 2025-02-06 08:54:18 : INFO : launchcontrol : App has LSMinimumSystemVersion: 11.0 2025-02-06 08:54:18 : INFO : launchcontrol : Copy /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.58TSQDyUAZ/LaunchControl.app to /Applications 2025-02-06 08:54:18 : WARN : launchcontrol : Changing owner to u0105821 2025-02-06 08:54:19 : INFO : launchcontrol : Finishing... 2025-02-06 08:54:22 : INFO : launchcontrol : App(s) found: /Applications/LaunchControl.app 2025-02-06 08:54:22 : INFO : launchcontrol : found app at /Applications/LaunchControl.app, version 2.8, on versionKey CFBundleShortVersionString 2025-02-06 08:54:22 : REQ : launchcontrol : Installed LaunchControl, version 2.8 2025-02-06 08:54:22 : INFO : launchcontrol : notifying 2025-02-06 08:54:22 : INFO : launchcontrol : Installomator did not close any apps, so no need to reopen any apps. 2025-02-06 08:54:22 : REQ : launchcontrol : All done! 2025-02-06 08:54:22 : REQ : launchcontrol : ################## End Installomator, exit code 0```
uurazzle
commented
Feb 6, 2025
Contributor
Author
uurazzle
left a comment
uurazzle
left a comment
There was a problem hiding this comment.
Ok, added ending line feed (LF) to label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All questions must be filled out or your Pull Request will be closed for lack of information. The first three questions should be answered
Yesbefore submitting the pull request.Have you confirmed this pull request is not a duplicate?
Yes
Is this pull request creating or modifying a label in the fragments/labels folder, and not Installomator.sh itself?
yes
Did you use our editorconfig file?
Yes
Additional context Add any other context about the label or fix it here.
The new code addresses several issues that were present in the old version.
Specifically:
Excluding Unwanted Versions: The old code did not filter out Developer Preview (DP) or update versions, which could lead to downloading unreleased or incomplete versions of LaunchControl. The new code uses the grep -vE 'DP|_update' command to exclude such versions, ensuring only stable releases are considered.
Flexibility with Version Numbers: The old code strictly matched version numbers with three parts (e.g., 1.2.3), using the pattern [0-9].[0-9].[0-9]*. In contrast, the new code allows for more flexibility by using [0-9]+.[0-9]+(.[0-9]+)?, which accommodates version numbers with two or three parts (e.g., 1.2 or 1.2.3). This change ensures that even versions with fewer version parts are correctly identified and processed.
Improved Sorting and Selection: By modifying the extraction and filtering steps, the new code ensures the latest suitable version is selected by sorting and taking the last entry (using sort -V | tail -n 1).
Installomator log At the bottom of this pull request, provide a log of a label run by running Installomator in Terminal and saving the output.
DEBUG=1can be enabled but do not enable Debug logging level and please format the log using a code block!Please identify any issues fixed by your pull request by including the issue number. (Example: "Fixes #XXXX")
Output: