Merged
Conversation
Fixed App New Version Key. with "curl -fs https://rode.com/en/release-notes/rode-central | xmllint --html --format - 2>/dev/null | tr '"' '\n' | sed 's/\"\;/\n/g' | grep -i -o "Version .*" | head -1 | cut -w -f2" the output was "rates" instead of the correct version number. When changing "head -1 | cut -w -f2" to "cut -w -f2 | tail -n +2 | head -1" the result is as espected and contains the correct verion number: url -fs https://rode.com/en/release-notes/rode-central | xmllint --html --format - 2>/dev/null | tr '"' '\n' | sed 's/\"\;/\n/g' | grep -i -o "Version .*" | cut -w -f2 | tail -n +2 | head -1 Output: 2.0.62
bartreardon
added
the
validated
Collaborator
|
🤖 Validation robot 🤖 |
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All questions must be filled out or your Pull Request will be closed for lack of information. The first three questions should be answered
Yesbefore submitting the pull request.Have you confirmed this pull request is not a duplicate? Yes
Is this pull request creating or modifying a label in the fragments/labels folder, and not Installomator.sh itself? Yes
Did you use our editorconfig file? No
Additional context
Fixes #2163
As mentioned, appNewVersion is not filled with the right values. This got fixed when changing
head -1 | cut -w -f2tocut -w -f2 | tail -n +2 | head -1at the end of the curl command.The new appNewVersion is now changed to this:
appNewVersion=$(curl -fs https://rode.com/en/release-notes/rode-central | xmllint --html --format - 2>/dev/null | tr '"' '\n' | sed 's/\"\;/\n/g' | grep -i -o "Version .*" | cut -w -f2 | tail -n +2 | head -1)Installomator log
Please identify any issues fixed by your pull request by including the issue number. (Example: "Fixes #XXXX")