Skip to content

Comments

Update app name on wacomdrivers#2149

Merged
acodega merged 2 commits intoInstallomator:mainfrom
BonnierNews:add_wacomdrivers_appCustomVersion
Feb 7, 2025
Merged

Update app name on wacomdrivers#2149
acodega merged 2 commits intoInstallomator:mainfrom
BonnierNews:add_wacomdrivers_appCustomVersion

Conversation

@pmex
Copy link
Contributor

@pmex pmex commented Jan 23, 2025

Have you confirmed this pull request is not a duplicate?
Yes

Is this pull request creating or modifying a label in the fragments/labels folder, and not Installomator.sh itself?
Yes

Did you use our editorconfig file?
Yes

Additional context
App is renamed from Wacom Desktop Center to Wacom Center. Somehow the builtin function for reading the appversion fails, so I've added appCustomVersion, besides changing the name.
Fixes #2148

Installomator log

2025-01-23 13:09:51 : REQ   : wacomdrivers : ################## Start Installomator v. 10.7beta, date 2025-01-23
2025-01-23 13:09:51 : INFO  : wacomdrivers : ################## Version: 10.7beta
2025-01-23 13:09:51 : INFO  : wacomdrivers : ################## Date: 2025-01-23
2025-01-23 13:09:51 : INFO  : wacomdrivers : ################## wacomdrivers
2025-01-23 13:09:56 : INFO  : wacomdrivers : setting variable from argument NOTIFICATIONTYPE=swiftdialog
2025-01-23 13:09:56 : INFO  : wacomdrivers : setting variable from argument NOTIFY=success
2025-01-23 13:09:56 : INFO  : wacomdrivers : setting variable from argument swiftDialogNotification=notification
2025-01-23 13:09:56 : INFO  : wacomdrivers : setting variable from argument SYSTEMOWNER=1
2025-01-23 13:09:56 : INFO  : wacomdrivers : setting variable from argument DEBUG=0
2025-01-23 13:09:56 : INFO  : wacomdrivers : BLOCKING_PROCESS_ACTION=tell_user
2025-01-23 13:09:56 : INFO  : wacomdrivers : NOTIFY=success
2025-01-23 13:09:56 : INFO  : wacomdrivers : LOGGING=INFO
2025-01-23 13:09:56 : INFO  : wacomdrivers : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2025-01-23 13:09:56 : INFO  : wacomdrivers : Label type: pkgInDmg
2025-01-23 13:09:56 : INFO  : wacomdrivers : archiveName: Wacom Center.dmg
2025-01-23 13:09:56 : INFO  : wacomdrivers : no blocking processes defined, using Wacom Center as default
2025-01-23 13:09:56 : INFO  : wacomdrivers : Custom App Version detection is used, found 6.4.8-3
2025-01-23 13:09:56 : INFO  : wacomdrivers : appversion: 6.4.8-3
2025-01-23 13:09:56 : INFO  : wacomdrivers : Latest version of Wacom Center is 6.4.8-3
2025-01-23 13:09:56 : INFO  : wacomdrivers : There is no newer version available.
2025-01-23 13:09:56 : INFO  : wacomdrivers : Installomator did not close any apps, so no need to reopen any apps.
2025-01-23 13:09:56 : REQ   : wacomdrivers : No newer version.
2025-01-23 13:09:56 : REQ   : wacomdrivers : ################## End Installomator, exit code 0

@pmex
Add appCustomVersion to wacomdrivers
09b972c 
Also renamed from Wacom Desktop Center to Wacom Center
@acodega acodega added the application adds or improves an application label label Jan 26, 2025
@acodega
Copy link
Collaborator

acodega commented Jan 27, 2025

CFBundleShortVersionString is what we check by default, can you share a log of a run of the new label without appCustomVersion set? (See Label Variables Reference. appCustomVersion is meant for when you can't/don't want to check an app version or a package receipt,, ie /usr/bin/MyApp --version) versionKey is used if you need to specify something other than CFBundleShortVersionString.

@pmex
Copy link
Contributor Author

pmex commented Jan 28, 2025

The reason I added the appCustomVersion was that my script couldn't find the app during my testing. That made me think that there was some sort of blocker for the built in version check, due to the .localized naming of the app path.

I did a new test run, and it could of course read the app version without appCustomVersion.

The label still needs to be updated though, since the app bundle name has changed.

sudo utils/assemble.sh wacomdrivers NOTIFICATIONTYPE=swiftdialog NOTIFY=success swiftDialogNotification=notification SYSTEMOWNER=1 DEBUG=0
2025-01-28 15:01:01 : INFO  : wacomdrivers : setting variable from argument NOTIFICATIONTYPE=swiftdialog
2025-01-28 15:01:01 : INFO  : wacomdrivers : setting variable from argument NOTIFY=success
2025-01-28 15:01:01 : INFO  : wacomdrivers : setting variable from argument swiftDialogNotification=notification
2025-01-28 15:01:01 : INFO  : wacomdrivers : setting variable from argument SYSTEMOWNER=1
2025-01-28 15:01:01 : INFO  : wacomdrivers : setting variable from argument DEBUG=0
2025-01-28 15:01:01 : INFO  : wacomdrivers : Total items in argumentsArray: 5
2025-01-28 15:01:01 : INFO  : wacomdrivers : argumentsArray: NOTIFICATIONTYPE=swiftdialog NOTIFY=success swiftDialogNotification=notification SYSTEMOWNER=1 DEBUG=0
2025-01-28 15:01:01 : REQ   : wacomdrivers : ################## Start Installomator v. 10.8beta, date 2025-01-28
2025-01-28 15:01:01 : INFO  : wacomdrivers : ################## Version: 10.8beta
2025-01-28 15:01:01 : INFO  : wacomdrivers : ################## Date: 2025-01-28
2025-01-28 15:01:01 : INFO  : wacomdrivers : ################## wacomdrivers
2025-01-28 15:01:06 : INFO  : wacomdrivers : Reading arguments again: NOTIFICATIONTYPE=swiftdialog NOTIFY=success swiftDialogNotification=notification SYSTEMOWNER=1 DEBUG=0
2025-01-28 15:01:06 : INFO  : wacomdrivers : BLOCKING_PROCESS_ACTION=tell_user
2025-01-28 15:01:06 : INFO  : wacomdrivers : NOTIFY=success
2025-01-28 15:01:06 : INFO  : wacomdrivers : LOGGING=INFO
2025-01-28 15:01:06 : INFO  : wacomdrivers : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2025-01-28 15:01:06 : INFO  : wacomdrivers : Label type: pkgInDmg
2025-01-28 15:01:06 : INFO  : wacomdrivers : archiveName: Wacom Center.dmg
2025-01-28 15:01:06 : INFO  : wacomdrivers : no blocking processes defined, using Wacom Center as default
2025-01-28 15:01:06 : INFO  : wacomdrivers : name: Wacom Center, appName: Wacom Center.app
2025-01-28 15:01:07 : INFO  : wacomdrivers : App(s) found: /Applications/Wacom Tablet.localized/Wacom Center.app
2025-01-28 15:01:07 : INFO  : wacomdrivers : found app at /Applications/Wacom Tablet.localized/Wacom Center.app, version 6.4.8-3, on versionKey CFBundleShortVersionString
2025-01-28 15:01:07 : INFO  : wacomdrivers : appversion: 6.4.8-3
2025-01-28 15:01:07 : INFO  : wacomdrivers : Latest version of Wacom Center is 6.4.8-3
2025-01-28 15:01:07 : INFO  : wacomdrivers : There is no newer version available.
2025-01-28 15:01:07 : INFO  : wacomdrivers : Installomator did not close any apps, so no need to reopen any apps.
2025-01-28 15:01:07 : REQ   : wacomdrivers : No newer version.
2025-01-28 15:01:07 : REQ   : wacomdrivers : ################## End Installomator, exit code 0

@acodega acodega merged commit 64a8f8a into Installomator:main Feb 7, 2025
1 check passed
@acodega acodega changed the title Add appCustomVersion to wacomdrivers Update app name on wacomdrivers Feb 7, 2025
@acodega acodega added this to the v10.8 milestone Feb 7, 2025
@pmex pmex deleted the add_wacomdrivers_appCustomVersion branch February 7, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

application adds or improves an application label

Projects

None yet

Milestone

v10.8

Development

Successfully merging this pull request may close these issues.

Broken app label: wacomdrivers

2 participants

@pmex @acodega