Skip to content

Comments

Better appNewVersion for 1Password8#2144

Merged
acodega merged 3 commits intoInstallomator:mainfrom
BonnierNews:1Password8_better_appNewVersion
Feb 2, 2025
Merged

Better appNewVersion for 1Password8#2144
acodega merged 3 commits intoInstallomator:mainfrom
BonnierNews:1Password8_better_appNewVersion

Conversation

@pmex
Copy link
Contributor

@pmex pmex commented Jan 23, 2025

Have you confirmed this pull request is not a duplicate?
Yes

Is this pull request creating or modifying a label in the fragments/labels folder, and not Installomator.sh itself?
Yes

Did you use our editorconfig file?
Yes

Additional context
I found it was possible to get the appNewVersion directly, instead of using the intermediate $relBuildVer.
This fixes #2099 (which is the sole reason for this PR)

Installomator log

2025-01-23 08:42:01 : REQ   : 1password8 : ################## Start Installomator v. 10.7beta, date 2025-01-23
2025-01-23 08:42:01 : INFO  : 1password8 : ################## Version: 10.7beta
2025-01-23 08:42:01 : INFO  : 1password8 : ################## Date: 2025-01-23
2025-01-23 08:42:01 : INFO  : 1password8 : ################## 1password8
2025-01-23 08:42:01 : DEBUG : 1password8 : DEBUG mode 1 enabled.
2025-01-23 08:42:01 : INFO  : 1password8 : setting variable from argument NOTIFICATIONTYPE=swiftdialog
2025-01-23 08:42:01 : INFO  : 1password8 : setting variable from argument NOTIFY=success
2025-01-23 08:42:02 : INFO  : 1password8 : setting variable from argument swiftDialogNotification=notification
2025-01-23 08:42:02 : INFO  : 1password8 : setting variable from argument SYSTEMOWNER=1
2025-01-23 08:42:02 : INFO  : 1password8 : setting variable from argument DEBUG=0
2025-01-23 08:42:02 : DEBUG : 1password8 : name=1Password
2025-01-23 08:42:02 : DEBUG : 1password8 : appName=
2025-01-23 08:42:02 : DEBUG : 1password8 : type=pkg
2025-01-23 08:42:02 : DEBUG : 1password8 : archiveName=
2025-01-23 08:42:02 : DEBUG : 1password8 : downloadURL=https://downloads.1password.com/mac/1Password.pkg
2025-01-23 08:42:02 : DEBUG : 1password8 : curlOptions=
2025-01-23 08:42:02 : DEBUG : 1password8 : appNewVersion=8.10.58
2025-01-23 08:42:02 : DEBUG : 1password8 : appCustomVersion function: Not defined
2025-01-23 08:42:02 : DEBUG : 1password8 : versionKey=CFBundleShortVersionString
2025-01-23 08:42:02 : DEBUG : 1password8 : packageID=com.1password.1password
2025-01-23 08:42:02 : DEBUG : 1password8 : pkgName=
2025-01-23 08:42:02 : DEBUG : 1password8 : choiceChangesXML=
2025-01-23 08:42:02 : DEBUG : 1password8 : expectedTeamID=2BUA8C4S2C
2025-01-23 08:42:02 : DEBUG : 1password8 : blockingProcesses=1Password Extension Helper 1Password 7 1Password 8 1Password 1PasswordNativeMessageHost 1PasswordSafariAppExtension
2025-01-23 08:42:02 : DEBUG : 1password8 : installerTool=
2025-01-23 08:42:02 : DEBUG : 1password8 : CLIInstaller=
2025-01-23 08:42:02 : DEBUG : 1password8 : CLIArguments=
2025-01-23 08:42:02 : DEBUG : 1password8 : updateTool=
2025-01-23 08:42:02 : DEBUG : 1password8 : updateToolArguments=
2025-01-23 08:42:02 : DEBUG : 1password8 : updateToolRunAsCurrentUser=
2025-01-23 08:42:02 : INFO  : 1password8 : BLOCKING_PROCESS_ACTION=tell_user
2025-01-23 08:42:02 : INFO  : 1password8 : NOTIFY=success
2025-01-23 08:42:02 : INFO  : 1password8 : LOGGING=DEBUG
2025-01-23 08:42:02 : INFO  : 1password8 : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2025-01-23 08:42:02 : INFO  : 1password8 : Label type: pkg
2025-01-23 08:42:02 : INFO  : 1password8 : archiveName: 1Password.pkg
2025-01-23 08:42:02 : DEBUG : 1password8 : Changing directory to /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.AsOYLf0R0q
2025-01-23 08:42:02 : INFO  : 1password8 : found packageID com.1password.1password installed, version 8.10.58
2025-01-23 08:42:02 : INFO  : 1password8 : appversion: 8.10.58
2025-01-23 08:42:02 : INFO  : 1password8 : Latest version of 1Password is 8.10.58
2025-01-23 08:42:02 : INFO  : 1password8 : There is no newer version available.
2025-01-23 08:42:02 : DEBUG : 1password8 : Deleting /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.AsOYLf0R0q
2025-01-23 08:42:02 : DEBUG : 1password8 : Debugging enabled, Deleting tmpDir output was:
/var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.AsOYLf0R0q
2025-01-23 08:42:02 : INFO  : 1password8 : Installomator did not close any apps, so no need to reopen any apps.
2025-01-23 08:42:02 : REQ   : 1password8 : No newer version.
2025-01-23 08:42:02 : REQ   : 1password8 : ################## End Installomator, exit code 0

@acodega acodega added the application adds or improves an application label label Jan 26, 2025
@acodega
Copy link
Collaborator

acodega commented Jan 27, 2025

Unfortunately, looks like this broke again, perhaps with the latest post on January 21 for a new beta version. Can you re-review?

@pmex
Copy link
Contributor Author

pmex commented Jan 28, 2025

It should work for now. I (or someone else) will eventually need to find the url that the app is checking.

Password:
2025-01-28 16:01:20 : REQ   : 1password8 : ################## Start Installomator v. 10.7beta, date 2025-01-28
2025-01-28 16:01:20 : INFO  : 1password8 : ################## Version: 10.7beta
2025-01-28 16:01:20 : INFO  : 1password8 : ################## Date: 2025-01-28
2025-01-28 16:01:20 : INFO  : 1password8 : ################## 1password8
2025-01-28 16:01:20 : DEBUG : 1password8 : DEBUG mode 1 enabled.
2025-01-28 16:01:21 : INFO  : 1password8 : setting variable from argument NOTIFICATIONTYPE=swiftdialog
2025-01-28 16:01:21 : INFO  : 1password8 : setting variable from argument NOTIFY=success
2025-01-28 16:01:21 : INFO  : 1password8 : setting variable from argument swiftDialogNotification=notification
2025-01-28 16:01:21 : INFO  : 1password8 : setting variable from argument SYSTEMOWNER=1
2025-01-28 16:01:21 : INFO  : 1password8 : setting variable from argument DEBUG=0
2025-01-28 16:01:21 : DEBUG : 1password8 : name=1Password
2025-01-28 16:01:21 : DEBUG : 1password8 : appName=
2025-01-28 16:01:21 : DEBUG : 1password8 : type=pkg
2025-01-28 16:01:21 : DEBUG : 1password8 : archiveName=
2025-01-28 16:01:21 : DEBUG : 1password8 : downloadURL=https://downloads.1password.com/mac/1Password.pkg
2025-01-28 16:01:21 : DEBUG : 1password8 : curlOptions=
2025-01-28 16:01:21 : DEBUG : 1password8 : appNewVersion=8.10.58
2025-01-28 16:01:21 : DEBUG : 1password8 : appCustomVersion function: Not defined
2025-01-28 16:01:21 : DEBUG : 1password8 : versionKey=CFBundleShortVersionString
2025-01-28 16:01:21 : DEBUG : 1password8 : packageID=com.1password.1password
2025-01-28 16:01:21 : DEBUG : 1password8 : pkgName=
2025-01-28 16:01:21 : DEBUG : 1password8 : choiceChangesXML=
2025-01-28 16:01:21 : DEBUG : 1password8 : expectedTeamID=2BUA8C4S2C
2025-01-28 16:01:21 : DEBUG : 1password8 : blockingProcesses=1Password Extension Helper 1Password 7 1Password 8 1Password 1PasswordNativeMessageHost 1PasswordSafariAppExtension
2025-01-28 16:01:21 : DEBUG : 1password8 : installerTool=
2025-01-28 16:01:21 : DEBUG : 1password8 : CLIInstaller=
2025-01-28 16:01:21 : DEBUG : 1password8 : CLIArguments=
2025-01-28 16:01:21 : DEBUG : 1password8 : updateTool=
2025-01-28 16:01:21 : DEBUG : 1password8 : updateToolArguments=
2025-01-28 16:01:21 : DEBUG : 1password8 : updateToolRunAsCurrentUser=
2025-01-28 16:01:21 : INFO  : 1password8 : BLOCKING_PROCESS_ACTION=tell_user
2025-01-28 16:01:21 : INFO  : 1password8 : NOTIFY=success
2025-01-28 16:01:21 : INFO  : 1password8 : LOGGING=DEBUG
2025-01-28 16:01:21 : INFO  : 1password8 : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2025-01-28 16:01:21 : INFO  : 1password8 : Label type: pkg
2025-01-28 16:01:21 : INFO  : 1password8 : archiveName: 1Password.pkg
2025-01-28 16:01:21 : DEBUG : 1password8 : Changing directory to /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.80lnmpOvJn
2025-01-28 16:01:21 : INFO  : 1password8 : found packageID com.1password.1password installed, version 8.10.58
2025-01-28 16:01:21 : INFO  : 1password8 : appversion: 8.10.58
2025-01-28 16:01:21 : INFO  : 1password8 : Latest version of 1Password is 8.10.58
2025-01-28 16:01:21 : INFO  : 1password8 : There is no newer version available.
2025-01-28 16:01:21 : DEBUG : 1password8 : Deleting /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.80lnmpOvJn
2025-01-28 16:01:21 : DEBUG : 1password8 : Debugging enabled, Deleting tmpDir output was:
/var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.80lnmpOvJn
2025-01-28 16:01:21 : INFO  : 1password8 : Installomator did not close any apps, so no need to reopen any apps.
2025-01-28 16:01:21 : REQ   : 1password8 : No newer version.
2025-01-28 16:01:21 : REQ   : 1password8 : ################## End Installomator, exit code 0

@acodega acodega merged commit 9921b4f into Installomator:main Feb 2, 2025
1 check passed
@acodega acodega mentioned this pull request Feb 2, 2025
Closed
@pmex pmex deleted the 1Password8_better_appNewVersion branch February 7, 2025 18:42
@scriptingosx scriptingosx mentioned this pull request Mar 28, 2025
Closed
@acodega acodega modified the milestone: v10.9 May 30, 2025
@acodega acodega added this to the v10.9 milestone Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

application adds or improves an application label

Projects

None yet

Milestone

v10.9

Development

Successfully merging this pull request may close these issues.

Broken app label: 1Password 8

3 participants

@pmex @acodega @scriptingosx