Skip to content

Comments

Fix appNewVersion plus add CLIInstaller for Tunnelblick#2141

Merged
bartreardon merged 1 commit intoInstallomator:mainfrom
BonnierNews:tunnelblick_fix_appNewVersion_add_CLIInstaller
Feb 10, 2025
Merged

Fix appNewVersion plus add CLIInstaller for Tunnelblick#2141
bartreardon merged 1 commit intoInstallomator:mainfrom
BonnierNews:tunnelblick_fix_appNewVersion_add_CLIInstaller

Conversation

@pmex
Copy link
Contributor

@pmex pmex commented Jan 22, 2025

All questions must be filled out or your Pull Request will be closed for lack of information. The first three questions should be answered Yes before submitting the pull request.

Have you confirmed this pull request is not a duplicate?
Yes

Is this pull request creating or modifying a label in the fragments/labels folder, and not Installomator.sh itself?
Yes

Did you use our editorconfig file?
Yes

Additional context
Initially this was to eliminate the need for post install authentication, which was solved by adding the CLIInstaller (reference: https://tunnelblick.net/cInstallFromCommandLine.html).
As a bonus I found that I also could fix #1270

Installomator log

sudo utils/assemble.sh tunnelblick NOTIFICATIONTYPE=swiftdialog NOTIFY=success swiftDialogNotification=notification SYSTEMOWNER=1 DEBUG=1
2025-01-22 09:23:26 : REQ   : tunnelblick : ################## Start Installomator v. 10.7beta, date 2025-01-22
2025-01-22 09:23:26 : INFO  : tunnelblick : ################## Version: 10.7beta
2025-01-22 09:23:26 : INFO  : tunnelblick : ################## Date: 2025-01-22
2025-01-22 09:23:26 : INFO  : tunnelblick : ################## tunnelblick
2025-01-22 09:23:26 : DEBUG : tunnelblick : DEBUG mode 1 enabled.
2025-01-22 09:23:27 : INFO  : tunnelblick : setting variable from argument NOTIFICATIONTYPE=swiftdialog
2025-01-22 09:23:27 : INFO  : tunnelblick : setting variable from argument NOTIFY=success
2025-01-22 09:23:27 : INFO  : tunnelblick : setting variable from argument swiftDialogNotification=notification
2025-01-22 09:23:27 : INFO  : tunnelblick : setting variable from argument SYSTEMOWNER=1
2025-01-22 09:23:27 : INFO  : tunnelblick : setting variable from argument DEBUG=1
2025-01-22 09:23:27 : DEBUG : tunnelblick : name=Tunnelblick
2025-01-22 09:23:27 : DEBUG : tunnelblick : appName=
2025-01-22 09:23:27 : DEBUG : tunnelblick : type=dmg
2025-01-22 09:23:27 : DEBUG : tunnelblick : archiveName=
2025-01-22 09:23:27 : DEBUG : tunnelblick : downloadURL=https://github.com/Tunnelblick/Tunnelblick/releases/download/v6.0beta09/Tunnelblick_6.0beta09_build_6130.dmg
2025-01-22 09:23:27 : DEBUG : tunnelblick : curlOptions=
2025-01-22 09:23:27 : DEBUG : tunnelblick : appNewVersion=6.0beta09 (build 6130)
2025-01-22 09:23:27 : DEBUG : tunnelblick : appCustomVersion function: Not defined
2025-01-22 09:23:27 : DEBUG : tunnelblick : versionKey=CFBundleShortVersionString
2025-01-22 09:23:27 : DEBUG : tunnelblick : packageID=
2025-01-22 09:23:27 : DEBUG : tunnelblick : pkgName=
2025-01-22 09:23:28 : DEBUG : tunnelblick : choiceChangesXML=
2025-01-22 09:23:28 : DEBUG : tunnelblick : expectedTeamID=Z2SG5H3HC8
2025-01-22 09:23:28 : DEBUG : tunnelblick : blockingProcesses=
2025-01-22 09:23:28 : DEBUG : tunnelblick : installerTool=
2025-01-22 09:23:28 : DEBUG : tunnelblick : CLIInstaller=/Tunnelblick.app/Contents/Resources/installer
2025-01-22 09:23:28 : DEBUG : tunnelblick : CLIArguments=259
2025-01-22 09:23:28 : DEBUG : tunnelblick : updateTool=
2025-01-22 09:23:28 : DEBUG : tunnelblick : updateToolArguments=
2025-01-22 09:23:28 : DEBUG : tunnelblick : updateToolRunAsCurrentUser=
2025-01-22 09:23:28 : INFO  : tunnelblick : BLOCKING_PROCESS_ACTION=tell_user
2025-01-22 09:23:28 : INFO  : tunnelblick : NOTIFY=success
2025-01-22 09:23:28 : INFO  : tunnelblick : LOGGING=DEBUG
2025-01-22 09:23:28 : INFO  : tunnelblick : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2025-01-22 09:23:28 : INFO  : tunnelblick : Label type: dmg
2025-01-22 09:23:28 : INFO  : tunnelblick : archiveName: Tunnelblick.dmg
2025-01-22 09:23:28 : INFO  : tunnelblick : no blocking processes defined, using Tunnelblick as default
2025-01-22 09:23:28 : DEBUG : tunnelblick : Changing directory to /Volumes/Data/Power/Programmerat/Installomator/build
2025-01-22 09:23:28 : INFO  : tunnelblick : App(s) found: /Applications/Tunnelblick.app
2025-01-22 09:23:28 : INFO  : tunnelblick : found app at /Applications/Tunnelblick.app, version 6.0beta09 (build 6130), on versionKey CFBundleShortVersionString
2025-01-22 09:23:28 : INFO  : tunnelblick : appversion: 6.0beta09 (build 6130)
2025-01-22 09:23:28 : INFO  : tunnelblick : Latest version of Tunnelblick is 6.0beta09 (build 6130)
2025-01-22 09:23:28 : WARN  : tunnelblick : DEBUG mode 1 enabled, not exiting, but there is no new version of app.
2025-01-22 09:23:28 : INFO  : tunnelblick : Tunnelblick.dmg exists and DEBUG mode 1 enabled, skipping download
2025-01-22 09:23:28 : DEBUG : tunnelblick : DEBUG mode 1, not checking for blocking processes
2025-01-22 09:23:28 : REQ   : tunnelblick : Installing Tunnelblick
2025-01-22 09:23:28 : INFO  : tunnelblick : Mounting /Volumes/Data/Power/Programmerat/Installomator/build/Tunnelblick.dmg
2025-01-22 09:23:28 : DEBUG : tunnelblick : Debugging enabled, dmgmount output was:
förväntade   CRC32 $2850EC41
/dev/disk4              GUID_partition_scheme
/dev/disk4s1            Apple_HFS                       /Volumes/Tunnelblick

2025-01-22 09:23:28 : INFO  : tunnelblick : Mounted: /Volumes/Tunnelblick
2025-01-22 09:23:28 : INFO  : tunnelblick : Verifying: /Volumes/Tunnelblick/Tunnelblick.app
2025-01-22 09:23:29 : DEBUG : tunnelblick : App size:  46M      /Volumes/Tunnelblick/Tunnelblick.app
2025-01-22 09:23:29 : DEBUG : tunnelblick : Debugging enabled, App Verification output was:
/Volumes/Tunnelblick/Tunnelblick.app: accepted
source=Notarized Developer ID
origin=Developer ID Application: Jonathan Bullard (Z2SG5H3HC8)

2025-01-22 09:23:29 : INFO  : tunnelblick : Team ID matching: Z2SG5H3HC8 (expected: Z2SG5H3HC8 )
2025-01-22 09:23:29 : INFO  : tunnelblick : Downloaded version of Tunnelblick is 6.0beta09 (build 6130) on versionKey CFBundleShortVersionString, same as installed.
2025-01-22 09:23:29 : DEBUG : tunnelblick : Unmounting /Volumes/Tunnelblick
2025-01-22 09:23:31 : DEBUG : tunnelblick : Debugging enabled, Unmounting output was:
"disk4" ejected.
2025-01-22 09:23:31 : DEBUG : tunnelblick : DEBUG mode 1, not reopening anything
2025-01-22 09:23:31 : REG   : tunnelblick : No new version to install
2025-01-22 09:23:31 : REQ   : tunnelblick : ################## End Installomator, exit code 0

@acodega acodega added the application adds or improves an application label label Jan 26, 2025
@bartreardon bartreardon added the validated App label that has been validated by the validation bot label Feb 7, 2025
@bartreardon
Copy link
Collaborator

bartreardon commented Feb 7, 2025

🤖 Validation robot 🤖
File fragments/labels/tunnelblick.sh
** Label info:
├ ✅ correct line ending
├ ✅ Name: Tunnelblick
├ ✅ Type: dmg
├ ✅ Expected Team: Z2SG5H3HC8
├ ✅ App New Version: 6.0beta10 (build 6140)
└ Download URL: https://github.com/Tunnelblick/Tunnelblick/releases/download/v6.0beta10/Tunnelblick_6.0beta10_build_6140.dmg
├ ✅ URL is reachable
└ ✅ Download Size: 19.9 MB
✅ All checks passed

@bartreardon bartreardon added this to the v10.8 milestone Feb 7, 2025
@bartreardon
Copy link
Collaborator

bartreardon commented Feb 10, 2025

Thank you!

@bartreardon bartreardon merged commit 1cf0cd4 into Installomator:main Feb 10, 2025
1 check passed
@pmex pmex deleted the tunnelblick_fix_appNewVersion_add_CLIInstaller branch February 10, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

application adds or improves an application label validated App label that has been validated by the validation bot

Projects

None yet

Milestone

v10.8

Development

Successfully merging this pull request may close these issues.

tunnelblick updates even if already updated

3 participants

@pmex @bartreardon @acodega