Cleanup of the zoomrooms label#2122
Conversation
|
I can't find any reference to Zoom Presence? I think I'm overlooking it. |
acodega
added
application
|
The product is advertised as ZoomRooms and installer pkg is labeled as such as well. But the installed app is called "ZoomPresence.app" I left the label file name as zoomrooms.sh and the zoomrooms case statement. 
|
|
It's an odd situation. 😁 |
|
Awesome thanks for that. Wow. we've had the ZoomPresence blocking action for four years actually. |
|
You would need the blocking action set, when the name key was set to "ZoomRooms". 😁 |
|
(I know this was merged, and a while ago, but I just saw it in the Installomator 10.8 release.) While I agree this label is now cleaner, I want to point out how Installomator's blocking process logic interacts with Zoom Rooms. When Installomator kills the ZoomPresence process, it just gets relaunched by whatever is monitoring ZoomPresence. The installer pkg then safely kills the process, upgrades, and then relaunches it. We used (And it's probably fair to say that when used in unattended conference rooms, none of the prompting actions should ever used.) |
|
You could set the blocking processes list to an empty list. PRs that give the reasoning you just gave will be accepted |
4 participants
All questions must be filled out or your Pull Request will be closed for lack of information. The first three questions should be answered
Yesbefore submitting the pull request.Have you confirmed this pull request is not a duplicate?
YES
Is this pull request creating or modifying a label in the fragments/labels folder, and not Installomator.sh itself?
YES
Did you use our editorconfig file?
YES
Additional context Add any other context about the label or fix here.
Removed the unnecessary packageID and blockingProcesses keys. Updated the name key to reflect the current real name.
Would you prefer the file name also be renamed? I wasn't sure on that. I can make that change if need be.
Installomator log At the bottom of this pull request, provide a log of a label run by running Installomator in Terminal and saving the output.
DEBUG=1can be enabled but do not enable Debug logging level and please format the log using a code block!Please identify any issues fixed by your pull request by including the issue number. (Example: "Fixes #XXXX")