Skip to content

Comments

Update privileges.sh#2075

Closed
d3xbot wants to merge 2 commits intoInstallomator:mainfrom
d3xbot:patch-1
Closed

Update privileges.sh#2075
d3xbot wants to merge 2 commits intoInstallomator:mainfrom
d3xbot:patch-1

Conversation

@d3xbot
Copy link
Contributor

@d3xbot d3xbot commented Dec 12, 2024

Changed package type to PKG and added packageID from buildlabels.sh

Output from previous version of this label (when run from Jamf policy)

Executing Policy SAP Privileges
Running script Installomator 10...
Script exit code: 8
Script result: 2024-12-12 16:21:29 : REQ   :  : shifting arguments for Jamf
2024-12-12 16:21:29 : REQ   : privileges : ################## Start Installomator v. 10.6, date 2024-08-30
2024-12-12 16:21:29 : INFO  : privileges : ################## Version: 10.6
2024-12-12 16:21:29 : INFO  : privileges : ################## Date: 2024-08-30
2024-12-12 16:21:29 : INFO  : privileges : ################## privileges
2024-12-12 16:21:29 : INFO  : privileges : SwiftDialog is not installed, clear cmd file var
grep: repetition-operator operand invalid
2024-12-12 16:21:30 : INFO  : privileges : BLOCKING_PROCESS_ACTION=tell_user
2024-12-12 16:21:30 : INFO  : privileges : NOTIFY=all
2024-12-12 16:21:30 : INFO  : privileges : LOGGING=INFO
2024-12-12 16:21:30 : INFO  : privileges : LOGO=/Library/Application Support/JAMF/Jamf.app/Contents/Resources/AppIcon.icns
2024-12-12 16:21:30 : INFO  : privileges : Label type: zip
2024-12-12 16:21:30 : INFO  : privileges : archiveName: Privileges_[0-9.]*+.pkg
2024-12-12 16:21:30 : INFO  : privileges : no blocking processes defined, using Privileges as default
2024-12-12 16:21:30 : INFO  : privileges : App(s) found: /Applications/Privileges.app
2024-12-12 16:21:30 : INFO  : privileges : found app at /Applications/Privileges.app, version 1.5.4, on versionKey CFBundleShortVersionString
2024-12-12 16:21:30 : INFO  : privileges : appversion: 1.5.4
2024-12-12 16:21:30 : INFO  : privileges : Latest version of Privileges is 2.0.0
2024-12-12 16:21:30 : REQ   : privileges : Downloading https://github.com to Privileges_[0-9.]*+.pkg
2024-12-12 16:21:30 : INFO  : privileges : notifying
displaynotification:7: no such file or directory: /usr/local/bin/dialog
2024-12-12 16:21:31 : REQ   : privileges : no more blocking processes, continue with update
2024-12-12 16:21:31 : REQ   : privileges : Installing Privileges
2024-12-12 16:21:31 : INFO  : privileges : notifying
displaynotification:7: no such file or directory: /usr/local/bin/dialog
2024-12-12 16:21:31 : INFO  : privileges : Unzipping Privileges_[0-9.]*+.pkg
ditto: Couldn't read PKZip signature
2024-12-12 16:21:31 : INFO  : privileges : Installomator did not close any apps, so no need to reopen any apps.
2024-12-12 16:21:31 : ERROR : privileges : ERROR: could not find: /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.HBRVsnVFsx/Privileges.app
2024-12-12 16:21:31 : REQ   : privileges : ################## End Installomator, exit code 8

I noticed that the Privileges app had been recently updated and no longer ships as a .zip archive but as a .pkg installer
-> Ran buildlabels.sh against the new version and verified that it works as expected

Output from the updated label, again from a Jamf policy:

Executing Policy SAP Privileges
Running script Installomator 10...
Script exit code: 0
Script result: 2024-12-12 16:27:33 : REQ   :  : shifting arguments for Jamf
2024-12-12 16:27:33 : REQ   : privileges : ################## Start Installomator v. 10.6, date 2024-08-30
2024-12-12 16:27:33 : INFO  : privileges : ################## Version: 10.6
2024-12-12 16:27:33 : INFO  : privileges : ################## Date: 2024-08-30
2024-12-12 16:27:33 : INFO  : privileges : ################## privileges
2024-12-12 16:27:33 : INFO  : privileges : SwiftDialog is not installed, clear cmd file var
2024-12-12 16:27:34 : INFO  : privileges : BLOCKING_PROCESS_ACTION=tell_user
2024-12-12 16:27:34 : INFO  : privileges : NOTIFY=all
2024-12-12 16:27:34 : INFO  : privileges : LOGGING=INFO
2024-12-12 16:27:34 : INFO  : privileges : LOGO=/Library/Application Support/JAMF/Jamf.app/Contents/Resources/AppIcon.icns
2024-12-12 16:27:34 : INFO  : privileges : Label type: pkg
2024-12-12 16:27:34 : INFO  : privileges : archiveName: Privileges_2.0.0.pkg
2024-12-12 16:27:34 : INFO  : privileges : no blocking processes defined, using Privileges_2.0.0 as default
2024-12-12 16:27:34 : INFO  : privileges : No version found using packageID corp.sap.privileges.pkg
2024-12-12 16:27:34 : INFO  : privileges : name: Privileges_2.0.0, appName: Privileges_2.0.0.app
2024-12-12 16:27:34.265 mdfind[15717:67062042] [UserQueryParser] Loading keywords and predicates for locale "en_US"
2024-12-12 16:27:34.266 mdfind[15717:67062042] [UserQueryParser] Loading keywords and predicates for locale "en"
2024-12-12 16:27:34.344 mdfind[15717:67062042] Couldn't determine the mapping between prefab keywords and predicates.
2024-12-12 16:27:34 : WARN  : privileges : No previous app found
2024-12-12 16:27:34 : WARN  : privileges : could not find Privileges_2.0.0.app
2024-12-12 16:27:34 : INFO  : privileges : appversion: 
2024-12-12 16:27:34 : INFO  : privileges : Latest version of Privileges_2.0.0 is 2.0.0
2024-12-12 16:27:34 : REQ   : privileges : Downloading https://github.com/SAP/macOS-enterprise-privileges/releases/download/2.0.0/Privileges_2.0.0.pkg to Privileges_2.0.0.pkg
2024-12-12 16:27:34 : INFO  : privileges : notifying
displaynotification:7: no such file or directory: /usr/local/bin/dialog
2024-12-12 16:27:34 : REQ   : privileges : no more blocking processes, continue with update
2024-12-12 16:27:34 : REQ   : privileges : Installing Privileges_2.0.0
2024-12-12 16:27:34 : INFO  : privileges : notifying
displaynotification:7: no such file or directory: /usr/local/bin/dialog
2024-12-12 16:27:34 : INFO  : privileges : Verifying: Privileges_2.0.0.pkg
2024-12-12 16:27:35 : INFO  : privileges : Team ID: 7R5ZEU67FQ (expected: 7R5ZEU67FQ )
2024-12-12 16:27:35 : INFO  : privileges : Installing Privileges_2.0.0.pkg to /
2024-12-12 16:27:44 : INFO  : privileges : Finishing...
2024-12-12 16:27:47 : INFO  : privileges : found packageID corp.sap.privileges.pkg installed, version 2.0.0
2024-12-12 16:27:47 : REQ   : privileges : Installed Privileges_2.0.0, version 2.0.0
2024-12-12 16:27:47 : INFO  : privileges : notifying
displaynotification:7: no such file or directory: /usr/local/bin/dialog
2024-12-12 16:27:47 : INFO  : privileges : Installomator did not close any apps, so no need to reopen any apps.
2024-12-12 16:27:48 : REQ   : privileges : All done!
2024-12-12 16:27:48 : REQ   : privileges : ################## End Installomator, exit code 0

@d3xbot
Update privileges.sh
d27be41 
Changed package type to PKG and added packageID from buildlabels.sh
@d3xbot
Copy link
Contributor Author

d3xbot commented Dec 12, 2024

Hello! This is my first contribution to this project. I hope I've written this PR appropriately!

I'm glad to finally contribute to this excellent project that's made my life as a Mac Admin so much easier!

@acodega
Copy link
Collaborator

acodega commented Dec 13, 2024

Thanks for contributing, Privileges is a unique one (but not the first of it's kind) where we need to be mindful about changes. People probably won't want Installomator silently updating Privileges when there's been a UI overhaul, and managing the app is now done differently.

We discussed this on #2039 and it's preferred that a new label is made, privileges2. No one's made that label though, so you can change this PR to the new label name.

@acodega acodega added the application adds or improves an application label label Dec 13, 2024
@acodega acodega added this to the v10.7 milestone Dec 13, 2024
@d3xbot
Update privileges.sh
f54cc9c 
Updated label name per PR discussion
@d3xbot
Copy link
Contributor Author

d3xbot commented Dec 13, 2024

Alright! I've updated this PR with the label name privileges2. Thanks for the link to the previous PR with the discussion

@acodega
Copy link
Collaborator

acodega commented Dec 16, 2024

To be clear I meant make a new label, the existing privileges label would stay.

@d3xbot
Copy link
Contributor Author

d3xbot commented Dec 17, 2024

Ah. Now I'm tracking. I'll do that instead! Thanks for the guidance!

@d3xbot d3xbot closed this Dec 17, 2024
@d3xbot d3xbot mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

application adds or improves an application label waiting for response

Projects

None yet

Milestone

v10.7

Development

Successfully merging this pull request may close these issues.

2 participants

@d3xbot @acodega