Skip to content

Comments

Update citrixworkspace.sh appNewVersion#2057

Merged
acodega merged 1 commit intoInstallomator:mainfrom
Allingtonbe:citrixworkspace
Jan 22, 2025
Merged

Update citrixworkspace.sh appNewVersion#2057
acodega merged 1 commit intoInstallomator:mainfrom
Allingtonbe:citrixworkspace

Conversation

@Maarten-Wijnants
Copy link
Contributor

@Maarten-Wijnants Maarten-Wijnants commented Dec 4, 2024

Removes build number from AppNewVersion to fix version compare.

Before:

2024-12-04 11:45:51 : INFO  : citrixworkspace : appversion: 24.09.10.26
2024-12-04 11:45:51 : INFO  : citrixworkspace : Latest version of Citrix Workspace is 24.09.10.26(2409.10)
2024-12-04 11:45:51 : REQ   : citrixworkspace : Downloading https://downloads.citrix.com/23004/CitrixWorkspaceApp.dmg?__gda__=exp=1733312749~acl=/*~hmac=08a96ce8c2e77a75afc76a727b09310d932162bb32c8a2bb82fff95218fb55e4 to Citrix Workspace.dmg

After:

2024-12-04 12:03:24 : REQ   : citrixworkspace : ################## Start Installomator v. 10.6.1, date 2024-09-06
2024-12-04 12:03:24 : INFO  : citrixworkspace : ################## Version: 10.6.1
2024-12-04 12:03:24 : INFO  : citrixworkspace : ################## Date: 2024-09-06
2024-12-04 12:03:24 : INFO  : citrixworkspace : ################## citrixworkspace
2024-12-04 12:03:24 : DEBUG : citrixworkspace : DEBUG mode 1 enabled.
2024-12-04 12:03:24 : INFO  : citrixworkspace : SwiftDialog is not installed, clear cmd file var
2024-12-04 12:03:44 : INFO  : citrixworkspace : setting variable from argument BLOCKING_PROCESS_ACTION=prompt_user_then_kill
2024-12-04 12:03:44 : INFO  : citrixworkspace : setting variable from argument NOTIFY=silent
2024-12-04 12:03:44 : INFO  : citrixworkspace : setting variable from argument LOGO=/usr/local/sbin/FileWave.app/Contents/Resources/fwGUI.app/Contents/Resources/kiosk.icns
2024-12-04 12:03:44 : INFO  : citrixworkspace : setting variable from argument DEBUG=0
2024-12-04 12:03:44 : DEBUG : citrixworkspace : name=Citrix Workspace
2024-12-04 12:03:44 : DEBUG : citrixworkspace : appName=
2024-12-04 12:03:44 : DEBUG : citrixworkspace : type=pkgInDmg
2024-12-04 12:03:44 : DEBUG : citrixworkspace : archiveName=
2024-12-04 12:03:44 : DEBUG : citrixworkspace : downloadURL=https://downloads.citrix.com/23004/CitrixWorkspaceApp.dmg?__gda__=exp=1733313816~acl=/*~hmac=820a53a75643be579b530fdd85adaba8bc7138788c459b759af4cd23569e087b
2024-12-04 12:03:44 : DEBUG : citrixworkspace : curlOptions=
2024-12-04 12:03:44 : DEBUG : citrixworkspace : appNewVersion=24.09.10.26
2024-12-04 12:03:44 : DEBUG : citrixworkspace : appCustomVersion function: Not defined
2024-12-04 12:03:44 : DEBUG : citrixworkspace : versionKey=CitrixVersionString
2024-12-04 12:03:44 : DEBUG : citrixworkspace : packageID=
2024-12-04 12:03:44 : DEBUG : citrixworkspace : pkgName=
2024-12-04 12:03:44 : DEBUG : citrixworkspace : choiceChangesXML=
2024-12-04 12:03:44 : DEBUG : citrixworkspace : expectedTeamID=S272Y5R93J
2024-12-04 12:03:44 : DEBUG : citrixworkspace : blockingProcesses=
2024-12-04 12:03:44 : DEBUG : citrixworkspace : installerTool=
2024-12-04 12:03:44 : DEBUG : citrixworkspace : CLIInstaller=
2024-12-04 12:03:44 : DEBUG : citrixworkspace : CLIArguments=
2024-12-04 12:03:44 : DEBUG : citrixworkspace : updateTool=
2024-12-04 12:03:44 : DEBUG : citrixworkspace : updateToolArguments=
2024-12-04 12:03:44 : DEBUG : citrixworkspace : updateToolRunAsCurrentUser=
2024-12-04 12:03:44 : INFO  : citrixworkspace : BLOCKING_PROCESS_ACTION=prompt_user_then_kill
2024-12-04 12:03:44 : INFO  : citrixworkspace : NOTIFY=silent
2024-12-04 12:03:44 : INFO  : citrixworkspace : LOGGING=DEBUG
2024-12-04 12:03:44 : INFO  : citrixworkspace : LOGO=/usr/local/sbin/FileWave.app/Contents/Resources/fwGUI.app/Contents/Resources/kiosk.icns
2024-12-04 12:03:44 : INFO  : citrixworkspace : Label type: pkgInDmg
2024-12-04 12:03:44 : INFO  : citrixworkspace : archiveName: Citrix Workspace.dmg
2024-12-04 12:03:44 : INFO  : citrixworkspace : no blocking processes defined, using Citrix Workspace as default
2024-12-04 12:03:44 : DEBUG : citrixworkspace : Changing directory to /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.YAHBhhTFkt
2024-12-04 12:03:44 : INFO  : citrixworkspace : App(s) found: /Applications/Citrix Workspace.app
2024-12-04 12:03:44 : INFO  : citrixworkspace : found app at /Applications/Citrix Workspace.app, version 24.09.10.26, on versionKey CitrixVersionString
2024-12-04 12:03:44 : INFO  : citrixworkspace : appversion: 24.09.10.26
2024-12-04 12:03:44 : INFO  : citrixworkspace : Latest version of Citrix Workspace is 24.09.10.26
2024-12-04 12:03:44 : INFO  : citrixworkspace : There is no newer version available.
2024-12-04 12:03:44 : DEBUG : citrixworkspace : Deleting /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.YAHBhhTFkt
2024-12-04 12:03:44 : DEBUG : citrixworkspace : Debugging enabled, Deleting tmpDir output was:
2024-12-04 12:03:44 : INFO  : citrixworkspace : Installomator did not close any apps, so no need to reopen any apps.
2024-12-04 12:03:45 : REQ   : citrixworkspace : No newer version.
2024-12-04 12:03:45 : REQ   : citrixworkspace : ################## End Installomator, exit code 0

#1987 is also required to make the label work.

@dan-snelson
Copy link
Contributor

dan-snelson commented Dec 4, 2024

Thanks for your efforts on this, @Maarten-Wijnants.

When executing the code line-by-line, I observe the following:

urlToParse='https://www.citrix.com/downloads/workspace-app/mac/workspace-app-for-mac-latest.html#ctx-dl-eula-external'

htmlDocument=$(curl -s -L $urlToParse)

echo $htmlDocument

<HTML><HEAD>
<TITLE>Access Denied</TITLE>
</HEAD><BODY>
<H1>Access Denied</H1>
 
You don't have permission to access "http&#58;&#47;&#47;www&#46;citrix&#46;com&#47;downloads&#47;workspace&#45;app&#47;mac&#47;workspace&#45;app&#45;for&#45;mac&#45;latest&#46;html" on this server.<P>
Reference&#32;&#35;18&#46;98f4d517&#46;1733313015&#46;4f34939d
<P>https&#58;&#47;&#47;errors&#46;edgesuite&#46;net&#47;18&#46;98f4d517&#46;1733313015&#46;4f34939d</P>
</BODY>
</HTML>

@Maarten-Wijnants
Copy link
Contributor Author

Maarten-Wijnants commented Dec 4, 2024

Yes, that is fixed by this pr: #1987

@acodega
Copy link
Collaborator

acodega commented Dec 6, 2024 •
edited
Loading

How prevalent is this issue? Is the fix still needed? We want to reduce the number of citrixworkspace fixes into one PR if we can. Want to comment on #1987 ?

@acodega acodega added waiting for response application-issue App label issue that's not an Installomator bug. Vendor changed their installer, their website, etc. labels Dec 6, 2024
@pmex
Copy link
Contributor

pmex commented Dec 6, 2024

Fyi, I've closed #1987 in favor of #1948.

@dan-snelson
Copy link
Contributor

dan-snelson commented Dec 6, 2024

#1948 (comment)

@pmex
Copy link
Contributor

pmex commented Dec 8, 2024

Yes, I would say that this is needed. With only the curl fix in #1948 you get a constant reinstallation:

2024-12-08 11:24:55 : INFO  : citrixworkspace : ################## Version: 10.7beta
2024-12-08 11:24:55 : INFO  : citrixworkspace : ################## Date: 2024-10-28
2024-12-08 11:24:55 : INFO  : citrixworkspace : ################## citrixworkspace
2024-12-08 11:24:59 : INFO  : citrixworkspace : setting variable from argument BLOCKING_PROCESS_ACTION=prompt_user_then_kill
2024-12-08 11:24:59 : INFO  : citrixworkspace : setting variable from argument NOTIFY=success
2024-12-08 11:24:59 : INFO  : citrixworkspace : setting variable from argument SYSTEMOWNER=0
2024-12-08 11:24:59 : INFO  : citrixworkspace : setting variable from argument INTERRUPT_DND=no
2024-12-08 11:24:59 : INFO  : citrixworkspace : setting variable from argument LOGO="/Library/Application\ Support/Dialog/Dialog.app/Contents/Resources/AppIcon.icns"
2024-12-08 11:24:59 : INFO  : citrixworkspace : setting variable from argument NOTIFY_DIALOG=1
2024-12-08 11:24:59 : INFO  : citrixworkspace : setting variable from argument DEBUG=0
2024-12-08 11:24:59 : INFO  : citrixworkspace : BLOCKING_PROCESS_ACTION=prompt_user_then_kill
2024-12-08 11:24:59 : INFO  : citrixworkspace : NOTIFY=success
2024-12-08 11:24:59 : INFO  : citrixworkspace : LOGGING=INFO
2024-12-08 11:24:59 : INFO  : citrixworkspace : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2024-12-08 11:24:59 : INFO  : citrixworkspace : Label type: pkgInDmg
2024-12-08 11:24:59 : INFO  : citrixworkspace : archiveName: Citrix Workspace.dmg
2024-12-08 11:24:59 : INFO  : citrixworkspace : no blocking processes defined, using Citrix Workspace as default
2024-12-08 11:24:59 : INFO  : citrixworkspace : App(s) found: /Applications/Citrix Workspace.app
2024-12-08 11:24:59 : INFO  : citrixworkspace : found app at /Applications/Citrix Workspace.app, version 24.09.10.26, on versionKey CitrixVersionString
2024-12-08 11:24:59 : INFO  : citrixworkspace : appversion: 24.09.10.26
2024-12-08 11:24:59 : INFO  : citrixworkspace : Latest version of Citrix Workspace is 24.09.10.26(2409.10)
2024-12-08 11:24:59 : REQ   : citrixworkspace : Downloading https://downloads.citrix.com/23004/CitrixWorkspaceApp.dmg?__gda__=exp=1733657097~acl=/*~hmac=9c0470fc85046318766c639a302e5109522447d9b946d1a074bbeb3a3955e05d to Citrix Workspace.dmg
2024-12-08 11:25:19 : INFO  : citrixworkspace : found blocking process Citrix Workspace
2024-12-08 11:25:30 : INFO  : citrixworkspace : Installomator did not close any apps, so no need to reopen any apps.
2024-12-08 11:25:31 : ERROR : citrixworkspace : ERROR: user aborted update
2024-12-08 11:25:31 : REQ   : citrixworkspace : ################## End Installomator, exit code 10

With the fix in this PR, on top the curl fix, you don't get any reinstallation:

2024-12-08 11:27:51 : INFO  : citrixworkspace : ################## Version: 10.7beta
2024-12-08 11:27:51 : INFO  : citrixworkspace : ################## Date: 2024-10-28
2024-12-08 11:27:51 : INFO  : citrixworkspace : ################## citrixworkspace
2024-12-08 11:27:53 : INFO  : citrixworkspace : setting variable from argument BLOCKING_PROCESS_ACTION=prompt_user_then_kill
2024-12-08 11:27:53 : INFO  : citrixworkspace : setting variable from argument NOTIFY=success
2024-12-08 11:27:53 : INFO  : citrixworkspace : setting variable from argument SYSTEMOWNER=0
2024-12-08 11:27:53 : INFO  : citrixworkspace : setting variable from argument INTERRUPT_DND=no
2024-12-08 11:27:53 : INFO  : citrixworkspace : setting variable from argument LOGO="/Library/Application\ Support/Dialog/Dialog.app/Contents/Resources/AppIcon.icns"
2024-12-08 11:27:53 : INFO  : citrixworkspace : setting variable from argument NOTIFY_DIALOG=1
2024-12-08 11:27:53 : INFO  : citrixworkspace : setting variable from argument DEBUG=0
2024-12-08 11:27:53 : INFO  : citrixworkspace : BLOCKING_PROCESS_ACTION=prompt_user_then_kill
2024-12-08 11:27:53 : INFO  : citrixworkspace : NOTIFY=success
2024-12-08 11:27:53 : INFO  : citrixworkspace : LOGGING=INFO
2024-12-08 11:27:53 : INFO  : citrixworkspace : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2024-12-08 11:27:53 : INFO  : citrixworkspace : Label type: pkgInDmg
2024-12-08 11:27:53 : INFO  : citrixworkspace : archiveName: Citrix Workspace.dmg
2024-12-08 11:27:53 : INFO  : citrixworkspace : no blocking processes defined, using Citrix Workspace as default
2024-12-08 11:27:53 : INFO  : citrixworkspace : App(s) found: /Applications/Citrix Workspace.app
2024-12-08 11:27:53 : INFO  : citrixworkspace : found app at /Applications/Citrix Workspace.app, version 24.09.10.26, on versionKey CitrixVersionString
2024-12-08 11:27:53 : INFO  : citrixworkspace : appversion: 24.09.10.26
2024-12-08 11:27:53 : INFO  : citrixworkspace : Latest version of Citrix Workspace is 24.09.10.26
2024-12-08 11:27:53 : INFO  : citrixworkspace : There is no newer version available.
2024-12-08 11:27:53 : INFO  : citrixworkspace : Installomator did not close any apps, so no need to reopen any apps.
2024-12-08 11:27:54 : REQ   : citrixworkspace : No newer version.
2024-12-08 11:27:54 : REQ   : citrixworkspace : ################## End Installomator, exit code 0

@acodega acodega mentioned this pull request Jan 8, 2025
Merged
@acodega acodega merged commit 86a417c into Installomator:main Jan 22, 2025
@acodega acodega added the application adds or improves an application label label Jan 28, 2025
@acodega acodega added this to the v10.8 milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

application adds or improves an application label application-issue App label issue that's not an Installomator bug. Vendor changed their installer, their website, etc.

Projects

None yet

Milestone

v10.8

Development

Successfully merging this pull request may close these issues.

4 participants

@Maarten-Wijnants @dan-snelson @acodega @pmex