Skip to content

Comments

zulujdk11 fixed download and version checks#2012

Closed
PhantomPhixer wants to merge 3 commits intoInstallomator:mainfrom
PhantomPhixer:zulujdk11-fix-download-and-version-check
Closed

zulujdk11 fixed download and version checks#2012
PhantomPhixer wants to merge 3 commits intoInstallomator:mainfrom
PhantomPhixer:zulujdk11-fix-download-and-version-check

Conversation

@PhantomPhixer
Copy link
Contributor

as per PR #2011 the zulujdk11 function is incorrect.
Same fix methods applied.

zulujdk11-clean install.log
zulujdk11-update-same-version.log

@Ingo-Siegel
Copy link

download URL ist still pulling incorrect info

Proposed update:

original downloadURL line:

downloadURL=https://cdn.azul.com/zulu/bin/$(curl -fs "https://cdn.azul.com/zulu/bin/" | grep -Eio '">zulu11.*ca-jdk11.aarch64.dmg(.)' | cut -c3- | sed 's/</a>//' | sed -E 's/([0-9.])M//' | awk '{print $2 $1}' | sort | cut -d "<" -f 1 | tail -1)

replacement line:

https://cdn.azul.com/zulu/bin/$(curl -fs "https://cdn.azul.com/zulu/bin/" | grep -Eio "'>zulu11.*ca-jdk11.aarch64.dmg(.)' | cut -c2- | sed 's/</a>//' | sed -E 's/([0-9.])M//' | awk '{print $2 $1}' | sort | cut -d "<" -f 1 | tail -1

removes cut -c3- and adds cut -c2-

should give this result:

https://cdn.azul.com/zulu/bin/zulu11.76.21-ca-jdk11.0.25-macosx_aarch64.dmg
curl.txt

@bartreardon bartreardon added application adds or improves an application label incomplete App label processed by the validation bot but has an issue that needs attending labels Feb 7, 2025
@bartreardon
Copy link
Collaborator

🤖 Validation robot 🤖
File fragments/labels/zulujdk11.sh
** Label info:
├ ❌ The file 'fragments/labels/zulujdk11.sh' does not end with an LF control character. We recommend installing/using an EditorConfig plugin for your editor.
├ ✅ Name: Zulu JDK 11
├ ✅ Type: pkgInDmg
├ ✅ Expected Team: TDTHCUPYFR
├ ✅ App New Version: 11.78.15
└ Download URL: https://cdn.azul.com/zulu/bin/zulu11.78.15-ca-jdk11.0.26-macosx_aarch64.dmg
├ ✅ URL is reachable
└ ✅ Download Size: 186.9 MB
** WARNING: Some checks failed
✅ 4 checks passed
❌ 1 checks failed
❌ Please review Contributing to Installomator and update your pull request.


@acodega acodega added the duplicate This issue or pull request already exists label Nov 5, 2025
@acodega acodega closed this Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application adds or improves an application label duplicate This issue or pull request already exists incomplete App label processed by the validation bot but has an issue that needs attending

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants