Skip to content

Comments

Update zulujdk17#2011

Closed
PhantomPhixer wants to merge 4 commits intoInstallomator:mainfrom
PhantomPhixer:zulujdk17-fix-download-and-version-check
Closed

Update zulujdk17#2011
PhantomPhixer wants to merge 4 commits intoInstallomator:mainfrom
PhantomPhixer:zulujdk17-fix-download-and-version-check

Conversation

@PhantomPhixer
Copy link
Contributor

Cane to light during an audit the Azul jdk isn't being updated by installomater. This is an updated fragment that fixes that issue.

download URL was pulling incorrect info and trunkating the path:

original downloadURL line:

downloadURL=https://cdn.azul.com/zulu/bin/$(curl -fs "https://cdn.azul.com/zulu/bin/" | grep -Eio '">zulu17.*ca-jdk17.*x64.dmg(.*)' | cut -c3- | sed 's/<\/a>//' | sed -E 's/([0-9.]*)M//' | awk '{print $2 $1}' | sort | cut -c11- | tail -1)

replacement line:

downloadURL=https://cdn.azul.com/zulu/bin/$(curl -fs "https://cdn.azul.com/zulu/bin/" | grep -Eio '">zulu17.*ca-jdk17.*x64.dmg(.*)' | cut -c3- | sed 's/<\/a>//' | sed -E 's/([0-9.]*)M//' | awk '{print $2 $1}' | sort | cut -c11- | cut -d "<" -f 1 | tail -1)

removes cut c11- and adds cut -d "<" -f 1

installed version check simplified

modified to use contents of info.plist:
appCustomVersion(){ if [ -f "/Library/Java/JavaVirtualMachines/zulu-17.jdk/Contents/Info.plist" ]; then /usr/bin/defaults read "/Library/Java/JavaVirtualMachines/zulu-17.jdk/Contents/Info.plist" "CFBundleName" | sed 's/Zulu //'; fi }

logs from a clean install and an update check:

zulujdk17-clean install.log
zulujdk17-update-same-version.log

@acodega acodega changed the title fix download url and version checking Update zulujdk17 Nov 21, 2024
@acodega
Copy link
Collaborator

acodega commented Nov 21, 2024

Can you adjust this PR to have the same line indention as other labels? Check your "Files changed" and you'll see all the tabs that were taken out. Thanks!

changed indents to match standard format
@PhantomPhixer
Copy link
Contributor Author

indentation fixed

@bartreardon bartreardon added application adds or improves an application label incomplete App label processed by the validation bot but has an issue that needs attending labels Feb 7, 2025
@bartreardon
Copy link
Collaborator

🤖 Validation robot 🤖
File fragments/labels/zulujdk17.sh
** Label info:
├ ❌ The file 'fragments/labels/zulujdk17.sh' does not end with an LF control character. We recommend installing/using an EditorConfig plugin for your editor.
├ ✅ Name: Zulu JDK 17
├ ✅ Type: pkgInDmg
├ ✅ Expected Team: TDTHCUPYFR
├ ✅ App New Version: 17.56.15
└ Download URL: https://cdn.azul.com/zulu/bin/zulu17.56.15-ca-jdk17.0.14-macosx_aarch64.dmg
├ ✅ URL is reachable
└ ✅ Download Size: 185.9 MB
** WARNING: Some checks failed
✅ 4 checks passed
❌ 1 checks failed
❌ Please review Contributing to Installomator and update your pull request.


@acodega acodega added the duplicate This issue or pull request already exists label Nov 5, 2025
@acodega acodega closed this Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application adds or improves an application label duplicate This issue or pull request already exists incomplete App label processed by the validation bot but has an issue that needs attending

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants