Skip to content

Comments

Update remotedesktopmanagerenterprise.sh to remove unnecessary blockingProcesses variable#1843

Closed
gilburns wants to merge 2 commits intoInstallomator:mainfrom
gilburns:remotedesktopmanagerenterprise
Closed

Update remotedesktopmanagerenterprise.sh to remove unnecessary blockingProcesses variable#1843
gilburns wants to merge 2 commits intoInstallomator:mainfrom
gilburns:remotedesktopmanagerenterprise

Conversation

@gilburns
Copy link
Contributor

@gilburns gilburns commented Sep 4, 2024

Just removed the extra variable. No additional changes.

@acodega acodega added the application adds or improves an application label label Jan 16, 2025
@bartreardon bartreardon added the incomplete App label processed by the validation bot but has an issue that needs attending label Feb 7, 2025
@bartreardon
Copy link
Collaborator

🤖 Validation robot 🤖
File fragments/labels/remotedesktopmanagerenterprise.sh
** Label info:
├ ✅ correct line ending
├ ✅ Name: Remote Desktop Manager
├ ✅ Type: dmg
├ ✅ Expected Team: N592S9ASDB
⚠️ App New Version: Missing
└ Download URL: ❌ no download URL
** WARNING: Some checks failed
✅ 4 checks passed
❌ 1 checks failed
❌ Please review Contributing to Installomator and update your pull request.


@gilburns
Copy link
Contributor Author

gilburns commented Feb 8, 2025

Update to use the XML feed

assemble.sh remotedesktopmanagerenterprise
2025-02-07 19:58:37 : REQ   : remotedesktopmanagerenterprise : ################## Start Installomator v. 10.7beta, date 2025-02-07
2025-02-07 19:58:37 : INFO  : remotedesktopmanagerenterprise : ################## Version: 10.7beta
2025-02-07 19:58:37 : INFO  : remotedesktopmanagerenterprise : ################## Date: 2025-02-07
2025-02-07 19:58:37 : INFO  : remotedesktopmanagerenterprise : ################## remotedesktopmanagerenterprise
2025-02-07 19:58:37 : DEBUG : remotedesktopmanagerenterprise : DEBUG mode 1 enabled.
Query didn't return a nodeset. Value: Query didn't return a nodeset. Value: 2025-02-07 19:58:37 : DEBUG : remotedesktopmanagerenterprise : name=Remote Desktop Manager
2025-02-07 19:58:37 : DEBUG : remotedesktopmanagerenterprise : appName=
2025-02-07 19:58:37 : DEBUG : remotedesktopmanagerenterprise : type=dmg
2025-02-07 19:58:37 : DEBUG : remotedesktopmanagerenterprise : archiveName=
2025-02-07 19:58:37 : DEBUG : remotedesktopmanagerenterprise : downloadURL=https://cdn.devolutions.net/download/Mac/Devolutions.RemoteDesktopManager.Mac.2024.3.10.3.dmg
2025-02-07 19:58:37 : DEBUG : remotedesktopmanagerenterprise : curlOptions=
2025-02-07 19:58:37 : DEBUG : remotedesktopmanagerenterprise : appNewVersion=2024.3.10.3
2025-02-07 19:58:38 : DEBUG : remotedesktopmanagerenterprise : appCustomVersion function: Not defined
2025-02-07 19:58:38 : DEBUG : remotedesktopmanagerenterprise : versionKey=CFBundleShortVersionString
2025-02-07 19:58:38 : DEBUG : remotedesktopmanagerenterprise : packageID=
2025-02-07 19:58:38 : DEBUG : remotedesktopmanagerenterprise : pkgName=
2025-02-07 19:58:38 : DEBUG : remotedesktopmanagerenterprise : choiceChangesXML=
2025-02-07 19:58:38 : DEBUG : remotedesktopmanagerenterprise : expectedTeamID=N592S9ASDB
2025-02-07 19:58:38 : DEBUG : remotedesktopmanagerenterprise : blockingProcesses=
2025-02-07 19:58:38 : DEBUG : remotedesktopmanagerenterprise : installerTool=
2025-02-07 19:58:38 : DEBUG : remotedesktopmanagerenterprise : CLIInstaller=
2025-02-07 19:58:38 : DEBUG : remotedesktopmanagerenterprise : CLIArguments=
2025-02-07 19:58:38 : DEBUG : remotedesktopmanagerenterprise : updateTool=
2025-02-07 19:58:38 : DEBUG : remotedesktopmanagerenterprise : updateToolArguments=
2025-02-07 19:58:38 : DEBUG : remotedesktopmanagerenterprise : updateToolRunAsCurrentUser=
2025-02-07 19:58:38 : INFO  : remotedesktopmanagerenterprise : BLOCKING_PROCESS_ACTION=tell_user
2025-02-07 19:58:38 : INFO  : remotedesktopmanagerenterprise : NOTIFY=success
2025-02-07 19:58:38 : INFO  : remotedesktopmanagerenterprise : LOGGING=DEBUG
2025-02-07 19:58:38 : INFO  : remotedesktopmanagerenterprise : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2025-02-07 19:58:38 : INFO  : remotedesktopmanagerenterprise : Label type: dmg
2025-02-07 19:58:38 : INFO  : remotedesktopmanagerenterprise : archiveName: Remote Desktop Manager.dmg
2025-02-07 19:58:38 : INFO  : remotedesktopmanagerenterprise : no blocking processes defined, using Remote Desktop Manager as default
2025-02-07 19:58:38 : DEBUG : remotedesktopmanagerenterprise : Changing directory to /Users/gilburns/GitHub/Installomator/build
2025-02-07 19:58:38 : INFO  : remotedesktopmanagerenterprise : name: Remote Desktop Manager, appName: Remote Desktop Manager.app
2025-02-07 19:58:38.130 mdfind[98162:209276278] [UserQueryParser] Loading keywords and predicates for locale "en_US"
2025-02-07 19:58:38.130 mdfind[98162:209276278] [UserQueryParser] Loading keywords and predicates for locale "en"
2025-02-07 19:58:38.207 mdfind[98162:209276278] Couldn't determine the mapping between prefab keywords and predicates.
2025-02-07 19:58:38 : INFO  : remotedesktopmanagerenterprise : App(s) found: /Users/gilburns/Applications/Remote Desktop Manager.app
2025-02-07 19:58:38 : WARN  : remotedesktopmanagerenterprise : could not determine location of Remote Desktop Manager.app
2025-02-07 19:58:38 : INFO  : remotedesktopmanagerenterprise : appversion: 
2025-02-07 19:58:38 : INFO  : remotedesktopmanagerenterprise : Latest version of Remote Desktop Manager is 2024.3.10.3
2025-02-07 19:58:38 : REQ   : remotedesktopmanagerenterprise : Downloading https://cdn.devolutions.net/download/Mac/Devolutions.RemoteDesktopManager.Mac.2024.3.10.3.dmg to Remote Desktop Manager.dmg
2025-02-07 19:58:38 : DEBUG : remotedesktopmanagerenterprise : No Dialog connection, just download
2025-02-07 19:59:12 : DEBUG : remotedesktopmanagerenterprise : File list: -rw-r--r--  1 gilburns  staff   291M Feb  7 19:59 Remote Desktop Manager.dmg
2025-02-07 19:59:12 : DEBUG : remotedesktopmanagerenterprise : File type: Remote Desktop Manager.dmg: zlib compressed data
2025-02-07 19:59:12 : DEBUG : remotedesktopmanagerenterprise : curl output was:
* Host cdn.devolutions.net:443 was resolved.
* IPv6: 2606:4700:4400::6812:28ec, 2606:4700:4400::ac40:9314
* IPv4: 104.18.40.236, 172.64.147.20
*   Trying 104.18.40.236:443...
* Connected to cdn.devolutions.net (104.18.40.236) port 443
* ALPN: curl offers h2,http/1.1
* (304) (OUT), TLS handshake, Client hello (1):
} [324 bytes data]
*  CAfile: /etc/ssl/cert.pem
*  CApath: none
* (304) (IN), TLS handshake, Server hello (2):
{ [122 bytes data]
* (304) (IN), TLS handshake, Unknown (8):
{ [19 bytes data]
* (304) (IN), TLS handshake, Certificate (11):
{ [2531 bytes data]
* (304) (IN), TLS handshake, CERT verify (15):
{ [79 bytes data]
* (304) (IN), TLS handshake, Finished (20):
{ [36 bytes data]
* (304) (OUT), TLS handshake, Finished (20):
} [36 bytes data]
* SSL connection using TLSv1.3 / AEAD-CHACHA20-POLY1305-SHA256 / [blank] / UNDEF
* ALPN: server accepted h2
* Server certificate:
*  subject: CN=cdn.devolutions.net
*  start date: Dec 19 14:09:58 2024 GMT
*  expire date: Mar 19 15:09:57 2025 GMT
*  subjectAltName: host "cdn.devolutions.net" matched cert's "cdn.devolutions.net"
*  issuer: C=US; O=Google Trust Services; CN=WE1
*  SSL certificate verify ok.
* using HTTP/2
* [HTTP/2] [1] OPENED stream for https://cdn.devolutions.net/download/Mac/Devolutions.RemoteDesktopManager.Mac.2024.3.10.3.dmg
* [HTTP/2] [1] [:method: GET]
* [HTTP/2] [1] [:scheme: https]
* [HTTP/2] [1] [:authority: cdn.devolutions.net]
* [HTTP/2] [1] [:path: /download/Mac/Devolutions.RemoteDesktopManager.Mac.2024.3.10.3.dmg]
* [HTTP/2] [1] [user-agent: curl/8.7.1]
* [HTTP/2] [1] [accept: */*]
> GET /download/Mac/Devolutions.RemoteDesktopManager.Mac.2024.3.10.3.dmg HTTP/2
> Host: cdn.devolutions.net
> User-Agent: curl/8.7.1
> Accept: */*
> 
* Request completely sent off
< HTTP/2 200 
< date: Sat, 08 Feb 2025 01:58:38 GMT
< content-type: application/x-apple-diskimage
< content-length: 305268668
< last-modified: Tue, 04 Feb 2025 20:53:54 GMT
< etag: 0x8DD455E0945EA67
< vary: Origin
< x-ms-request-id: 6eb9b50a-501e-0045-4a48-7766b1000000
< x-ms-version: 2009-09-19
< x-ms-lease-status: unlocked
< x-ms-blob-type: BlockBlob
< cf-cache-status: HIT
< age: 276170
< accept-ranges: bytes
< set-cookie: __cf_bm=oWHwGhs9FOtmmbMJSnJRjjfvFVuaMPPXNIjC6y7qHzY-1738979918-1.0.1.1-hiPts6b.8Vv2IeuPjTvfYwKXQhDl0eP59Y2cEfYSWQ22PlMwMg1iPo4tGbf1rO0rjx9F1gQy0cDezm8HoUelug; path=/; expires=Sat, 08-Feb-25 02:28:38 GMT; domain=.devolutions.net; HttpOnly; Secure; SameSite=None
< server: cloudflare
< cf-ray: 90e80409ee86eac7-ORD
< 
{ [1360 bytes data]
* Connection #0 to host cdn.devolutions.net left intact

2025-02-07 19:59:12 : DEBUG : remotedesktopmanagerenterprise : DEBUG mode 1, not checking for blocking processes
2025-02-07 19:59:12 : REQ   : remotedesktopmanagerenterprise : Installing Remote Desktop Manager
2025-02-07 19:59:12 : INFO  : remotedesktopmanagerenterprise : Mounting /Users/gilburns/GitHub/Installomator/build/Remote Desktop Manager.dmg
2025-02-07 19:59:15 : DEBUG : remotedesktopmanagerenterprise : Debugging enabled, dmgmount output was:
Checksumming Protective Master Boot Record (MBR : 0)…
Protective Master Boot Record (MBR :: verified   CRC32 $E25A79D4
Checksumming GPT Header (Primary GPT Header : 1)…
GPT Header (Primary GPT Header : 1): verified   CRC32 $7734C034
Checksumming GPT Partition Data (Primary GPT Table : 2)…
GPT Partition Data (Primary GPT Tabl: verified   CRC32 $44372CBB
Checksumming  (Apple_Free : 3)…
(Apple_Free : 3): verified   CRC32 $00000000
Checksumming disk image (Apple_HFS : 4)…
disk image (Apple_HFS : 4): verified   CRC32 $A6D28CA1
Checksumming  (Apple_Free : 5)…
(Apple_Free : 5): verified   CRC32 $00000000
Checksumming GPT Partition Data (Backup GPT Table : 6)…
GPT Partition Data (Backup GPT Table: verified   CRC32 $44372CBB
Checksumming GPT Header (Backup GPT Header : 7)…
GPT Header (Backup GPT Header : 7): verified   CRC32 $FD972189
verified   CRC32 $39F65246
/dev/disk13         	GUID_partition_scheme
/dev/disk13s1       	Apple_HFS                      	/Volumes/Remote Desktop Manager.app Installer

2025-02-07 19:59:15 : INFO  : remotedesktopmanagerenterprise : Mounted: /Volumes/Remote Desktop Manager.app Installer
2025-02-07 19:59:15 : INFO  : remotedesktopmanagerenterprise : Verifying: /Volumes/Remote Desktop Manager.app Installer/Remote Desktop Manager.app
2025-02-07 19:59:15 : DEBUG : remotedesktopmanagerenterprise : App size: 807M	/Volumes/Remote Desktop Manager.app Installer/Remote Desktop Manager.app
2025-02-07 19:59:19 : DEBUG : remotedesktopmanagerenterprise : Debugging enabled, App Verification output was:
/Volumes/Remote Desktop Manager.app Installer/Remote Desktop Manager.app: accepted
source=Notarized Developer ID
origin=Developer ID Application: Devolutions inc. (N592S9ASDB)

2025-02-07 19:59:19 : INFO  : remotedesktopmanagerenterprise : Team ID matching: N592S9ASDB (expected: N592S9ASDB )
2025-02-07 19:59:19 : INFO  : remotedesktopmanagerenterprise : Installing Remote Desktop Manager version 2024.3.10.3 on versionKey CFBundleShortVersionString.
2025-02-07 19:59:19 : INFO  : remotedesktopmanagerenterprise : App has LSMinimumSystemVersion: 10.15
2025-02-07 19:59:19 : DEBUG : remotedesktopmanagerenterprise : DEBUG mode 1 enabled, skipping remove, copy and chown steps
2025-02-07 19:59:19 : INFO  : remotedesktopmanagerenterprise : Finishing...
2025-02-07 19:59:22 : INFO  : remotedesktopmanagerenterprise : name: Remote Desktop Manager, appName: Remote Desktop Manager.app
2025-02-07 19:59:22.616 mdfind[3366:209285591] [UserQueryParser] Loading keywords and predicates for locale "en_US"
2025-02-07 19:59:22.616 mdfind[3366:209285591] [UserQueryParser] Loading keywords and predicates for locale "en"
2025-02-07 19:59:22.663 mdfind[3366:209285591] Couldn't determine the mapping between prefab keywords and predicates.
2025-02-07 19:59:22 : INFO  : remotedesktopmanagerenterprise : App(s) found: /Users/gilburns/Applications/Remote Desktop Manager.app
2025-02-07 19:59:22 : WARN  : remotedesktopmanagerenterprise : could not determine location of Remote Desktop Manager.app
2025-02-07 19:59:22 : REQ   : remotedesktopmanagerenterprise : Installed Remote Desktop Manager, version 2024.3.10.3
2025-02-07 19:59:22 : INFO  : remotedesktopmanagerenterprise : notifying
ERROR: Notifications are not allowed for this application
2025-02-07 19:59:22 : DEBUG : remotedesktopmanagerenterprise : Unmounting /Volumes/Remote Desktop Manager.app Installer
2025-02-07 19:59:23 : DEBUG : remotedesktopmanagerenterprise : Debugging enabled, Unmounting output was:
"disk13" ejected.
2025-02-07 19:59:23 : DEBUG : remotedesktopmanagerenterprise : DEBUG mode 1, not reopening anything
2025-02-07 19:59:23 : REQ   : remotedesktopmanagerenterprise : All done!
2025-02-07 19:59:23 : REQ   : remotedesktopmanagerenterprise : ################## End Installomator, exit code 0 

@bartreardon
Copy link
Collaborator

those xpath commands don't seem right to me. running the commands individually I get an error.

should it be something more like echo "${xml_feed}" | xpath -q -e 'string(//rss/channel/item[last()]/enclosure/@sparkle:version)' ?

@gilburns
Copy link
Contributor Author

gilburns commented Feb 9, 2025

I think you might be forgetting about the xpath function inside of Installomator script? That function adds the correct parameters for the xpath binary based on the OS version.

@bartreardon
Copy link
Collaborator

bah - that's always catching me out : /

validation robot is learning 🤖

@gilburns gilburns closed this Jun 20, 2025
@gilburns gilburns deleted the remotedesktopmanagerenterprise branch January 3, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application adds or improves an application label incomplete App label processed by the validation bot but has an issue that needs attending

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants