Skip to content

Comments

Update polylens.sh#1784

Merged
acodega merged 1 commit intoInstallomator:mainfrom
amadotejada:main
Jan 16, 2025
Merged

Update polylens.sh#1784
acodega merged 1 commit intoInstallomator:mainfrom
amadotejada:main

Conversation

@amadotejada
Copy link
Contributor

@amadotejada amadotejada commented Aug 14, 2024 •
edited
Loading

Summary:

This PR updates the script to ensure it correctly captures the latest macOS version of the Poly Lens app. Recently, HP released a version only for Windows, which was causing the script to mistakenly capture it instead of the macOS version.

Changes:

  • Filter Improvement: Added logic to exclude "Windows Only" versions from the output.
  • Version Extraction: Refined the command to ensure the correct macOS version is returned.

Testing:

  • Verified that the script now correctly excludes "Windows Only" versions and retrieves the latest macOS version.

Output:

sudo /Users/atejada/Github/Installomator/utils/assemble.sh polylens DEBUG=0
2024-08-14 17:33:54 : REQ   : polylens : ################## Start Installomator v. 10.6beta, date 2024-08-14
2024-08-14 17:33:54 : INFO  : polylens : ################## Version: 10.6beta
2024-08-14 17:33:54 : INFO  : polylens : ################## Date: 2024-08-14
2024-08-14 17:33:54 : INFO  : polylens : ################## polylens
2024-08-14 17:33:54 : DEBUG : polylens : DEBUG mode 1 enabled.
2024-08-14 17:33:55 : INFO  : polylens : setting variable from argument DEBUG=0
2024-08-14 17:33:55 : DEBUG : polylens : name=Poly Lens
2024-08-14 17:33:55 : DEBUG : polylens : appName=
2024-08-14 17:33:55 : DEBUG : polylens : type=dmg
2024-08-14 17:33:55 : DEBUG : polylens : archiveName=
2024-08-14 17:33:55 : DEBUG : polylens : downloadURL=https://swupdate.lens.poly.com/lens-desktop-mac/1.4.0/1.4.0/PolyLens-1.4.0.dmg
2024-08-14 17:33:55 : DEBUG : polylens : curlOptions=
2024-08-14 17:33:55 : DEBUG : polylens : appNewVersion=1.4.0
2024-08-14 17:33:55 : DEBUG : polylens : appCustomVersion function: Not defined
2024-08-14 17:33:55 : DEBUG : polylens : versionKey=CFBundleShortVersionString
2024-08-14 17:33:55 : DEBUG : polylens : packageID=
2024-08-14 17:33:55 : DEBUG : polylens : pkgName=
2024-08-14 17:33:55 : DEBUG : polylens : choiceChangesXML=
2024-08-14 17:33:55 : DEBUG : polylens : expectedTeamID=SKWK2Q7JJV
2024-08-14 17:33:55 : DEBUG : polylens : blockingProcesses=
2024-08-14 17:33:55 : DEBUG : polylens : installerTool=
2024-08-14 17:33:55 : DEBUG : polylens : CLIInstaller=
2024-08-14 17:33:55 : DEBUG : polylens : CLIArguments=
2024-08-14 17:33:55 : DEBUG : polylens : updateTool=
2024-08-14 17:33:55 : DEBUG : polylens : updateToolArguments=
2024-08-14 17:33:55 : DEBUG : polylens : updateToolRunAsCurrentUser=
2024-08-14 17:33:55 : INFO  : polylens : BLOCKING_PROCESS_ACTION=tell_user
2024-08-14 17:33:55 : INFO  : polylens : NOTIFY=success
2024-08-14 17:33:55 : INFO  : polylens : LOGGING=DEBUG
2024-08-14 17:33:55 : INFO  : polylens : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2024-08-14 17:33:55 : INFO  : polylens : Label type: dmg
2024-08-14 17:33:55 : INFO  : polylens : archiveName: Poly Lens.dmg
2024-08-14 17:33:55 : INFO  : polylens : no blocking processes defined, using Poly Lens as default
2024-08-14 17:33:55 : DEBUG : polylens : Changing directory to /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.jgo14cjOHj
2024-08-14 17:33:55 : INFO  : polylens : name: Poly Lens, appName: Poly Lens.app
2024-08-14 17:33:55.368 mdfind[15995:142226] [UserQueryParser] Loading keywords and predicates for locale "en_US"
2024-08-14 17:33:55.368 mdfind[15995:142226] [UserQueryParser] Loading keywords and predicates for locale "en"
2024-08-14 17:33:55.395 mdfind[15995:142226] Couldn't determine the mapping between prefab keywords and predicates.
2024-08-14 17:33:55 : WARN  : polylens : No previous app found
2024-08-14 17:33:55 : WARN  : polylens : could not find Poly Lens.app
2024-08-14 17:33:55 : INFO  : polylens : appversion:
2024-08-14 17:33:55 : INFO  : polylens : Latest version of Poly Lens is 1.4.0
2024-08-14 17:33:55 : REQ   : polylens : Downloading https://swupdate.lens.poly.com/lens-desktop-mac/1.4.0/1.4.0/PolyLens-1.4.0.dmg to Poly Lens.dmg
2024-08-14 17:33:55 : DEBUG : polylens : No Dialog connection, just download
2024-08-14 17:33:57 : DEBUG : polylens : File list: -rw-r--r--  1 root  wheel   173M Aug 14 17:33 Poly Lens.dmg
2024-08-14 17:33:57 : DEBUG : polylens : File type: Poly Lens.dmg: zlib compressed data
2024-08-14 17:33:57 : DEBUG : polylens : curl output was:
* Host swupdate.lens.poly.com:443 was resolved.
* IPv6: (none)
* IPv4: 13.107.246.40
*   Trying 13.107.246.40:443...
* Connected to swupdate.lens.poly.com (13.107.246.40) port 443
* ALPN: curl offers h2,http/1.1
* (304) (OUT), TLS handshake, Client hello (1):
} [327 bytes data]
*  CAfile: /etc/ssl/cert.pem
*  CApath: none
* (304) (IN), TLS handshake, Server hello (2):
{ [88 bytes data]
* (304) (OUT), TLS handshake, Client hello (1):
} [360 bytes data]
* (304) (IN), TLS handshake, Server hello (2):
{ [155 bytes data]
* (304) (IN), TLS handshake, Unknown (8):
{ [19 bytes data]
* (304) (IN), TLS handshake, Certificate (11):
{ [3929 bytes data]
* (304) (IN), TLS handshake, CERT verify (15):
{ [264 bytes data]
* (304) (IN), TLS handshake, Finished (20):
{ [52 bytes data]
* (304) (OUT), TLS handshake, Finished (20):
} [52 bytes data]
* SSL connection using TLSv1.3 / AEAD-AES256-GCM-SHA384 / [blank] / UNDEF
* ALPN: server accepted h2
* Server certificate:
*  subject: C=US; ST=Washington; L=Redmond; O=Microsoft Corporation; CN=swupdate.lens.poly.com
*  start date: Jul 31 00:00:00 2024 GMT
*  expire date: Jul 31 23:59:59 2025 GMT
*  subjectAltName: host "swupdate.lens.poly.com" matched cert's "swupdate.lens.poly.com"
*  issuer: C=US; O=DigiCert Inc; CN=DigiCert TLS RSA SHA256 2020 CA1
*  SSL certificate verify ok.
* using HTTP/2
* [HTTP/2] [1] OPENED stream for https://swupdate.lens.poly.com/lens-desktop-mac/1.4.0/1.4.0/PolyLens-1.4.0.dmg
* [HTTP/2] [1] [:method: GET]
* [HTTP/2] [1] [:scheme: https]
* [HTTP/2] [1] [:authority: swupdate.lens.poly.com]
* [HTTP/2] [1] [:path: /lens-desktop-mac/1.4.0/1.4.0/PolyLens-1.4.0.dmg]
* [HTTP/2] [1] [user-agent: curl/8.7.1]
* [HTTP/2] [1] [accept: */*]
> GET /lens-desktop-mac/1.4.0/1.4.0/PolyLens-1.4.0.dmg HTTP/2
> Host: swupdate.lens.poly.com
> User-Agent: curl/8.7.1
> Accept: */*
>
* Request completely sent off
< HTTP/2 200
< date: Wed, 14 Aug 2024 21:33:55 GMT
< content-type: application/octet-stream
< content-length: 181042162
< last-modified: Thu, 16 May 2024 17:46:46 GMT
< etag: "0x8DC75D02800E902"
< x-ms-request-id: 59817213-b01e-006c-3bdd-e62fcc000000
< x-ms-version: 2018-03-28
< access-control-allow-origin: *
< x-azure-ref: 20240814T213355Z-r1c6c7fdc8ftjg7c9uft7b2ezc00000001gg00000000c89r
< x-fd-int-roxy-purgeid: 74552621
< x-cache-info: L1_T2
< x-cache: TCP_HIT
< accept-ranges: bytes
<
{ [8192 bytes data]
* Connection #0 to host swupdate.lens.poly.com left intact

2024-08-14 17:33:57 : REQ   : polylens : no more blocking processes, continue with update
2024-08-14 17:33:57 : REQ   : polylens : Installing Poly Lens
2024-08-14 17:33:57 : INFO  : polylens : Mounting /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.jgo14cjOHj/Poly Lens.dmg
2024-08-14 17:33:58 : DEBUG : polylens : Debugging enabled, dmgmount output was:
Checksumming Protective Master Boot Record (MBR : 0)…
Protective Master Boot Record (MBR :: verified   CRC32 $995A3A79
Checksumming GPT Header (Primary GPT Header : 1)…
GPT Header (Primary GPT Header : 1): verified   CRC32 $5C3C0E69
Checksumming GPT Partition Data (Primary GPT Table : 2)…
GPT Partition Data (Primary GPT Tabl: verified   CRC32 $AB99A171
Checksumming  (Apple_Free : 3)…
(Apple_Free : 3): verified   CRC32 $00000000
Checksumming disk image (Apple_APFS : 4)…
disk image (Apple_APFS : 4): verified   CRC32 $4E8DF8D8
Checksumming  (Apple_Free : 5)…
(Apple_Free : 5): verified   CRC32 $00000000
Checksumming GPT Partition Data (Backup GPT Table : 6)…
GPT Partition Data (Backup GPT Table: verified   CRC32 $AB99A171
Checksumming GPT Header (Backup GPT Header : 7)…
GPT Header (Backup GPT Header : 7): verified   CRC32 $4FE040C9
verified   CRC32 $A06C3EC7
/dev/disk4          	GUID_partition_scheme
/dev/disk4s1        	Apple_APFS
/dev/disk5          	EF57347C-0000-11AA-AA11-0030654
/dev/disk5s1        	41504653-0000-11AA-AA11-0030654	/Volumes/Poly Lens 1.4.0

2024-08-14 17:33:58 : INFO  : polylens : Mounted: /Volumes/Poly Lens 1.4.0
2024-08-14 17:33:58 : INFO  : polylens : Verifying: /Volumes/Poly Lens 1.4.0/Poly Lens.app
2024-08-14 17:33:58 : DEBUG : polylens : App size: 402M	/Volumes/Poly Lens 1.4.0/Poly Lens.app
2024-08-14 17:34:00 : DEBUG : polylens : Debugging enabled, App Verification output was:
/Volumes/Poly Lens 1.4.0/Poly Lens.app: accepted
source=Notarized Developer ID
origin=Developer ID Application: Plantronics, Inc. (SKWK2Q7JJV)

2024-08-14 17:34:00 : INFO  : polylens : Team ID matching: SKWK2Q7JJV (expected: SKWK2Q7JJV )
2024-08-14 17:34:00 : INFO  : polylens : Installing Poly Lens version 1.4.0 on versionKey CFBundleShortVersionString.
2024-08-14 17:34:00 : INFO  : polylens : App has LSMinimumSystemVersion: 10.11.0
2024-08-14 17:34:00 : INFO  : polylens : Copy /Volumes/Poly Lens 1.4.0/Poly Lens.app to /Applications
2024-08-14 17:34:00 : DEBUG : polylens : Debugging enabled, App copy output was:
Copying /Volumes/Poly Lens 1.4.0/Poly Lens.app

2024-08-14 17:34:00 : WARN  : polylens : Changing owner to atejada
2024-08-14 17:34:00 : INFO  : polylens : Finishing...
2024-08-14 17:34:03 : INFO  : polylens : App(s) found: /Applications/Poly Lens.app
2024-08-14 17:34:03 : INFO  : polylens : found app at /Applications/Poly Lens.app, version 1.4.0, on versionKey CFBundleShortVersionString
2024-08-14 17:34:03 : REQ   : polylens : Installed Poly Lens, version 1.4.0
2024-08-14 17:34:03 : INFO  : polylens : notifying
2024-08-14 17:34:03 : DEBUG : polylens : Unmounting /Volumes/Poly Lens 1.4.0
2024-08-14 17:34:03 : DEBUG : polylens : Debugging enabled, Unmounting output was:
"disk4" ejected.
2024-08-14 17:34:03 : DEBUG : polylens : Deleting /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.jgo14cjOHj
2024-08-14 17:34:04 : DEBUG : polylens : Debugging enabled, Deleting tmpDir output was:
/var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.jgo14cjOHj/Poly Lens.dmg
2024-08-14 17:34:04 : DEBUG : polylens : /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.jgo14cjOHj
2024-08-14 17:34:04 : INFO  : polylens : Installomator did not close any apps, so no need to reopen any apps.
2024-08-14 17:34:04 : REQ   : polylens : All done!
2024-08-14 17:34:04 : REQ   : polylens : ################## End Installomator, exit code 0

@acodega acodega added the application adds or improves an application label label Jan 16, 2025
@acodega acodega added this to the v10.7 milestone Jan 16, 2025
@acodega acodega merged commit 3bdad5c into Installomator:main Jan 16, 2025
This was referenced Jan 24, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

application adds or improves an application label

Projects

None yet

Milestone

v10.7

Development

Successfully merging this pull request may close these issues.

2 participants

@amadotejada @acodega