Skip to content

Comments

Fix GIMP download#1680

Closed
Maarten-Wijnants wants to merge 2 commits intoInstallomator:mainfrom
Allingtonbe:GIMP
Closed

Fix GIMP download#1680
Maarten-Wijnants wants to merge 2 commits intoInstallomator:mainfrom
Allingtonbe:GIMP

Conversation

@Maarten-Wijnants
Copy link
Contributor

@Maarten-Wijnants Maarten-Wijnants commented May 31, 2024 •
edited
Loading

Fixes #1676

sudo ./installomator.sh gimp BLOCKING_PROCESS_ACTION=prompt_user_loop NOTIFY=silent DEBUG=0

Password:
2024-05-31 14:29:41 : REQ   : gimp : ################## Start Installomator v. 10.5.1, date 2024-03-14
2024-05-31 14:29:41 : INFO  : gimp : ################## Version: 10.5.1
2024-05-31 14:29:41 : INFO  : gimp : ################## Date: 2024-03-14
2024-05-31 14:29:41 : INFO  : gimp : ################## gimp
2024-05-31 14:29:42 : INFO  : gimp : setting variable from argument BLOCKING_PROCESS_ACTION=prompt_user_loop
2024-05-31 14:29:42 : INFO  : gimp : setting variable from argument NOTIFY=silent
2024-05-31 14:29:42 : INFO  : gimp : setting variable from argument DEBUG=0
2024-05-31 14:29:42 : INFO  : gimp : BLOCKING_PROCESS_ACTION=prompt_user_loop
2024-05-31 14:29:42 : INFO  : gimp : NOTIFY=silent
2024-05-31 14:29:42 : INFO  : gimp : LOGGING=INFO
2024-05-31 14:29:42 : INFO  : gimp : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2024-05-31 14:29:42 : INFO  : gimp : Label type: dmg
2024-05-31 14:29:42 : INFO  : gimp : archiveName: GIMP.dmg
2024-05-31 14:29:42 : INFO  : gimp : no blocking processes defined, using GIMP as default
2024-05-31 14:29:42 : INFO  : gimp : name: GIMP, appName: GIMP.app
2024-05-31 14:29:42.531 mdfind[56384:7580944] [UserQueryParser] Loading keywords and predicates for locale "en_US"
2024-05-31 14:29:42.531 mdfind[56384:7580944] [UserQueryParser] Loading keywords and predicates for locale "en"
2024-05-31 14:29:42.613 mdfind[56384:7580944] Couldn't determine the mapping between prefab keywords and predicates.
2024-05-31 14:29:42 : WARN  : gimp : No previous app found
2024-05-31 14:29:42 : WARN  : gimp : could not find GIMP.app
2024-05-31 14:29:42 : INFO  : gimp : appversion: 
2024-05-31 14:29:42 : INFO  : gimp : Latest version of GIMP is 2.10.38
2024-05-31 14:29:42 : REQ   : gimp : Downloading https://download.gimp.org/gimp/v2.10/macos/gimp-2.10.38-arm64-1.dmg to GIMP.dmg
2024-05-31 14:29:52 : REQ   : gimp : no more blocking processes, continue with update
2024-05-31 14:29:52 : REQ   : gimp : Installing GIMP
2024-05-31 14:29:52 : INFO  : gimp : Mounting /var/folders/zz/zyxvpxvq6csfxvn_n0000000000000/T/tmp.GJ9QOsQ3cp/GIMP.dmg
2024-05-31 14:29:55 : INFO  : gimp : Mounted: /Volumes/GIMP 2.10 Install
2024-05-31 14:29:55 : INFO  : gimp : Verifying: /Volumes/GIMP 2.10 Install/GIMP.app
2024-05-31 14:30:06 : INFO  : gimp : Team ID matching: T25BQ8HSJF (expected: T25BQ8HSJF )
2024-05-31 14:30:06 : INFO  : gimp : Installing GIMP version 2.10.38 on versionKey CFBundleShortVersionString.
2024-05-31 14:30:06 : INFO  : gimp : App has LSMinimumSystemVersion: 10.13
2024-05-31 14:30:06 : INFO  : gimp : Copy /Volumes/GIMP 2.10 Install/GIMP.app to /Applications
2024-05-31 14:30:22 : WARN  : gimp : Changing owner to maartenwijnants
2024-05-31 14:30:23 : INFO  : gimp : Finishing...
2024-05-31 14:30:26 : INFO  : gimp : App(s) found: /Applications/GIMP.app
2024-05-31 14:30:26 : INFO  : gimp : found app at /Applications/GIMP.app, version 2.10.38, on versionKey CFBundleShortVersionString
2024-05-31 14:30:26 : REQ   : gimp : Installed GIMP, version 2.10.38
2024-05-31 14:30:27 : INFO  : gimp : Installomator did not close any apps, so no need to reopen any apps.
2024-05-31 14:30:27 : REQ   : gimp : All done!
2024-05-31 14:30:27 : REQ   : gimp : ################## End Installomator, exit code 0

@hwlans hwlans mentioned this pull request Jul 17, 2024
Closed
@otisbison
Copy link

otisbison commented Jul 17, 2024

Might want to escape your periods in the URL and make it match specifically download.gimp.org and add an escaped quote at the end to it doesn't match against the torrent link.

@Maarten-Wijnants
Copy link
Contributor Author

Maarten-Wijnants commented Jul 22, 2024

I've updated the regex a bit as suggested by @otisbison.

@Isokoloff
Copy link

Isokoloff commented Sep 6, 2024 •
edited
Loading

I was still having an issue on 10.5 (but gimp label is currently unchanged in downloaded 10.6 source). A (new?) problem is that current macOS releases, called "GIMP 2.10.38 DMG revision 1", have a trailing "-1" in the DMG names, so:
https://download.gimp.org/gimp/v2.10/macos/gimp-2.10.38-x86_64-1.dmg (instead of usual ...x86_64.dmg)
https://download.gimp.org/gimp/v2.10/macos/gimp-2.10.38-arm64-1.dmg (instead of usual ...arm64.dmg)
Adding the -1 to the label in my local Installomator caused the script to successfully pull version and complete an upgrade installation. I suggest adding * before dmg (so 64.*dmg instead of current 64.dmg) into the grep strings within the gimp label to cover possible additional revision numbers, or otherwise tweaking gimp label to account for this DMG name variance.

@acodega
Copy link
Collaborator

acodega commented Sep 6, 2024

The code in this PR should work whether -1 is in the file name or not. No changes are needed.

@Isokoloff
Copy link

Isokoloff commented Sep 6, 2024

Yes, I should've reviewed PR first, it will resolve when merged, but 10.6 was released without the fix

@MarekBabala
Copy link

MarekBabala commented Sep 6, 2024

I can confirm adding a simple "-1" to the GIMP section as such does wonders and now GIMP is installing

  if [[ $(arch) == "arm64" ]]; then
        downloadURL=https://$(curl -fs https://www.gimp.org/downloads/ | grep -m 1 -o "download.*gimp-.*-arm64-1.dmg")
    elif [[ $(arch) == "i386" ]]; then
        downloadURL=https://$(curl -fs https://www.gimp.org/downloads/ | grep -m 1 -o "download.*gimp-.*-x86_64-1.dmg")
    fi

Great Script nonetheless, recently found out about it and started using in our environment to escape the never ending patch purgatory! - Thank you!

@bartreardon bartreardon added application adds or improves an application label validated App label that has been validated by the validation bot labels Feb 7, 2025
@bartreardon
Copy link
Collaborator

bartreardon commented Feb 7, 2025

🤖 Processing robot:\nFile fragments/labels/gimp.sh
** Label info:
├ Name: ✅ GIMP
├ Type: ✅ dmg
├ Expected Team: ✅ T25BQ8HSJF
├ App New Version: ✅ 2.10.38
└ Download URL: https://download.gimp.org/gimp/v2.10/macos/gimp-2.10.38-arm64-1.dmg
├ ✅ URL is reachable
└ ✅ Download Size: 281.4 MB
✅ All checks passed

@bartreardon bartreardon added this to the v10.8 milestone Feb 7, 2025
@bartreardon bartreardon added the attention-required PR seems fine but some attention is needed before merging label Feb 10, 2025
@MR-Nordsee
Copy link
Contributor

MR-Nordsee commented Feb 28, 2025

Is this still necessary since #1920 got merged?
For me the current state of gimp label works fine.

@scriptingosx scriptingosx added duplicate This issue or pull request already exists and removed attention-required PR seems fine but some attention is needed before merging labels Mar 28, 2025
@scriptingosx
Copy link
Collaborator

scriptingosx commented Mar 28, 2025

duplicate #1920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

application adds or improves an application label duplicate This issue or pull request already exists validated App label that has been validated by the validation bot

Projects

None yet

Milestone

v10.8

Development

Successfully merging this pull request may close these issues.

GIMP download url broken atm

8 participants

@Maarten-Wijnants @otisbison @Isokoloff @acodega @MarekBabala @bartreardon @MR-Nordsee @scriptingosx