Skip to content

Comments

Arguments loading before and after labels#1648

Merged
Theile merged 8 commits intoInstallomator:mainfrom
Theile:Arguments-loading-before-and-after-labels
Jan 26, 2025
Merged

Arguments loading before and after labels#1648
Theile merged 8 commits intoInstallomator:mainfrom
Theile:Arguments-loading-before-and-after-labels

Conversation

@Theile
Copy link
Collaborator

@Theile Theile commented May 10, 2024

This change will read arguments BEFORE and AFTER the case statement for labels.

It means that lsagent label will work again, and that we can still fix things in labels.

utils/assemble.sh lsagent LOGGING=DEBUG lsagentServer=1.1.1.1 INSTALL=force name=TEST
2024-05-10 15:45:04 : INFO  : lsagent : setting variable from argument LOGGING=DEBUG
2024-05-10 15:45:05 : INFO  : lsagent : setting variable from argument lsagentServer=1.1.1.1
2024-05-10 15:45:05 : INFO  : lsagent : setting variable from argument INSTALL=force
2024-05-10 15:45:05 : INFO  : lsagent : setting variable from argument name=TEST
2024-05-10 15:45:05 : INFO  : lsagent : Total items in argumentsArray: 4
2024-05-10 15:45:05 : INFO  : lsagent : argumentsArray: LOGGING=DEBUG lsagentServer=1.1.1.1 INSTALL=force name=TEST
2024-05-10 15:45:05 : REQ   : lsagent : ################## Start Installomator v. 10.6beta, date 2024-05-10
2024-05-10 15:45:05 : INFO  : lsagent : ################## Version: 10.6beta
2024-05-10 15:45:05 : INFO  : lsagent : ################## Date: 2024-05-10
2024-05-10 15:45:05 : INFO  : lsagent : ################## lsagent
2024-05-10 15:45:05 : DEBUG : lsagent : DEBUG mode 1 enabled.
2024-05-10 15:45:05 : INFO  : lsagent : Reading arguments again: LOGGING=DEBUG lsagentServer=1.1.1.1 INSTALL=force name=TEST
2024-05-10 15:45:05 : DEBUG : lsagent : argument: LOGGING=DEBUG
2024-05-10 15:45:05 : DEBUG : lsagent : argument: lsagentServer=1.1.1.1
2024-05-10 15:45:05 : DEBUG : lsagent : argument: INSTALL=force
2024-05-10 15:45:05 : DEBUG : lsagent : argument: name=TEST
2024-05-10 15:45:06 : DEBUG : lsagent : name=TEST
2024-05-10 15:45:06 : DEBUG : lsagent : appName=
2024-05-10 15:45:06 : DEBUG : lsagent : type=dmg
2024-05-10 15:45:06 : DEBUG : lsagent : archiveName=
2024-05-10 15:45:06 : DEBUG : lsagent : downloadURL=https://content.lansweeper.com/lsagent-mac/
2024-05-10 15:45:06 : DEBUG : lsagent : curlOptions=
2024-05-10 15:45:06 : DEBUG : lsagent : appNewVersion=10.2.0.0
2024-05-10 15:45:06 : DEBUG : lsagent : appCustomVersion function: Not defined
2024-05-10 15:45:06 : DEBUG : lsagent : versionKey=CFBundleShortVersionString
2024-05-10 15:45:06 : DEBUG : lsagent : packageID=
2024-05-10 15:45:06 : DEBUG : lsagent : pkgName=
2024-05-10 15:45:06 : DEBUG : lsagent : choiceChangesXML=
2024-05-10 15:45:06 : DEBUG : lsagent : expectedTeamID=65LX6K7CBA
2024-05-10 15:45:06 : DEBUG : lsagent : blockingProcesses=
2024-05-10 15:45:06 : DEBUG : lsagent : installerTool=LsAgent-osx.app
2024-05-10 15:45:06 : DEBUG : lsagent : CLIInstaller=LsAgent-osx.app/Contents/MacOS/installbuilder.sh
2024-05-10 15:45:06 : DEBUG : lsagent : CLIArguments=--mode osx --installer-language en --server 1.1.1.1 --port 9524
2024-05-10 15:45:06 : DEBUG : lsagent : updateTool=
2024-05-10 15:45:06 : DEBUG : lsagent : updateToolArguments=
2024-05-10 15:45:06 : DEBUG : lsagent : updateToolRunAsCurrentUser=

@Theile Theile added the feature New feature or request label May 10, 2024
@Theile Theile requested a review from scriptingosx May 10, 2024 13:48
@Theile Theile mentioned this pull request May 10, 2024
Closed
@Theile Theile added this to the v10.6 milestone May 15, 2024
Theile added 5 commits May 29, 2024 09:15
@Theile
PROXY variable added
9393c84 
Use `PROXY` variable to specify a proxy so that `curl` can work through that if needed.
@Theile
Testing proxy before using it
fc69116
@Theile
Update arguments.sh
a04919e
@Theile
Update arguments.sh
32bb33d
@Theile
Update arguments.sh
f36b9a3 
It IS the right thing to test for contact to the proxy server before defining it.
@scriptingosx scriptingosx modified the milestones: v10.6, v10.7 Aug 30, 2024
@scriptingosx scriptingosx modified the milestones: v10.7, v10.8 Jan 24, 2025
@Theile Theile merged commit f675e6d into Installomator:main Jan 26, 2025
1 check passed
@Theile Theile deleted the Arguments-loading-before-and-after-labels branch January 26, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@scriptingosx scriptingosx Awaiting requested review from scriptingosx

Assignees

No one assigned

Labels

feature New feature or request

Projects

None yet

Milestone

v10.8

Development

Successfully merging this pull request may close these issues.

2 participants

@Theile @scriptingosx