Allow for Logitec Options Plus to fetch versions for macOS 12+#1531
Merged
BigMacAdmin merged 3 commits intoInstallomator:mainfrom Apr 14, 2024
Merged
Conversation
Collaborator
|
Thanks for your contribution, @pmex . Is there a reason you are changing When I download the zip, the appName is the old value: |
BigMacAdmin
added
application
Contributor
Author
|
The reason is that it couldn't read the already installed version, if I didn't split it into both |
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest version of Logi Options+ requires macOS 12+
If older macOS is specified in the url for appNewVersion, it will never correspond to the installed version
2024-03-11 13:52:15 : REQ : logitechoptionsplus : ################## Start Installomator v. 10.6beta, date 2024-03-11
2024-03-11 13:52:15 : INFO : logitechoptionsplus : ################## Version: 10.6beta
2024-03-11 13:52:15 : INFO : logitechoptionsplus : ################## Date: 2024-03-11
2024-03-11 13:52:15 : INFO : logitechoptionsplus : ################## logitechoptionsplus
2024-03-11 13:52:15 : DEBUG : logitechoptionsplus : DEBUG mode 1 enabled.
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : name=Logi Options+
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : appName=logioptionsplus.app
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : type=zip
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : archiveName=logioptionsplus_installer.zip
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : downloadURL=https://download01.logi.com/web/ftp/pub/techsupport/optionsplus/logioptionsplus_installer.zip
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : curlOptions=
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : appNewVersion=1.66.531337
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : appCustomVersion function: Not defined
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : versionKey=CFBundleShortVersionString
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : packageID=
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : pkgName=
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : choiceChangesXML=
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : expectedTeamID=QED4VVPZWA
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : blockingProcesses=
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : installerTool=logioptionsplus_installer.app
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : CLIInstaller=logioptionsplus_installer.app/Contents/MacOS/logioptionsplus_installer
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : CLIArguments=--quiet
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : updateTool=
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : updateToolArguments=
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : updateToolRunAsCurrentUser=
2024-03-11 13:52:16 : INFO : logitechoptionsplus : BLOCKING_PROCESS_ACTION=tell_user
2024-03-11 13:52:16 : INFO : logitechoptionsplus : NOTIFY=success
2024-03-11 13:52:16 : INFO : logitechoptionsplus : LOGGING=DEBUG
2024-03-11 13:52:16 : INFO : logitechoptionsplus : LOGO=/System/Applications/App Store.app/Contents/Resources/AppIcon.icns
2024-03-11 13:52:16 : INFO : logitechoptionsplus : Label type: zip
2024-03-11 13:52:16 : INFO : logitechoptionsplus : archiveName: logioptionsplus_installer.zip
2024-03-11 13:52:16 : INFO : logitechoptionsplus : no blocking processes defined, using Logi Options+ as default
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : Changing directory to /path_to_local_git_repo/Installomator/build
2024-03-11 13:52:16 : INFO : logitechoptionsplus : App(s) found: /Applications/logioptionsplus.app
2024-03-11 13:52:16 : INFO : logitechoptionsplus : found app at /Applications/logioptionsplus.app, version 1.66.531337, on versionKey CFBundleShortVersionString
2024-03-11 13:52:16 : INFO : logitechoptionsplus : appversion: 1.66.531337
2024-03-11 13:52:16 : INFO : logitechoptionsplus : Latest version of Logi Options+ is 1.66.531337
2024-03-11 13:52:16 : WARN : logitechoptionsplus : DEBUG mode 1 enabled, not exiting, but there is no new version of app.
2024-03-11 13:52:16 : REQ : logitechoptionsplus : Downloading https://download01.logi.com/web/ftp/pub/techsupport/optionsplus/logioptionsplus_installer.zip to logioptionsplus_installer.zip
2024-03-11 13:52:16 : DEBUG : logitechoptionsplus : No Dialog connection, just download
2024-03-11 13:52:20 : DEBUG : logitechoptionsplus : File list: -rw-r--r-- 1 username staff 18M Mar 11 13:52 logioptionsplus_installer.zip
2024-03-11 13:52:20 : DEBUG : logitechoptionsplus : File type: logioptionsplus_installer.zip: Zip archive data, at least v2.0 to extract, compression method=store
2024-03-11 13:52:20 : DEBUG : logitechoptionsplus : curl output was:
} [324 bytes data]
{ [122 bytes data]
{ [19 bytes data]
{ [5017 bytes data]
{ [264 bytes data]
{ [36 bytes data]
} [36 bytes data]
< HTTP/2 200
< content-type: application/x-zip-compressed
< content-length: 18891949
< last-modified: Wed, 06 Mar 2024 07:45:44 GMT
< x-amz-server-side-encryption: AES256
< x-amz-meta-cb-modifiedtime: Wed, 06 Mar 2024 03:24:43 GMT
< x-amz-version-id: ob3nka2D2jZCYhwI8uxyopa8EAFj2xr1
< accept-ranges: bytes
< server: AmazonS3
< date: Mon, 11 Mar 2024 07:18:24 GMT
< etag: "604187971d4d0046e3ae47dcdd270583"
< vary: Accept-Encoding
< x-cache: Hit from cloudfront
< via: 1.1 f26fbc8f93ad20ccbbd480fccb1e6f88.cloudfront.net (CloudFront)
< x-amz-cf-pop: ARN56-P2
< x-amz-cf-id: KUVmCcAPerjrjtwVi7bRXwUJbS-1hE-Y_BD4dj1u4ex7wwdCFIBXdQ==
< age: 20036
<
{ [101770 bytes data]
2024-03-11 13:52:20 : DEBUG : logitechoptionsplus : DEBUG mode 1, not checking for blocking processes
2024-03-11 13:52:20 : REQ : logitechoptionsplus : Installing Logi Options+
2024-03-11 13:52:20 : REQ : logitechoptionsplus : installerTool used: logioptionsplus_installer.app
2024-03-11 13:52:20 : INFO : logitechoptionsplus : Unzipping logioptionsplus_installer.zip
2024-03-11 13:52:20 : INFO : logitechoptionsplus : Verifying: /path_to_local_git_repo/Installomator/build/logioptionsplus_installer.app
2024-03-11 13:52:20 : DEBUG : logitechoptionsplus : App size: 42M /path_to_local_git_repo/Installomator/build/logioptionsplus_installer.app
2024-03-11 13:52:20 : DEBUG : logitechoptionsplus : Debugging enabled, App Verification output was:
/path_to_local_git_repo/Installomator/build/logioptionsplus_installer.app: accepted
source=Notarized Developer ID
origin=Developer ID Application: Logitech Inc. (QED4VVPZWA)
2024-03-11 13:52:20 : INFO : logitechoptionsplus : Team ID matching: QED4VVPZWA (expected: QED4VVPZWA )
2024-03-11 13:52:20.573 defaults[69160:857415]
The domain/default pair of (/path_to_local_git_repo/Installomator/build/logioptionsplus_installer.app/Contents/Info.plist, CFBundleShortVersionString) does not exist
2024-03-11 13:52:20 : INFO : logitechoptionsplus : Downloaded version of Logi Options+ is on versionKey CFBundleShortVersionString (replacing version 1.66.531337).
2024-03-11 13:52:20 : INFO : logitechoptionsplus : App has LSMinimumSystemVersion: 12.0
2024-03-11 13:52:20 : DEBUG : logitechoptionsplus : DEBUG mode 1 enabled, skipping remove, copy and chown steps
2024-03-11 13:52:20 : INFO : logitechoptionsplus : Finishing...
2024-03-11 13:52:23 : INFO : logitechoptionsplus : name: Logi Options+, appName: logioptionsplus_installer.app
2024-03-11 13:52:23.686 mdfind[69181:857580] [UserQueryParser] Loading keywords and predicates for locale "sv_SE"
2024-03-11 13:52:23.686 mdfind[69181:857580] [UserQueryParser] Loading keywords and predicates for locale "sv"
2024-03-11 13:52:23.805 mdfind[69181:857580] Couldn't determine the mapping between prefab keywords and predicates.
2024-03-11 13:52:23.805 mdfind[69181:857580] Couldn't determine the mapping between prefab keywords and predicates.
2024-03-11 13:52:24 : WARN : logitechoptionsplus : No previous app found
2024-03-11 13:52:24 : WARN : logitechoptionsplus : could not find logioptionsplus_installer.app
2024-03-11 13:52:24 : REQ : logitechoptionsplus : Installed Logi Options+
2024-03-11 13:52:24 : INFO : logitechoptionsplus : notifying
2024-03-11 13:52:25 : DEBUG : logitechoptionsplus : DEBUG mode 1, not reopening anything
2024-03-11 13:52:25 : REQ : logitechoptionsplus : All done!
2024-03-11 13:52:25 : REQ : logitechoptionsplus : ################## End Installomator, exit code 0