Mdm script SwiftDdialog fix#1476
Merged
Theile merged 9 commits intoInstallomator:mainfrom May 23, 2024
Merged
Conversation
Support for overlay icon, and fix for correct call of SwiftDialog.
Contributor
|
Just worth noting, I'm not a reviewer, but I hope they see this to better understand @Theile's request, and not get confused by the wording of the request. |
Collaborator
Author
|
Yes, thank you. You are absolutely right. We have full focus on getting this merged and released soon. |
The Jamf recon only happens if Installomator actually installed something. In case of "Latest version already installed" it will not do recon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the MDM scripts so that the call to SwiftDialog is done to the binary in
/usr/local/bin/dialog.The Jamf scripts have been testet, but not the other MDM scripts.