Add timeout to prevent blocking other processes#140
Closed
Raptor399 wants to merge 6 commits intoInstallomator:devfrom
Closed
Add timeout to prevent blocking other processes#140Raptor399 wants to merge 6 commits intoInstallomator:devfrom
Raptor399 wants to merge 6 commits intoInstallomator:devfrom
Conversation
…er which the dialogue box will give up waiting for a button click. This prevents the script from blocking other processes while the user ignores the dialogue box for a prolonged period of time. Inspired by @saess-sep commit scriptingosx@d6c255d
# Conflicts: # CHANGELOG.md # Installomator.sh
# Conflicts: # fragments/functions.sh
Collaborator
|
overlaps with #771 |
Contributor
Author
|
Correct. #771 is the light version of this PR, quietly managing the "Not now" variant. This PR messages the user what's about to happen and differentiates its behaviour based on the preferred type of action. Either PR will remedy the problem of the Installomator script blocking its parent process due to user inaction, which makes the execution of Jamf policies unreliable. It would be really nice if one of the PRs could be included in a future release. |
# Conflicts: # CHANGELOG.md # fragments/functions.sh
Collaborator
|
Resubmit/resolve conflicts, this can not be editing files outside of fragments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added variable
TIMEOUTthat can be set to the number of seconds.When the timeout expires, the dialogue box will give up waiting for a button click.
This prevents the script from blocking other processes while the user ignores the
dialogue box for a prolonged period of time.
Although TIMEOUT should probably not be empty by default, I kept it that way to
not introduce changes to the existing script and stick to its earlier behavior.
Inspired by @saess-sep commit scriptingosx@d6c255d